jdyer1 opened a new pull request, #2828: URL: https://github.com/apache/solr/pull/2828
Similar to #2805, this is a minimal PR to add Load Balancing functionality for `HttpJdkSolrClient`. Included is test refactoring, adding the *JdkClient as a random choice for the integration test. Whereas #2805 created a class hierarchy, this makes `LBHttp2SolrClient` generic. Adding a generic parameter to this class will not break backwards-compatibility. This seems a better option that #2805. One downside is we retain the name `LBHttp2SolrClient` although it is no longer strictly to be used with `Http2SolrClient`. However, the legacy implementation already uses the preferred name: `LBHttpSolrClient`. Whenever the legacy implementation is removed, I recommend also renaming `LBHttp2SolrClient` to `LBHttpSolrClient`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
