gerlowskija commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1824584360
##########
solr/core/src/test/org/apache/solr/handler/TestUserManagedReplicationWithAuth.java:
##########
@@ -227,26 +228,26 @@ private QueryResponse queryWithBasicAuth(SolrClient
client, SolrQuery q)
return withBasicAuth(new QueryRequest(q)).process(client);
}
- private void disablePoll(JettySolrRunner Jetty, SolrClient solrClient)
+ private void disablePoll(JettySolrRunner Jetty, Http2SolrClient solrClient)
throws SolrServerException, IOException {
ModifiableSolrParams disablePollParams = new ModifiableSolrParams();
disablePollParams.set(COMMAND, CMD_DISABLE_POLL);
disablePollParams.set(CommonParams.WT, JAVABIN);
disablePollParams.set(CommonParams.QT, ReplicationHandler.PATH);
QueryRequest req = new QueryRequest(disablePollParams);
withBasicAuth(req);
- req.setBasePath(buildUrl(Jetty.getLocalPort()));
- solrClient.request(req, DEFAULT_TEST_CORENAME);
+ final var baseUrl = buildUrl(Jetty.getLocalPort());
+ solrClient.requestWithBaseUrl(baseUrl, DEFAULT_TEST_CORENAME, req);
}
private void pullIndexFromTo(
JettySolrRunner srcSolr, JettySolrRunner destSolr, boolean authEnabled)
throws SolrServerException, IOException {
String srcUrl = buildUrl(srcSolr.getLocalPort()) + "/" +
DEFAULT_TEST_CORENAME;
- String destUrl = buildUrl(destSolr.getLocalPort()) + "/" +
DEFAULT_TEST_CORENAME;
QueryRequest req = getQueryRequestForFetchIndex(authEnabled, srcUrl);
- req.setBasePath(buildUrl(destSolr.getLocalPort()));
+ final var baseUrl = buildUrl(destSolr.getLocalPort());
+ followerClient.requestWithBaseUrl(baseUrl, DEFAULT_TEST_CORENAME, req);
followerClient.request(req, DEFAULT_TEST_CORENAME);
Review Comment:
Great catch; done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
