Re: [PR] Cleanup JDK version related logic in scripts [solr]

2024-10-25 Thread via GitHub
epugh commented on code in PR #2792: URL: https://github.com/apache/solr/pull/2792#discussion_r1815533533 ## solr/bin/solr: ## @@ -1054,31 +1054,13 @@ fi # Establish default GC logging opts if no env var set (otherwise init to sensible default) if [ -z "${GC_LOG_OPTS}" ]; t

[jira] [Commented] (SOLR-17161) Separate out a solrj-jetty artifact (10.0)

2024-10-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892565#comment-17892565 ] Jason Gerlowski commented on SOLR-17161: I guess I have a potential concern about

Re: [PR] SOLR-17504: CoreContainer calls UpdateHandler.commit. [solr]

2024-10-25 Thread via GitHub
dsmiley commented on code in PR #2786: URL: https://github.com/apache/solr/pull/2786#discussion_r1815544031 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2061,13 +2066,16 @@ public void reload(String name, UUID coreId) { RefCounted iwRef = cor

[jira] [Commented] (SOLR-17497) Pull replicas throws AlreadyClosedException

2024-10-25 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892684#comment-17892684 ] Sanjay Dutt commented on SOLR-17497: {code:java} @Test public void test(){ ExecutorS

[jira] [Updated] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-17515: --- Description: Several reporters on the users@ list, recently shared a bug they noticed on upg

[jira] [Commented] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892831#comment-17892831 ] Jason Gerlowski commented on SOLR-17515: [~sanjaydutt] pointed me at the likely c

[PR] SOLR-10654: Prometheus regex cloud pattern fix for core names [solr]

2024-10-25 Thread via GitHub
mlbiscoc opened a new pull request, #2795: URL: https://github.com/apache/solr/pull/2795 https://issues.apache.org/jira/browse/SOLR-10654 # Description The regex pattern for Solr cloud mode assumed all core names ended with a `replica_n[0-9]+` which is incorrect. Some core name

Re: [PR] Bump up Java version to 21 [solr]

2024-10-25 Thread via GitHub
iamsanjay merged PR #2682: URL: https://github.com/apache/solr/pull/2682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-17511) CLI: Resole -i conflicts (async-id, cluster-id)

2024-10-25 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892748#comment-17892748 ] Eric Pugh commented on SOLR-17511: --  think instead of ExportTool you mean SolrExporter ;

[jira] [Updated] (SOLR-17511) CLI: Resole -i conflicts (async-id, cluster-id)

2024-10-25 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17511: Description: The CLI flag {{\-i}} is currently used in two options: - for {{async-i

Re: [PR] SOLR-17511: Deprecate -i CLI usages [solr]

2024-10-25 Thread via GitHub
epugh commented on PR #2794: URL: https://github.com/apache/solr/pull/2794#issuecomment-2437644101 Thanks for the review! I think if the tests pass this is ready for merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] SOLR-17511: Deprecate -i CLI usages [solr]

2024-10-25 Thread via GitHub
malliaridis commented on code in PR #2794: URL: https://github.com/apache/solr/pull/2794#discussion_r1816622405 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/scraper/SolrScraper.java: ## @@ -184,7 +184,7 @@ protected MetricSamples request(SolrClient client, Me

[jira] [Comment Edited] (SOLR-17497) Pull replicas throws AlreadyClosedException

2024-10-25 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892798#comment-17892798 ] Sanjay Dutt edited comment on SOLR-17497 at 10/25/24 1:29 PM: -

[jira] [Commented] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892821#comment-17892821 ] Jason Gerlowski commented on SOLR-17515: Credit and thanks to Patrik Peng and End

[jira] [Commented] (SOLR-17497) Pull replicas throws AlreadyClosedException

2024-10-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892780#comment-17892780 ] David Smiley commented on SOLR-17497: - bq. execute throws exception rather than supp

[jira] [Commented] (SOLR-17497) Pull replicas throws AlreadyClosedException

2024-10-25 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892798#comment-17892798 ] Sanjay Dutt commented on SOLR-17497: Yeah you are right, I have to look into this sub

[jira] [Created] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-25 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17515: -- Summary: Recovery fails in Solr 9.7.0 if basic-auth is enabled Key: SOLR-17515 URL: https://issues.apache.org/jira/browse/SOLR-17515 Project: Solr Issue

[jira] [Commented] (SOLR-17497) Pull replicas throws AlreadyClosedException

2024-10-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893024#comment-17893024 ] David Smiley commented on SOLR-17497: - I'm confused; is this one JIRA issue about two

[PR] Fix SolrJmxReporterTest#testClosedCore [solr]

2024-10-25 Thread via GitHub
iamsanjay opened a new pull request, #2797: URL: https://github.com/apache/solr/pull/2797 This PR addresses a race condition in the code where a separate thread continuously retrieves attributes from an MBean, while the main thread may unload the MBean before the retrieval thread has fully

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-10-25 Thread via GitHub
iamsanjay commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-2439282497 git bisect points to this PR. Require bit more attention to see whether this PR causing it or not. **org.apache.solr.search.TestCollapseQParserPlugin.testMultiSort (:solr:core)**

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-10-25 Thread via GitHub
HoustonPutman commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1817369402 ## solr/test-framework/build.gradle: ## @@ -43,6 +43,17 @@ dependencies { var zkExcludes = { exclude group: "org.apache.yetus", module: "audience-annotations"

Re: [PR] SOLR-16470: Create V2 equivalent of V1 Replication: Get files/{filePath} [solr]

2024-10-25 Thread via GitHub
gerlowskija commented on code in PR #2734: URL: https://github.com/apache/solr/pull/2734#discussion_r1817490345 ## solr/core/src/java/org/apache/solr/handler/admin/api/CoreReplicationAPI.java: ## @@ -68,6 +71,45 @@ public FileListResponse fetchFileList( return doFetchFileLi

[jira] [Commented] (SOLR-17497) Pull replicas throws AlreadyClosedException

2024-10-25 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893025#comment-17893025 ] Sanjay Dutt commented on SOLR-17497: Sorry, Initially I had no idea what's going on s

[jira] [Updated] (SOLR-16962) updateLog tlog dir location config is silently ignored

2024-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-16962: -- Labels: pull-request-available (was: ) > updateLog tlog dir location config is silently ignore

[jira] [Commented] (SOLR-17511) CLI: Resole -i conflicts (async-id, cluster-id)

2024-10-25 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892754#comment-17892754 ] Christos Malliaridis commented on SOLR-17511: - That is right, thanks for the

[jira] [Updated] (SOLR-17511) CLI: Resole -i conflicts (async-id, cluster-id)

2024-10-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17511: -- Labels: cli pull-request-available (was: cli) > CLI: Resole -i conflicts (async-id, cluster-id

[jira] [Resolved] (SOLR-17488) CLI: Resolve -d conflicts

2024-10-25 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17488. -- Fix Version/s: 9.8 Resolution: Fixed > CLI: Resolve -d conflicts > - > >

[jira] [Updated] (SOLR-17511) CLI: Resolve -i conflicts (async-id, cluster-id)

2024-10-25 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-17511: - Summary: CLI: Resolve -i conflicts (async-id, cluster-id) (was: CLI: Resole -i conflicts (async-id, clus

[jira] [Assigned] (SOLR-17511) CLI: Resole -i conflicts (async-id, cluster-id)

2024-10-25 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17511: Assignee: Eric Pugh > CLI: Resole -i conflicts (async-id, cluster-id) > --

[jira] [Comment Edited] (SOLR-6122) API to cancel an already submitted/running Collections API call

2024-10-25 Thread Yuntong Qu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892240#comment-17892240 ] Yuntong Qu edited comment on SOLR-6122 at 10/25/24 2:54 PM: Ma

[jira] [Assigned] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-17515: -- Assignee: Jason Gerlowski > Recovery fails in Solr 9.7.0 if basic-auth is enabled > --

[jira] [Commented] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-25 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892962#comment-17892962 ] Sanjay Dutt commented on SOLR-17515: Thank you so much [~gerlowskija] for reproducing

[jira] [Commented] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-25 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892967#comment-17892967 ] Sanjay Dutt commented on SOLR-17515: We both updated it same time. That's great! Yes

[PR] Fix release wizard to remove from Solr space before attempting Lucene [solr]

2024-10-25 Thread via GitHub
anshumg opened a new pull request, #2796: URL: https://github.com/apache/solr/pull/2796 We should just remove attempting to cleanup the Lucene space once we do the Solr 10.0 release. Right now the wizard fails when it tries to cleanup the Lucene space because the 9x Solr releases are not fo

Re: [PR] EOL Solr 8 [solr-site]

2024-10-25 Thread via GitHub
HoustonPutman commented on PR #131: URL: https://github.com/apache/solr-site/pull/131#issuecomment-2438874511 Ok, revised the two sentences. Happy to change it to whatever if you still don't like it. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] EOL Solr 8 [solr-site]

2024-10-25 Thread via GitHub
anshumg commented on code in PR #131: URL: https://github.com/apache/solr-site/pull/131#discussion_r1817178495 ## content/solr/solr_news/2024-10-25-solr8-eol.md: ## @@ -0,0 +1,8 @@ +Title: Solr 8 reaches End-Of-Life +category: solr/news +save_as: + +After the release of Solr 8.1

Re: [PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-10-25 Thread via GitHub
gerlowskija commented on PR #2788: URL: https://github.com/apache/solr/pull/2788#issuecomment-2438568772 Still going through the individual files on this PR, but wanted to respond to some of the high-level comments first: > Wasn't sure how to model the response. Different APIs use dif

[PR] EOL Solr 8 [solr-site]

2024-10-25 Thread via GitHub
HoustonPutman opened a new pull request, #131: URL: https://github.com/apache/solr-site/pull/131 Made a small news page, and changed the downloads to state 8.11 is EOL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Created] (SOLR-17516) LBHttpSolrClient: support HttpJdkSolrClient

2024-10-25 Thread James Dyer (Jira)
James Dyer created SOLR-17516: - Summary: LBHttpSolrClient: support HttpJdkSolrClient Key: SOLR-17516 URL: https://issues.apache.org/jira/browse/SOLR-17516 Project: Solr Issue Type: Improvement

Re: [PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-10-25 Thread via GitHub
gerlowskija commented on code in PR #2788: URL: https://github.com/apache/solr/pull/2788#discussion_r1817160658 ## solr/api/src/java/org/apache/solr/client/api/endpoint/SetClusterPropertyApi.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under