dsmiley commented on code in PR #2786:
URL: https://github.com/apache/solr/pull/2786#discussion_r1815544031


##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2061,13 +2066,16 @@ public void reload(String name, UUID coreId) {
           RefCounted<IndexWriter> iwRef = 
core.getSolrCoreState().getIndexWriter(null);
           if (iwRef != null) {
             IndexWriter iw = iwRef.get();
-            // switch old core to readOnly
-            core.readOnly = true;

Review Comment:
   as an aside, I don't like that CoreContainer is doing SolrCore internal 
manipulations... like this should be a method on SolrCore like core.commit()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to