epugh commented on PR #2758:
URL: https://github.com/apache/solr/pull/2758#issuecomment-2408820754
Thoughts on how to mark it "deprecated" in 9x? In some places it makes
sense to put out a log message. What would being deprecated mean here? Just
a PR that adds `@deprecated` in the `br
Eric Pugh created SOLR-17496:
Summary: Reword messaging about Zookeeper in startup logs
Key: SOLR-17496
URL: https://issues.apache.org/jira/browse/SOLR-17496
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-17496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-17496:
-
Description:
We output text like:
TARTING EMBEDDED ENSEMBLE ZOOKEEPER SERVER at port 9983, listening
gerlowskija commented on code in PR #2758:
URL: https://github.com/apache/solr/pull/2758#discussion_r1797929696
##
solr/core/src/test/org/apache/solr/response/JSONWriterTest.java:
##
@@ -53,24 +53,17 @@ private void jsonEq(String expected, String received) {
}
@Test
- p
malliaridis commented on code in PR #2756:
URL: https://github.com/apache/solr/pull/2756#discussion_r1797711145
##
solr/core/src/java/org/apache/solr/cli/PostLogsTool.java:
##
@@ -66,24 +67,46 @@ public List getOptions() {
return List.of(
Option.builder("url")
epugh commented on code in PR #2754:
URL: https://github.com/apache/solr/pull/2754#discussion_r1797712401
##
solr/bin/solr.cmd:
##
@@ -1520,7 +1521,9 @@ for %%a in (%*) do (
) else (
set "option!option!=%%a"
if "!option!" equ "-d" set "SOLR_SERVER_DIR=%%a"
+
epugh commented on code in PR #2756:
URL: https://github.com/apache/solr/pull/2756#discussion_r1797734402
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -85,8 +85,10 @@ public void testBasicRun() throws Exception {
String[] args = {
"post",
-
[
https://issues.apache.org/jira/browse/SOLR-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888913#comment-17888913
]
Christos Malliaridis commented on SOLR-17488:
-
Right now, the user has to pro
malliaridis commented on code in PR #2760:
URL: https://github.com/apache/solr/pull/2760#discussion_r1797721419
##
solr/bin/solr.cmd:
##
@@ -1519,11 +1519,11 @@ for %%a in (%*) do (
if "!arg:~0,1!" equ "-" set "option=!arg!"
) else (
set "option!option!=%%a"
-
[
https://issues.apache.org/jira/browse/SOLR-17478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888954#comment-17888954
]
David Smiley commented on SOLR-17478:
-
+1 simply trusting this works
> ZkTestServer
malliaridis commented on code in PR #2754:
URL: https://github.com/apache/solr/pull/2754#discussion_r1797701186
##
solr/bin/solr.cmd:
##
@@ -1520,7 +1521,9 @@ for %%a in (%*) do (
) else (
set "option!option!=%%a"
if "!option!" equ "-d" set "SOLR_SERVER_DIR=%%a
[
https://issues.apache.org/jira/browse/SOLR-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888923#comment-17888923
]
Eric Pugh commented on SOLR-17488:
--
I think this deserves it's own JIRA... I like the i
[
https://issues.apache.org/jira/browse/SOLR-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888924#comment-17888924
]
Eric Pugh commented on SOLR-17488:
--
See SOLR-17495
> CLI: Resolve -d conflicts
> --
Eric Pugh created SOLR-17495:
Summary: Change CLI DeleteTool deleting of configs to opt in
instead of default behavior
Key: SOLR-17495
URL: https://issues.apache.org/jira/browse/SOLR-17495
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888928#comment-17888928
]
Christos Malliaridis commented on SOLR-17488:
-
Sounds good. Thanks for creati
epugh opened a new pull request, #2760:
URL: https://github.com/apache/solr/pull/2760
https://issues.apache.org/jira/browse/SOLR-17488
Bug fix based on feedback from @malliaridis.
We need to take a pass through solr.cmd and see if we can reduce the custom
per option parsing!
epugh commented on code in PR #2754:
URL: https://github.com/apache/solr/pull/2754#discussion_r1797715501
##
solr/bin/solr.cmd:
##
@@ -1520,7 +1521,9 @@ for %%a in (%*) do (
) else (
set "option!option!=%%a"
if "!option!" equ "-d" set "SOLR_SERVER_DIR=%%a"
+
epugh opened a new pull request, #2761:
URL: https://github.com/apache/solr/pull/2761
https://issues.apache.org/jira/browse/SOLR-17495
# Description
See jira
# Solution
Makes --delete-config a opt in flag that specifies the user wants to delete
their config al
[
https://issues.apache.org/jira/browse/SOLR-17495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17495:
--
Labels: pull-request-available (was: )
> Change CLI DeleteTool deleting of configs to opt in i
epugh commented on PR #2761:
URL: https://github.com/apache/solr/pull/2761#issuecomment-2408625057
@malliaridis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
github-actions[bot] commented on PR #1990:
URL: https://github.com/apache/solr/pull/1990#issuecomment-2408749803
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2644:
URL: https://github.com/apache/solr/pull/2644#issuecomment-2408749687
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2608:
URL: https://github.com/apache/solr/pull/2608#issuecomment-2408749712
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2129:
URL: https://github.com/apache/solr/pull/2129#issuecomment-2408749793
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2130:
URL: https://github.com/apache/solr/pull/2130#issuecomment-2408749780
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2441:
URL: https://github.com/apache/solr/pull/2441#issuecomment-2408749753
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2617:
URL: https://github.com/apache/solr/pull/2617#issuecomment-2408749700
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2583:
URL: https://github.com/apache/solr/pull/2583#issuecomment-2408749725
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2581:
URL: https://github.com/apache/solr/pull/2581#issuecomment-2408749738
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2268:
URL: https://github.com/apache/solr/pull/2268#issuecomment-2408749762
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2639:
URL: https://github.com/apache/solr/pull/2639#issuecomment-2408749695
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
31 matches
Mail list logo
