malliaridis commented on code in PR #2754:
URL: https://github.com/apache/solr/pull/2754#discussion_r1797701186
##########
solr/bin/solr.cmd:
##########
@@ -1520,7 +1521,9 @@ for %%a in (%*) do (
) else (
set "option!option!=%%a"
if "!option!" equ "-d" set "SOLR_SERVER_DIR=%%a"
+ if "!option!" equ "--server-dir" set "SOLR_SERVER_DIR=%%a"
if "!option!" equ "-s" set "SOLR_HOME=%%a"
+ if "!option!" equ "--solr-home" set "SOLR_HOME=%%a"
if not "!option!" equ "-s" if not "!option!" equ "-d" (
set "AUTH_PARAMS=!AUTH_PARAMS! !option! %%a"
)
Review Comment:
Is this code block still gonna work correctly if `--server-dir` and
`--solr-home` is used instead?
I feel like we have to somehow get rid of these lists of options, they seem
very error-prone and can be easily forgotten when we make changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
