gerlowskija commented on code in PR #2758: URL: https://github.com/apache/solr/pull/2758#discussion_r1797929696
########## solr/core/src/test/org/apache/solr/response/JSONWriterTest.java: ########## @@ -53,24 +53,17 @@ private void jsonEq(String expected, String received) { } @Test - public void testTypes() throws IOException { + public void testSimpleJson() throws IOException { SolrQueryRequest req = req("q", "dummy", "indent", "off"); SolrQueryResponse rsp = new SolrQueryResponse(); - QueryResponseWriter w = new PythonResponseWriter(); + QueryResponseWriter w = new JSONResponseWriter(); + new StringWriter(); + StringWriter buf; Review Comment: [-1] I think L60-L61 is a typo and should be the single line: ``` StringWriter buf = new StringWriter(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org