epugh commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2151922917
Seems a shame to add a to. Of suppress for locale and then remove it...
might be cleaner to do that one as part of the upgrade.
--
This is an automated message from the Apache Git Service.
epugh commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2151924913
As far as security manager goes, don't we need to just tackle that and solve
the issue? Versus suppress it and ignore the problem?
--
This is an automated message from the Apache Git Serv
gerlowskija commented on PR #2500:
URL: https://github.com/apache/solr/pull/2500#issuecomment-2152298377
As I see this PR, it's a pretty minor change - it's "just" removing some
stale, unnecessary docs.
But if you'd prefer the removal be documented, I'm happy to add a notice
somewher
iamsanjay commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2152315575
> As far as security manager goes, don't we need to just tackle that and
solve the issue? Versus suppress it and ignore the problem?
Removing a SecurityManager will not be a simple t
epugh commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2152328714
> > As far as security manager goes, don't we need to just tackle that and
solve the issue? Versus suppress it and ignore the problem?
>
> Removing a SecurityManager will not be a simple
epugh commented on PR #2500:
URL: https://github.com/apache/solr/pull/2500#issuecomment-2152347636
So the code change, i.e removing docs, no big deal. However, IF you are a
long time user of Solr, you may have used the tool in the past, and then go
look for it, thinking "Oh, it's time to u
iamsanjay commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2152358696
Actually I started looking into it, the first issue that I found was "XXE
attack in SolrConfig.xml" and a proposed fix
(https://issues.apache.org/jira/browse/SOLR-12316). Afterwards the mo
epugh merged PR #2471:
URL: https://github.com/apache/solr/pull/2471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852770#comment-17852770
]
ASF subversion and git services commented on SOLR-17304:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-17304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852773#comment-17852773
]
ASF subversion and git services commented on SOLR-17304:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-17304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17304.
--
Fix Version/s: 9.7
Resolution: Fixed
Thank you!
> PKG_VERSIONS not honored when loading the sch
[
https://issues.apache.org/jira/browse/SOLR-17304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-17304:
Assignee: Eric Pugh
> PKG_VERSIONS not honored when loading the schema plugins
> -
gerlowskija opened a new pull request, #2502:
URL: https://github.com/apache/solr/pull/2502
This commit fixes a problem in the Solr build whereby files generated from
our OpenAPI spec could "leak" between branches and cause compilation issues.
In short, generated SolrRequest implement
epugh merged PR #2485:
URL: https://github.com/apache/solr/pull/2485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852784#comment-17852784
]
ASF subversion and git services commented on SOLR-17313:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-17315:
Assignee: Eric Pugh
> Bug in messaging when creating a collection, and then you can't actually cal
[
https://issues.apache.org/jira/browse/SOLR-17313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17313.
--
Fix Version/s: main (10.0)
Resolution: Fixed
> Remove Deprecated SolrLogPostTool
> -
sigram commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2152663345
This only checks for the timeAllowed limit but the concept of query limits
has been extended in SOLR-17138. Also, there's another Jira ticket with a
similar scope: https://issues.apache.org/j
gerlowskija commented on PR #2500:
URL: https://github.com/apache/solr/pull/2500#issuecomment-2152794789
I think you're right that we should give confused users who might remember
the docs _some_ signpost, but I opted to not to do that in "Major Changes"
Largely because nothing has ch
gus-asf commented on PR #2500:
URL: https://github.com/apache/solr/pull/2500#issuecomment-2152829875
This seems fine, though maybe adding something explaining why we removed it
like:
"The references to this tool were removed because in the vast majority of
cases it is better to re-i
dsmiley commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1629870347
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -557,7 +558,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse r
dsmiley commented on code in PR #2485:
URL: https://github.com/apache/solr/pull/2485#discussion_r1629874818
##
solr/CHANGES.txt:
##
@@ -67,6 +67,8 @@ Deprecation Removals
* SOLR-17284: Remove deprecated BlobRepository in favour of FileStore. (Eric
Pugh)
+* SOLR-17313: Remo
dsmiley commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2152979111
Can we please keep the commentary here focused on what this PR title says
this is about -- URL API?
--
This is an automated message from the Apache Git Service.
To respond to the message,
dsmiley commented on PR #2498:
URL: https://github.com/apache/solr/pull/2498#issuecomment-2153002420
Before this change here, isn't there some existing build image for Solr you
@uvatbc worked on ?
@iamsanjay assuming the build starts running on JDK 21 (wherever -- CI /
Crave / dev ma
dsmiley commented on code in PR #2499:
URL: https://github.com/apache/solr/pull/2499#discussion_r1629916574
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -103,6 +103,8 @@ public class SolrConfig implements MapSerializable {
private static final Logger log
dsmiley commented on PR #2499:
URL: https://github.com/apache/solr/pull/2499#issuecomment-2153021328
I wish we brainstormed this a bit on the dev list or something prior to you
showing up with a PR where there is maybe inertia to continue with it the way
it is
--
This is an automated mes
epugh commented on code in PR #2485:
URL: https://github.com/apache/solr/pull/2485#discussion_r1629948455
##
solr/CHANGES.txt:
##
@@ -67,6 +67,8 @@ Deprecation Removals
* SOLR-17284: Remove deprecated BlobRepository in favour of FileStore. (Eric
Pugh)
+* SOLR-17313: Remove
gerlowskija merged PR #2496:
URL: https://github.com/apache/solr/pull/2496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852881#comment-17852881
]
ASF subversion and git services commented on SOLR-17317:
Commit a
dsmiley commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1629951486
##
solr/core/src/java/org/apache/solr/request/json/RequestUtil.java:
##
@@ -241,13 +243,16 @@ public static void processParams(
if (queriesJsonObj instanceof Ma
[
https://issues.apache.org/jira/browse/SOLR-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852893#comment-17852893
]
ASF subversion and git services commented on SOLR-17317:
Commit 7
magibney commented on code in PR #2491:
URL: https://github.com/apache/solr/pull/2491#discussion_r1629991095
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##
@@ -81,31 +77,15 @@ public void init(PluginInfo info) {
log.info("Initializing HdfsU
[
https://issues.apache.org/jira/browse/SOLR-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17317.
Fix Version/s: main (10.0)
9.7
Resolution: Fixed
> JAX-RS v2 APIs
janhoy opened a new pull request, #2503:
URL: https://github.com/apache/solr/pull/2503
POC, just a test to prove that balance does not even out duplicate replicas
on node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
alessandrobenedetti commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2153161526
> I haven't looked at this in detail but I'm wondering could we instead have
a single 'q' query parser, that is itself a "query combiner" of its children
clauses? Ultimately this
HoustonPutman commented on PR #2502:
URL: https://github.com/apache/solr/pull/2502#issuecomment-2153182212
This looks good to me.
It will be even better when
https://github.com/OpenAPITools/openapi-generator/issues/17380 is fixed, which
will stop the task from running as often as it
dsmiley commented on code in PR #1895:
URL: https://github.com/apache/solr/pull/1895#discussion_r1630041496
##
solr/core/src/test/org/apache/solr/update/CustomTLogDirTest.java:
##
@@ -36,8 +36,15 @@ public class CustomTLogDirTest extends SolrTestCaseJ4 {
new EmbeddedSolrS
dsmiley closed pull request #2491: Refactor duplication in UpdateLog.init
URL: https://github.com/apache/solr/pull/2491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
dsmiley commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2153266206
Want to quickly respond to this:
> a Lucene contribution to create a new query
No! The Lucene project is not the only place where subclasses of Query
classes exist ;-)
I'm l
alessandrobenedetti commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2153348715
> I should have spent just another 10 minutes reading this to understand
what's going on; I understand it better now. I had overlooked the query loop. I
don't think a new Query w
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1630193292
##
solr/core/src/test/org/apache/solr/handler/component/DebugComponentTest.java:
##
@@ -52,7 +64,7 @@ public void testBasicInterface() {
"//str[@name=
magibney commented on PR #1895:
URL: https://github.com/apache/solr/pull/1895#issuecomment-2153378871
Thanks, yes I will definitely keep an eye on the builds.
I'll wait a few days -- @markrmiller if you're able to weigh in that would
be much appreciated!
I do have a specific qu
dsmiley commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1630219623
##
solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Stephen Woods created SOLR-17322:
Summary: Make RankQuery.getTopDocsCollector use covariant generic
types
Key: SOLR-17322
URL: https://issues.apache.org/jira/browse/SOLR-17322
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Woods updated SOLR-17322:
-
Description:
Currently, rank queries can only use TopDocsCollectors that operate on
ScoreDocs.
Michael Gibney created SOLR-17323:
-
Summary: Fix potential ConcurrentModificationException on
CachingDirectoryFactory.close()
Key: SOLR-17323
URL: https://issues.apache.org/jira/browse/SOLR-17323
Proj
magibney opened a new pull request, #2505:
URL: https://github.com/apache/solr/pull/2505
https://issues.apache.org/jira/browse/SOLR-17323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
magibney commented on PR #1895:
URL: https://github.com/apache/solr/pull/1895#issuecomment-2153774410
The build failure for 962b99f430c56f7387fbf233950fbc12946aaa70 is legit, but
not related to this PR. I've opened an
[issue](https://issues.apache.org/jira/browse/SOLR-17323)/[PR](https://gi
stephen-woods opened a new pull request, #2506:
URL: https://github.com/apache/solr/pull/2506
https://issues.apache.org/jira/browse/SOLR-17322
# Description
Updates `RankQuery` so that the `TopDocsCollector` it returns is properly
covariant instead of invariant. Th
stephen-woods commented on PR #2506:
URL: https://github.com/apache/solr/pull/2506#issuecomment-2153796784
If this gets accepted, I'd like to back port it to 9.X branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/SOLR-17322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Woods updated SOLR-17322:
-
Status: Patch Available (was: Open)
> Make RankQuery.getTopDocsCollector use covariant generic t
51 matches
Mail list logo
