iamsanjay commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-2088106960
Build failed due to one of the flaky test cases as test passing when ran
again.
> gradlew :solr:core:test --tests
"org.apache.solr.search.TestCoordinatorRole.testNRTRestart" -Ptests
Jason Gerlowski created SOLR-17264:
--
Summary: Reproducible Seed for OverseerStatusTest Failure
Key: SOLR-17264
URL: https://issues.apache.org/jira/browse/SOLR-17264
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-17264:
---
Description:
OverseerStatusTest has been failing in about 8% of runs since mid February 2024.
gerlowskija commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2088376107
+1 I spent a bunch of time on this this morning after running into
OverseerStatusTest failures on main, before stumbling on this discussion. Any
chance you're able to investigate furthe
Gus Heck created SOLR-17265:
---
Summary: Reproducing Failure: OverseerStatusTest after commit
9c9250c6
Key: SOLR-17265
URL: https://issues.apache.org/jira/browse/SOLR-17265
Project: Solr
Issue Type:
gus-asf commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2088385840
Neither this PR nor the commit mention a jira so I'll drop this here:
https://issues.apache.org/jira/browse/SOLR-17265
--
This is an automated message from the Apache Git Service.
To respo
gus-asf commented on code in PR #2415:
URL: https://github.com/apache/solr/pull/2415#discussion_r1586242677
##
dev-docs/releasing.adoc:
##
@@ -0,0 +1,73 @@
+
+= Releasing Solr
+:toc: left
+
+== Motivated?
+So you're of the opinion that there are unreleased features or bugfixes
gus-asf commented on code in PR #2415:
URL: https://github.com/apache/solr/pull/2415#discussion_r1586246848
##
dev-docs/releasing.adoc:
##
@@ -0,0 +1,73 @@
+
+= Releasing Solr
+:toc: left
+
+== Motivated?
+So you're of the opinion that there are unreleased features or bugfixes
dsmiley commented on PR #2076:
URL: https://github.com/apache/solr/pull/2076#issuecomment-2088515065
Just a little reminder... when squash-merging, remember to edit the commit
message so it's cleaned up to reflect the final result in totality; it's almost
always necessary. Should not refer
justinrsweeney commented on PR #2076:
URL: https://github.com/apache/solr/pull/2076#issuecomment-2088534839
Thanks for the reminder, will make sure next time!
On Wed, May 1, 2024 at 10:06 AM David Smiley ***@***.***>
wrote:
> Just a little reminder... when squash-merging, rem
jdyer1 opened a new pull request, #2435:
URL: https://github.com/apache/solr/pull/2435
This is a follow up to [PR ](https://github.com/apache/solr/pull/2433).
Using @andywebb1975 fix for `HttpJdkSolrClient` this adds a unit test,
adding `fq="{!terms f=myfield}value1,value2` to both
[
https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842689#comment-17842689
]
James Dyer commented on SOLR-17263:
---
[~andywebb1975] Thank you for being an early adop
cpoerschke commented on PR #2382:
URL: https://github.com/apache/solr/pull/2382#issuecomment-2088667529
Thanks for the notes above, they helped me continue browsing the code to see
how the `Presearcher` fits in and how the various objects are currently put
together.
So with indexing
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842698#comment-17842698
]
Jason Gerlowski commented on SOLR-17160:
bq. 100 is clearly way too low.
+1...to
[
https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842725#comment-17842725
]
Andy Webb commented on SOLR-17263:
--
Thanks James, and no worries!
I want to understand
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842732#comment-17842732
]
David Smiley commented on SOLR-17160:
-
BTW I think Denial of Service should be a non-
laminelam commented on PR #2417:
URL: https://github.com/apache/solr/pull/2417#issuecomment-2088871902
> @laminelam I'm following up my response last night. What do you think
about removing the class loader stuff from this PR and just getting the
refactor in, and then having a seperate PR t
HoustonPutman commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2088918365
Ok created a PR to fix this, I'm not sure what the logic here was supposed
to be, but I've changed PRS to be a much more normal per-test-class randomized
option.
--
This is an autom
HoustonPutman opened a new pull request, #2436:
URL: https://github.com/apache/solr/pull/2436
https://issues.apache.org/jira/browse/SOLR-17265
This fixes the test errors introduced by
https://github.com/apache/solr/pull/2230
I'm not really certain what the previous logic was su
dsmiley commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586652988
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -83,7 +83,7 @@ public class SolrCloudTestCase extends SolrTestCaseJ4 {
private sta
dsmiley merged PR #2422:
URL: https://github.com/apache/solr/pull/2422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
HoustonPutman commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586713299
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -140,29 +138,18 @@ public static void shutdownCluster() throws Exception {
@Be
dsmiley commented on code in PR #2432:
URL: https://github.com/apache/solr/pull/2432#discussion_r1586719024
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -181,29 +183,46 @@ public String getShardId(String nodeName, String
coreName) {
}
pub
dsmiley merged PR #2420:
URL: https://github.com/apache/solr/pull/2420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-2089008592
I looked at the [test
history](https://ge.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=solr-root&search.timeZoneId=America%2FNew_York&tests.container=org.apach
HoustonPutman commented on PR #2420:
URL: https://github.com/apache/solr/pull/2420#issuecomment-2089068594
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
HoustonPutman commented on code in PR #2432:
URL: https://github.com/apache/solr/pull/2432#discussion_r1586783103
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -181,29 +183,46 @@ public String getShardId(String nodeName, String
coreName) {
}
dsmiley commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586786180
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -140,28 +143,29 @@ public static void shutdownCluster() throws Exception {
@BeforeCl
dsmiley commented on code in PR #2432:
URL: https://github.com/apache/solr/pull/2432#discussion_r1586807196
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -181,29 +183,46 @@ public String getShardId(String nodeName, String
coreName) {
}
pub
dsmiley commented on code in PR #2432:
URL: https://github.com/apache/solr/pull/2432#discussion_r158684
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -2849,9 +2834,14 @@ public boolean
checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {
* Bes
[
https://issues.apache.org/jira/browse/SOLR-17266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842779#comment-17842779
]
Gus Heck commented on SOLR-17266:
-
The ultimate way to improve this (ignoring effort mome
HoustonPutman commented on PR #2436:
URL: https://github.com/apache/solr/pull/2436#issuecomment-2089162157
Thanks for the info on those. I've standardized both the reseting of
sysProps as well as where the option is set from.
--
This is an automated message from the Apache Git Service.
To
dsmiley commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1586827784
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation
HoustonPutman commented on PR #2431:
URL: https://github.com/apache/solr/pull/2431#issuecomment-2089193456
I've simplified the logic, definitely went overboard on the first attempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
dsmiley commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586911809
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java:
##
@@ -56,6 +58,10 @@ public abstract class AbstractBasicDistributedZk2Test
dsmiley commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586911809
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java:
##
@@ -56,6 +58,10 @@ public abstract class AbstractBasicDistributedZk2Test
github-actions[bot] commented on PR #1155:
URL: https://github.com/apache/solr/pull/1155#issuecomment-2089311201
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
[
https://issues.apache.org/jira/browse/SOLR-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842810#comment-17842810
]
Houston Putman edited comment on SOLR-17088 at 5/2/24 12:50 AM:
---
kotman12 commented on PR #2382:
URL: https://github.com/apache/solr/pull/2382#issuecomment-2089353858
> Ease of configuration might be a reason? Or could one imagine a scenario
where indexing and searching wish to use different presearcher types or
settings?
I think it would be diffi
HoustonPutman merged PR #2431:
URL: https://github.com/apache/solr/pull/2431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
[
https://issues.apache.org/jira/browse/SOLR-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842812#comment-17842812
]
ASF subversion and git services commented on SOLR-17261:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842813#comment-17842813
]
ASF subversion and git services commented on SOLR-17261:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-17261.
---
Fix Version/s: 9.6.1
9.7
Resolution: Fixed
> Core loading is capped
[
https://issues.apache.org/jira/browse/SOLR-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842815#comment-17842815
]
ASF subversion and git services commented on SOLR-17261:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842821#comment-17842821
]
David Smiley commented on SOLR-17088:
-
Wow; you deserve an award of some kind for roo
[
https://issues.apache.org/jira/browse/SOLR-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul reassigned SOLR-17264:
-
Assignee: Noble Paul
> Reproducible Seed for OverseerStatusTest Failure
> --
[
https://issues.apache.org/jira/browse/SOLR-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842852#comment-17842852
]
Jan Høydahl commented on SOLR-17088:
Ouch. Many tests relied on solr.xml in ZK, but I
47 matches
Mail list logo