dsmiley commented on code in PR #2432:
URL: https://github.com/apache/solr/pull/2432#discussion_r1586811114
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2849,9 +2834,14 @@ public boolean
checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {
* Best effort to set DOWN state for all replicas on node.
*
* @param nodeName to operate on
+ * @return the names of the collections that have replicas on the given node
*/
- public void publishNodeAsDown(String nodeName) {
+ public Collection<String> publishNodeAsDown(String nodeName) {
log.info("Publish node={} as DOWN", nodeName);
+
+ ClusterState clusterState = cc.getZkController().getClusterState();
+ Map<String, List<Replica>> replicasPerCollectionOnNode =
+ clusterState.getReplicaNamesPerCollectionOnNode(nodeName);
Review Comment:
Fair point. I wish the replica's state, in PRS, was an ephemeral node, and
then this would be a non-issue. No need to mark anything down, ZK does it for
you :-). @murblanc often speaks of wishing for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
