dsmiley commented on code in PR #2436: URL: https://github.com/apache/solr/pull/2436#discussion_r1586911809
########## solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java: ########## @@ -56,6 +58,10 @@ public abstract class AbstractBasicDistributedZk2TestBase extends AbstractFullDi private static final String ONE_NODE_COLLECTION = "onenodecollection"; private final boolean onlyLeaderIndexes = random().nextBoolean(); + @ClassRule + public static TestRule syspropRestore = + new TestRuleRestoreSystemProperties(NUMERIC_DOCVALUES_SYSPROP, PRS_DEFAULT_PROP); Review Comment: AFAIK, this shouldn't be necessary because SolrTestCase (root of all Solr tests) already declares SystemPropertiesRestoreRule as a ClassRule and also STCJ4 has a test rule for this as well for test/method level restoration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
