Re: [PR] SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API [solr]

2024-01-31 Thread via GitHub
cpoerschke commented on code in PR #1557: URL: https://github.com/apache/solr/pull/1557#discussion_r1472570357 ## solr/core/src/java/org/apache/solr/handler/component/TermVectorComponent.java: ## @@ -251,6 +252,7 @@ public void process(ResponseBuilder rb) throws IOException {

Re: [PR] NO JIRA: termVectors[NL] local variable rename in TermVectorComponent.process [solr]

2024-01-31 Thread via GitHub
cpoerschke merged PR #2234: URL: https://github.com/apache/solr/pull/2234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] SOLR-10808: SchemaVersion 1.7 - DocValues default to true [solr]

2024-01-31 Thread via GitHub
anukanksha13 commented on code in PR #2017: URL: https://github.com/apache/solr/pull/2017#discussion_r1472678773 ## solr/solr-ref-guide/modules/indexing-guide/pages/docvalues.adoc: ## @@ -116,3 +119,13 @@ When retrieving stored fields, the insertion order is the return order.

Re: [PR] SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API [solr]

2024-01-31 Thread via GitHub
cpoerschke commented on code in PR #1557: URL: https://github.com/apache/solr/pull/1557#discussion_r1472683092 ## solr/modules/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java: ## @@ -166,18 +167,23 @@ public FeatureScorer scorer(LeafReaderContext context) throws

Re: [PR] SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API [solr]

2024-01-31 Thread via GitHub
cpoerschke commented on code in PR #1557: URL: https://github.com/apache/solr/pull/1557#discussion_r1472685565 ## solr/core/src/java/org/apache/solr/handler/component/TermVectorComponent.java: ## @@ -251,6 +252,7 @@ public void process(ResponseBuilder rb) throws IOException {

Re: [PR] SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API [solr]

2024-01-31 Thread via GitHub
cpoerschke commented on code in PR #1557: URL: https://github.com/apache/solr/pull/1557#discussion_r1472687694 ## solr/core/src/java/org/apache/solr/handler/admin/IndexSizeEstimator.java: ## @@ -384,16 +386,17 @@ private void estimateTermVectors(Map result) throws IOException

Re: [PR] SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API [solr]

2024-01-31 Thread via GitHub
cpoerschke commented on code in PR #1557: URL: https://github.com/apache/solr/pull/1557#discussion_r1472699171 ## solr/core/src/java/org/apache/solr/handler/admin/LukeRequestHandler.java: ## @@ -316,6 +318,7 @@ private static SimpleOrderedMap getDocumentFieldsInfo( Docum

[I] Shards in a down state after an HPA scale up / scale down event. [solr-operator]

2024-01-31 Thread via GitHub
aloosnetmatch opened a new issue, #682: URL: https://github.com/apache/solr-operator/issues/682 I installed the solr operator 0.8.0 with solr image 9.4.1 on AKS. Using a a guideline this video : [Rethinking Autoscaling for Apache Solr using Kubernetes - Berlin Buzzwords 2023](https://you

Re: [PR] SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API [solr]

2024-01-31 Thread via GitHub
cpoerschke commented on code in PR #1557: URL: https://github.com/apache/solr/pull/1557#discussion_r147289 ## solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java: ## @@ -570,7 +571,8 @@ protected void flatten( fieldHighlights = doHighli

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-31 Thread via GitHub
iamsanjay commented on PR #2144: URL: https://github.com/apache/solr/pull/2144#issuecomment-1919083424 > @iamsanjay - I would love to see this make it into 9.5, so I took the liberty of making a few of the changes that were outstanding from above. Namely: Thank you so much! Moving on

[PR] Solr 16391: Tweak v2 'CREATECORE' API to be more REST-ful [solr]

2024-01-31 Thread via GitHub
iamsanjay opened a new pull request, #2235: URL: https://github.com/apache/solr/pull/2235 https://issues.apache.org/jira/browse/SOLR-16391 # Description V2(JAX-RS) Endpoints for core admin op "create" core. # Solution Updated the core creation endpoint

Re: [PR] Solr 16391: Tweak v2 'CREATECORE' API to be more REST-ful [solr]

2024-01-31 Thread via GitHub
epugh commented on PR #2235: URL: https://github.com/apache/solr/pull/2235#issuecomment-1919437864 NOt a comment per se on this PR, but more for my own education. In the `CreateTool` we use `CoreAdminRequest.createCore`.If we wanted to take advantage of this PR, would we replace `Core

[jira] [Created] (SOLR-17144) Each unused core has a dormant but active thread

2024-01-31 Thread Pierre Salagnac (Jira)
Pierre Salagnac created SOLR-17144: -- Summary: Each unused core has a dormant but active thread Key: SOLR-17144 URL: https://issues.apache.org/jira/browse/SOLR-17144 Project: Solr Issue Type:

[PR] SOLR-17144: Do not keep an active thread per core [solr]

2024-01-31 Thread via GitHub
psalagnac opened a new pull request, #2236: URL: https://github.com/apache/solr/pull/2236 https://issues.apache.org/jira/browse/SOLR-17144 # Description Each core in Solr spawns a thread when the core is opened. If we have thousands of unused cores, it means we have

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

2024-01-31 Thread via GitHub
risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1919850528 I pushed 80f11d5 which has a benchmark for checking a bunch of this. I haven't compared against main yet, but on my machine: ``` Benchmark (flScore) (matchAllDocs)

Re: [I] SolrCloud Pod moved to new Node - Replica Migration pending [solr-operator]

2024-01-31 Thread via GitHub
brickpattern commented on issue #668: URL: https://github.com/apache/solr-operator/issues/668#issuecomment-1920076595 yes, PVs are setup correctly. Solr PODS come up correctly either by evicting or restarting. The specific scenario I'm certifying is EKS node taint n drain ( replace

[PR] SOLR-17140 - provide extensible query limit concept. [solr]

2024-01-31 Thread via GitHub
gus-asf opened a new pull request, #2237: URL: https://github.com/apache/solr/pull/2237 https://issues.apache.org/jira/browse/SOLR-17140 This replaces SolrQueryTimeoutImpl.java with a much simpler SolrTimeLimit and provides a QueryLimits class to allow addition of additional types of

[jira] [Commented] (SOLR-17140) Refactor SolrQueryTimeoutImpl to support other implementations

2024-01-31 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813002#comment-17813002 ] Gus Heck commented on SOLR-17140: - PR is first cut at this point. It passes all tests, bu

[jira] [Updated] (SOLR-17140) Refactor SolrQueryTimeoutImpl to support other implementations

2024-01-31 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17140: Description: The current way we model time limits for timeAllowed involves a lot of static methods and thre

Re: [PR] SOLR-16699: Expose creationTimeMillis in COLSTATUS API [solr]

2024-01-31 Thread via GitHub
dsmiley commented on code in PR #2226: URL: https://github.com/apache/solr/pull/2226#discussion_r1473744576 ## solr/CHANGES.txt: ## @@ -86,6 +86,8 @@ Improvements * SOLR-17119: When registering or updating a ConfigurablePlugin through the `/cluster/plugin` API, config valid

Re: [PR] SOLR-16699: Expose creationTimeMillis in COLSTATUS API [solr]

2024-01-31 Thread via GitHub
dsmiley merged PR #2226: URL: https://github.com/apache/solr/pull/2226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16699) Expose collection creation time from COLSTATUS API

2024-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813023#comment-17813023 ] ASF subversion and git services commented on SOLR-16699: Commit 6

[jira] [Commented] (SOLR-16699) Expose collection creation time from COLSTATUS API

2024-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813035#comment-17813035 ] ASF subversion and git services commented on SOLR-16699: Commit 0

Re: [PR] SOLR-17038: /admin/segments handler: Expose the term count [solr]

2024-01-31 Thread via GitHub
rahulgoswami closed pull request #2233: SOLR-17038: /admin/segments handler: Expose the term count URL: https://github.com/apache/solr/pull/2233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] SOLR-17038: /admin/segments handler: Expose the term count [solr]

2024-01-31 Thread via GitHub
rahulgoswami commented on PR #2233: URL: https://github.com/apache/solr/pull/2233#issuecomment-1920583550 Incorporated review comments by @cpoerschke : 1) Added back jakarta.inject-2.6.1.jar.sha1 removed while running ./gradlew tidy updateLicenses check -x test 2) Added tests for new a

[jira] [Commented] (SOLR-16879) Throttle concurrent backups/restores per node

2024-01-31 Thread Alexey Serba (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813066#comment-17813066 ] Alexey Serba commented on SOLR-16879: - I think this feature introduced a regression t