cpoerschke commented on code in PR #1557:
URL: https://github.com/apache/solr/pull/1557#discussion_r1472777789
##########
solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java:
##########
@@ -570,7 +571,8 @@ protected void flatten(
fieldHighlights =
doHighlightingByFastVectorHighlighter(doc, docId, schemaField,
fvhContainer, reader, req);
} else { // standard/default highlighter
- fieldHighlights = doHighlightingByHighlighter(doc, docId, schemaField,
query, reader, req);
+ fieldHighlights =
+ doHighlightingByHighlighter(doc, docId, schemaField, query,
reader.termVectors(), req);
Review Comment:
https://github.com/apache/solr/pull/1557/commits/78351f102aa787e779922a3b613cf653e673d97e
added to use a supplier, though not `Supplier<TermVectors>` so that the
`get()` can still throw `IOException` - WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
