[PR] Update README.md [solr]

whoami-anoint opened a new pull request, #2228: URL: https://github.com/apache/solr/pull/2228 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Commented] (SOLR-17132) LTR model upload API issue

[ https://issues.apache.org/jira/browse/SOLR-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811830#comment-17811830 ] Noble Paul commented on SOLR-17132: --- [~rajanimaski] yes. it can be used . Is there anyt

[jira] [Created] (SOLR-17133) CloudAuthStreamTest fails with PRS=true

Noble Paul created SOLR-17133: - Summary: CloudAuthStreamTest fails with PRS=true Key: SOLR-17133 URL: https://issues.apache.org/jira/browse/SOLR-17133 Project: Solr Issue Type: Task Securit

[jira] [Updated] (SOLR-17133) CloudAuthStreamTest fails with PRS=true

[ https://issues.apache.org/jira/browse/SOLR-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-17133: -- Issue Type: Bug (was: Task) > CloudAuthStreamTest fails with PRS=true > --

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914730907 > The other code path is actually already optimized for rows==0 and no scores Which code path are you talking about? > I think the solution is to not save the results into queryR

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914809682 > (Me) The other code path is actually already optimized for rows==0 and no scores The method you are attempting to modify calls `getDocListAndSetNC` when `useFilterCache=false`, whic

Re: [PR] Update README.md [solr]

epugh closed pull request #2228: Update README.md URL: https://github.com/apache/solr/pull/2228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

Re: [PR] Update README.md [solr]

epugh commented on PR #2228: URL: https://github.com/apache/solr/pull/2228#issuecomment-1914812076 While I love the sentiment, I think we would need some data to back up the statement "most popular" ;-). However, please tag me with any other doc improvements! -- This is an automated me

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.2 [solr]

NazerkeBS commented on PR #2176: URL: https://github.com/apache/solr/pull/2176#issuecomment-1914814723 all tests passed locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914878120 I made a slight change to improve the variable name I added - c6618d6 > The method you are attempting to modify calls getDocListAndSetNC when useFilterCache=false, which is well optimi

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914900925 > is that queryResultWindowSize should be ignored when rows=0 to allow us to run this query as fast as possible, even if this means not caching queryResultWindowSize docs -- because we'd ra

[jira] [Commented] (SOLR-17132) LTR model upload API issue

[ https://issues.apache.org/jira/browse/SOLR-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811936#comment-17811936 ] rajanimaski commented on SOLR-17132: Hi Noble,  Collection reload replays warming que

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914939631 I addressed the queryResultWindowSize with 326afdd when rows=0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914960070 You claim that your approach to this uses the filter cache (for `q`). Yet it does not because it calls `getDocSetNC`. I feel compelled to -1 this because that's what `useFilterCache` means

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914972100 > You claim that your approach to this uses the filter cache (for q) With my change, for the case of `rows=0`, the filtercache docset will be used to compute the result using q.

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

dsmiley commented on code in PR #2221: URL: https://github.com/apache/solr/pull/2221#discussion_r1469804423 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1818,7 +1820,7 @@ private void getDocListNC(QueryResult qr, QueryCommand cmd) throws IOExcepti

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

risdenk commented on code in PR #2221: URL: https://github.com/apache/solr/pull/2221#discussion_r1469808152 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1818,7 +1820,7 @@ private void getDocListNC(QueryResult qr, QueryCommand cmd) throws IOExcepti

[PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

gerlowskija opened a new pull request, #2229: URL: https://github.com/apache/solr/pull/2229 https://issues.apache.org/jira/browse/SOLR-17066 # Description SOLR-17066 added a 'defaultCollection' field to each SolrClient implementation, similar to the one that has long been in us

Re: [PR] SOLR-15781: Document v2 API syntax conventions [solr]

gerlowskija commented on code in PR #2219: URL: https://github.com/apache/solr/pull/2219#discussion_r1469894384 ## dev-docs/v2-api-conventions.adoc: ## @@ -0,0 +1,76 @@ +== HTTP Paths + +Where possible, each v2 API is given an HTTP path that reflects the resource type and/or na

Re: [PR] SOLR-15781: Document v2 API syntax conventions [solr]

gerlowskija commented on code in PR #2219: URL: https://github.com/apache/solr/pull/2219#discussion_r1469903877 ## dev-docs/apis.adoc: ## @@ -51,27 +51,28 @@ Separating the API "definition" and "implementation" in this way allows us to on Writing a new v2 API may appear daun

Re: [PR] SOLR-15781: Document v2 API syntax conventions [solr]

gerlowskija commented on code in PR #2219: URL: https://github.com/apache/solr/pull/2219#discussion_r1469907912 ## dev-docs/apis.adoc: ## @@ -51,27 +51,28 @@ Separating the API "definition" and "implementation" in this way allows us to on Writing a new v2 API may appear daun

Re: [PR] SOLR-15781: Document v2 API syntax conventions [solr]

gerlowskija merged PR #2219: URL: https://github.com/apache/solr/pull/2219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-15781) Make v2 APIs more REST-ful and migrate to JAX-RS

[ https://issues.apache.org/jira/browse/SOLR-15781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811987#comment-17811987 ] ASF subversion and git services commented on SOLR-15781: Commit 0

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1915205945 Let's use GH links to ensure we understand each other. You are referring to [this](https://github.com/apache/solr/blob/e53bf109ba2d35e1aff6f9a5c428fff5eff63f7b/solr/core/src/java/org/apache/

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

uschindler commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1915232387 Hi, I already responded on Slack, but I now found this PR and wanted to say some additional things: There is also a separate collector and on top of that a separate method in `I

Re: [PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

epugh commented on code in PR #2229: URL: https://github.com/apache/solr/pull/2229#discussion_r1469954419 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -237,8 +237,10 @@ public Map getPackagesDeployed(String collection) { NamedList resul

[jira] [Created] (SOLR-17134) Bucketed rate limiting

Noble Paul created SOLR-17134: - Summary: Bucketed rate limiting Key: SOLR-17134 URL: https://issues.apache.org/jira/browse/SOLR-17134 Project: Solr Issue Type: Improvement Security Level: P

[jira] [Created] (SOLR-17135) Default PRS at System level as opt in

Noble Paul created SOLR-17135: - Summary: Default PRS at System level as opt in Key: SOLR-17135 URL: https://issues.apache.org/jira/browse/SOLR-17135 Project: Solr Issue Type: Improvement Se

[PR] Use a System wide property to enable PRS. the testcase can piggyback … [solr]

noblepaul opened a new pull request, #2230: URL: https://github.com/apache/solr/pull/2230 WIP do not merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1915447012 @uschindler See [getDocListNC](https://github.com/apache/solr/blob/326afddeddaa2092086e6f6b27f8bc35bf6d79cf/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L1812) which alre

Re: [PR] SOLR-17068: Resolve mish mash of bin/post and bin/solr post references in favour of bin/solr post. [solr]

epugh commented on PR #2227: URL: https://github.com/apache/solr/pull/2227#issuecomment-1915578292 Just tested that `bin/post` still works! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1915662767 Updated this based on talking w/ @dsmiley. the `useFilterCache` part I was confused on that it always applies to `q` so my change didn't make sense. I pushed a change that made it clear what

Re: [I] SolrCloud Pod moved to new Node - Replica Migration pending [solr-operator]

HoustonPutman commented on issue #668: URL: https://github.com/apache/solr-operator/issues/668#issuecomment-1915739941 The only ways that local volumes work as PVs is if the PVs that are created have node limitations (i.e. the Pod connected to the PV cannot be rescheduled onto another node)

Re: [PR] SOLR-16699: Expose creationTimeMillis in COLSTATUS API [solr]

dsmiley commented on code in PR #2226: URL: https://github.com/apache/solr/pull/2226#discussion_r1470367294 ## solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java: ## @@ -133,9 +134,18 @@ public ZkWriteCommand createCollection(ClusterState clusterState, Z

Re: [PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

gerlowskija commented on PR #2229: URL: https://github.com/apache/solr/pull/2229#issuecomment-1915912304 > What jumped out at me is that we really abuse `GenericSolrRequest` all over the place. I also am hoping that as more of the V2 api's come online, we could reduce the places that we use

Re: [PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

epugh commented on PR #2229: URL: https://github.com/apache/solr/pull/2229#issuecomment-1915917826 > > What jumped out at me is that we really abuse `GenericSolrRequest` all over the place. I also am hoping that as more of the V2 api's come online, we could reduce the places that we use `Ge

Re: [PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

gerlowskija commented on code in PR #2229: URL: https://github.com/apache/solr/pull/2229#discussion_r1470500298 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -237,8 +237,10 @@ public Map getPackagesDeployed(String collection) { NamedList

Re: [PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

gerlowskija commented on code in PR #2229: URL: https://github.com/apache/solr/pull/2229#discussion_r1470501485 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java: ## @@ -1013,7 +1013,8 @@ public void testGetRawStream() throws Exception {

Re: [PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

gerlowskija commented on code in PR #2229: URL: https://github.com/apache/solr/pull/2229#discussion_r1470505104 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java: ## @@ -1013,7 +1013,8 @@ public void testGetRawStream() throws Exception {

Re: [PR] SOLR-17068: Resolve mish mash of bin/post and bin/solr post references in favour of bin/solr post. [solr]

dsmiley commented on PR #2227: URL: https://github.com/apache/solr/pull/2227#issuecomment-1915947350 Maybe I'm being grumpy but I like to think of the unfortunate addition of "post" to bin/solr as an implementation detail out of convenience to make multi-platform and general supportability

Re: [PR] SOLR-17130: edismax-matchalldocs-optimization [solr]

dsmiley commented on code in PR #2218: URL: https://github.com/apache/solr/pull/2218#discussion_r1470516795 ## solr/core/src/java/org/apache/solr/search/ExtendedDismaxQParser.java: ## @@ -199,6 +199,18 @@ public Query parse() throws SyntaxError { topQuery = FunctionScoreQ

Re: [PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

gerlowskija commented on code in PR #2229: URL: https://github.com/apache/solr/pull/2229#discussion_r1470520449 ## solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java: ## @@ -155,9 +155,12 @@ public static String getFileFromJarsAsString(List jars, String filenam

Re: [PR] SOLR-17066: Add GenericSolrRequest.setRequiresCollection [solr]

gerlowskija commented on code in PR #2229: URL: https://github.com/apache/solr/pull/2229#discussion_r1470505104 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java: ## @@ -1013,7 +1013,8 @@ public void testGetRawStream() throws Exception {

[PR] SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 2 [solr]

gerlowskija opened a new pull request, #2231: URL: https://github.com/apache/solr/pull/2231 https://issues.apache.org/jira/browse/SOLR-17066 # Description SOLR-17066 introduced a `withDefaultCollection` builder method that can be used in lieu of providing a core URL as a "base"

Re: [PR] SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 2 [solr]

gerlowskija commented on PR #2231: URL: https://github.com/apache/solr/pull/2231#issuecomment-1915971687 Tests pass for me locally when combined with PR #2229. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

dsmiley commented on code in PR #2221: URL: https://github.com/apache/solr/pull/2221#discussion_r1470537795 ## solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java: ## @@ -169,6 +160,20 @@ public void prepare(ResponseBuilder rb) throws IOException { t

[jira] [Commented] (SOLR-17038) /admin/segments handler: Expose the term count

[ https://issues.apache.org/jira/browse/SOLR-17038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812137#comment-17812137 ] Rahul Goswami commented on SOLR-17038: -- I am working on this. > /admin/segments han

[jira] [Comment Edited] (SOLR-17038) /admin/segments handler: Expose the term count

[ https://issues.apache.org/jira/browse/SOLR-17038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812137#comment-17812137 ] Rahul Goswami edited comment on SOLR-17038 at 1/30/24 4:23 AM: