epugh commented on PR #2229: URL: https://github.com/apache/solr/pull/2229#issuecomment-1915917826
> > What jumped out at me is that we really abuse `GenericSolrRequest` all over the place. I also am hoping that as more of the V2 api's come online, we could reduce the places that we use `GenericSolrRequest`, kind of like how in some places you could swap in a `QueryRequest` in this PR! > > Yeah, I was thinking the same thing. There's a few times we use GenericSolrRequest as a way to hit a custom test endpoint or something like that, but that's definitely the exception and not the rule. 90% of these GSR usages are bandaids covering up the fact that we're missing SolrJ coverage for particular APIs. > > I think these invocations would be a great place to start sneaking in some of our v2 SolrRequest objects, as you suggested. (Would be a great newdev ticket!) Totally agree on getting some of the new v2 objects in! Also, I wonder if looking at uses of GenericSolrRequest would provide insight into which v2 apis should be prioritized? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
