risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914878120
I made a slight change to improve the variable name I added - c6618d6 > The method you are attempting to modify calls getDocListAndSetNC when useFilterCache=false, which is well optimized for this. Right but in that case - assuming you are referring to prior to my PR line 1703 / 1708, we don't get the optimizations from SOLR-14765. This means in the case of rows=0, we don't reuse the filter cache dotset and have to recompute it. With my change, we never get down to `getDocListAndSetNC` for the case of `rows=0` and can build the results right from the filterCache docset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
