janhoy commented on code in PR #2118:
URL: https://github.com/apache/solr/pull/2118#discussion_r1453177675
##
solr/core/src/java/org/apache/solr/util/ThreadStats.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
janhoy commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1453182213
##
solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java:
##
@@ -75,6 +73,8 @@
public class ContainerPluginsRegistry implements ClusterPropertiesListener,
[
https://issues.apache.org/jira/browse/SOLR-17074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-17074:
---
Security: (was: Public)
> Not correctly escaped quote in bin/solr script
> --
[
https://issues.apache.org/jira/browse/SOLR-17074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807194#comment-17807194
]
Christine Poerschke commented on SOLR-17074:
bq. ... I won't produce a fix an
[
https://issues.apache.org/jira/browse/SOLR-17074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-17074:
---
Labels: newdev (was: )
> Not correctly escaped quote in bin/solr script
> --
dsmiley commented on code in PR #2118:
URL: https://github.com/apache/solr/pull/2118#discussion_r1453403045
##
solr/core/src/java/org/apache/solr/util/ThreadStats.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
cpoerschke commented on PR #2176:
URL: https://github.com/apache/solr/pull/2176#issuecomment-1893752822
cross-referencing w.r.t. the `TestScoreJoinQPNoScore#testRandomJoin`
failures:
* https://lists.apache.org/thread/ms65gkmm86cpp5ntdo555ob8mrgg64o5 thread on
the Lucene Dev mailing list
gerlowskija commented on code in PR #2144:
URL: https://github.com/apache/solr/pull/2144#discussion_r1453453346
##
solr/core/src/test/org/apache/solr/handler/admin/api/RequestCoreCommandStatusTest.java:
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
gerlowskija commented on code in PR #2144:
URL: https://github.com/apache/solr/pull/2144#discussion_r1453484032
##
solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
magibney commented on PR #2199:
URL: https://github.com/apache/solr/pull/2199#issuecomment-1894015934
Should we instead have this default at the lowest level to being randomized,
or otherwise ensure that nothing (either now or future) falls through the
cracks?
This would yield a much
[
https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807343#comment-17807343
]
Jason Gerlowski commented on SOLR-17066:
bq. The commit messages here speak of "d
[
https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807343#comment-17807343
]
Jason Gerlowski edited comment on SOLR-17066 at 1/16/24 4:47 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807347#comment-17807347
]
Eric Pugh commented on SOLR-17066:
--
awesome!
> Deprecate and remove core URLs in HttpSo
freedev opened a new pull request, #2200:
URL: https://github.com/apache/solr/pull/2200
https://issues.apache.org/jira/browse/SOLR-17074
# Description
fixed the script `solr/bin/solr`
# Solution
Added the missing quotes
# Tests
Tried to
[
https://issues.apache.org/jira/browse/SOLR-17074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807353#comment-17807353
]
Vincenzo D'Amore commented on SOLR-17074:
-
Hi [~cpoerschke], I created the pull r
cpoerschke commented on code in PR #2200:
URL: https://github.com/apache/solr/pull/2200#discussion_r1453726936
##
solr/bin/solr:
##
@@ -422,7 +422,7 @@ function print_usage() {
echo ""
echo " -noprompt Don't prompt for input; accept all defaults
when runn
gerlowskija commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894171295
If you guys prefer "collection" here, that's fine with me. (@epugh - I
agree that some doc changes would be helpful in clarifying that "collection" is
sometimes used generically in the
gbellaton commented on PR #2118:
URL: https://github.com/apache/solr/pull/2118#issuecomment-1894200828
Should I add the New Feature in the 9.5.0 section of Changes.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dsmiley commented on PR #2118:
URL: https://github.com/apache/solr/pull/2118#issuecomment-1894204371
Yes, 9.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
epugh commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894206680
How much do you hate the idea of not having `storeType`?? Could we just
have two methods, one where it's `/core/{name}/select` and the other is
`/collection/{name}/select`? Could we side s
epugh commented on code in PR #2200:
URL: https://github.com/apache/solr/pull/2200#discussion_r1453760994
##
solr/bin/solr:
##
@@ -422,7 +422,7 @@ function print_usage() {
echo ""
echo " -noprompt Don't prompt for input; accept all defaults
when running e
gerlowskija commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894215477
Another slightly less arcane example is the
[DataStoreSolrRequest](https://github.com/apache/solr/pull/2177/files#diff-e13377598540e9ce1e314f17966d3f37cbe71433fe3ec6b91785751aa57df622)
c
epugh commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894220549
`IndexType`?And add it to
https://solr.apache.org/guide/solr/latest/getting-started/solr-glossary.html#SolrGlossary-I
?
--
This is an automated message from the Apache Git Service.
To r
epugh commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894221183
a logical Index can either be a single core or made up of many cores in the
form of a collection
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dsmiley commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894231175
+1 to IndexType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
gerlowskija commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894246273
OK, sounds good - I'll tag you both on a PR shortly that replaces
datastore/store with a combination of "collection" and "indextype".
--
This is an automated message from the Apache Gi
gerlowskija opened a new pull request, #2201:
URL: https://github.com/apache/solr/pull/2201
https://issues.apache.org/jira/browse/SOLR-17066
# Description
"Data store" as a term, was introduced a few weeks back as a way to refer
generically to something that could be either
gerlowskija commented on PR #2201:
URL: https://github.com/apache/solr/pull/2201#issuecomment-1894365651
FYI @dsmiley and @epugh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dsmiley commented on code in PR #2201:
URL: https://github.com/apache/solr/pull/2201#discussion_r1453961978
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##
@@ -238,16 +238,6 @@ public Builder canUseZkACLs(boolean canUseZkACLs) {
ret
epugh commented on code in PR #2201:
URL: https://github.com/apache/solr/pull/2201#discussion_r1454069949
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
Review Comment:
i think this javadocs is great... to me it reads clearer...
--
This is an
epugh commented on code in PR #2201:
URL: https://github.com/apache/solr/pull/2201#discussion_r1454071596
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java:
##
@@ -98,9 +98,9 @@ public B withFollowRedirects(boolean followRedirects) {
return get
[
https://issues.apache.org/jira/browse/SOLR-17106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807491#comment-17807491
]
Chris M. Hostetter commented on SOLR-17106:
---
Hi Aprna, thanks for creating this
32 matches
Mail list logo
