gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1453484032
########## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.api.endpoint; + +import io.swagger.v3.oas.annotations.Operation; +import io.swagger.v3.oas.annotations.Parameter; +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import org.apache.solr.client.api.model.SolrJerseyResponse; + +/** + * V2 API for checking the status of a core-level asynchronous command. + * + * <p>This API (GET /api/cores/command-status/someId is analogous to the v1 + * /admin/cores?action=REQUESTSTATUS command. It is not to be confused with the more robust + * asynchronous command support offered under the v2 `/cluster/command-status` path (or the + * corresponding v1 path `/solr/admin/collections?action=REQUESTSTATUS`). Async support at the core + * level differs in that command IDs are local to individual Solr nodes and are not persisted across + * restarts. + * + * @see org.apache.solr.client.api.model.RequestCoreCommandStatusResponseBody + */ +@Path("/cores/command-status/") Review Comment: > Just a thought that the concept of node is more SolrCloud, and here we are dealing with request status command at core admin level I see your point. "Node" does kindof imply a distributed setup in a way that might be odd for folks that only run a single Solr process. That said, I'd hope that folks that run a single instance of Solr in "standalone" mode would understand that Solr does allow you to network multiple processes (even if they're not using that capability themselves). So hopefully it wouldn't be too confusing? (Even "standalone" mode has features built on running multiple instances, fwiw. e.g. You can do leader-follower replication from cores on different Solr processes/nodes. "Standalone" is kindof a bad name in that sense haha) ---- Anyway, I definitely see your concerns, but IMO `/api/node/commands/someRequestId` is still among our best options. It'd probably be my pick personally, but I support sticking with `/api/cores/coreName/commands/someRequestId` if you like that one better. Just lmk in your reply which one you want to go with, and whether you want to handle the changes (or whether I should)! Thanks again to being flexible to the back-and-forth on this; definitely gives us a better end product! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
