gerlowskija commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894171295
If you guys prefer "collection" here, that's fine with me. (@epugh - I
agree that some doc changes would be helpful in clarifying that "collection" is
sometimes used generically in the "logical index" or "collection or core"
sense). This'll work in 99% of cases.
That said, there are some edge cases where (IMO) we can't unambiguously use
"collection". Consider `QueryingApi.JsonQuery`, a generated SolrJ class for
making queries using the v2 paths:
```
public static class JsonQuery extends SolrRequest<JsonQueryResponse> {
....
public JsonQuery(StoreType storeType, String storeName, Object
requestBody) {
super(
SolrRequest.METHOD.valueOf("POST"),
"/{storeType}/{storeName}/select"
.replace("{" + "storeType" + "}", storeType.toString())
.replace("{" + "storeName" + "}", storeName));
}
```
Our v2 API uses different paths to distinguish between queries to individual
cores (`/cores/<coreName>/select`) and to collections
(`/collections/<collName>/select`). In order for `QueryingApi.JsonQuery` to be
re-usable for both these cases, its ctor takes an enum (currently called
"StoreType") to indicate what is being queried so that it can build the correct
HTTP path.
As an example: what would you all prefer as the name for this enum?
"CollectionType" wouldn't make any sense here IMO. If we think "store" is more
overloaded than "index", then I can rename it from `StoreType` to `IndexType`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
