[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-10 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741559#comment-17741559 ] Ovidiu Mihalcea commented on SOLR-8803: --- I'm having trouble with this change as the

[jira] [Commented] (SOLR-8803) Generalize OOME handling to work for any OS

2023-07-10 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741628#comment-17741628 ] Shawn Heisey commented on SOLR-8803: {quote}I'm having trouble with this change as the

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
HoustonPutman commented on code in PR #1765: URL: https://github.com/apache/solr/pull/1765#discussion_r1258309737 ## solr/bin/solr: ## @@ -1581,7 +1581,8 @@ if [ "${SOLR_HOME:0:${#EXAMPLE_DIR}}" = "$EXAMPLE_DIR" ]; then SOLR_LOGS_DIR="$SOLR_HOME/../logs" fi -LOG4J_CONFIG=

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
HoustonPutman commented on code in PR #1765: URL: https://github.com/apache/solr/pull/1765#discussion_r1258324388 ## solr/bin/solr: ## @@ -1581,7 +1581,8 @@ if [ "${SOLR_HOME:0:${#EXAMPLE_DIR}}" = "$EXAMPLE_DIR" ]; then SOLR_LOGS_DIR="$SOLR_HOME/../logs" fi -LOG4J_CONFIG=

[GitHub] [solr] HoustonPutman commented on pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
HoustonPutman commented on PR #1765: URL: https://github.com/apache/solr/pull/1765#issuecomment-1629045722 On startup I now see: ``` 2023-07-10 14:06:29.033 INFO (main) [] o.e.j.s.Server jetty-10.0.15; built: 2023-04-11T17:25:14.480Z; git: 68017dbd00236bb7e187330d7585a059610f661d;

[GitHub] [solr] HoustonPutman merged pull request #1766: Pass verbose flag to solr start when using example

2023-07-10 Thread via GitHub
HoustonPutman merged PR #1766: URL: https://github.com/apache/solr/pull/1766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Resolved] (SOLR-16675) Introduce the possibility to rerank topK results with vector similarity functions using DenseVectorField

2023-07-10 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti resolved SOLR-16675. - Resolution: Done > Introduce the possibility to rerank topK results with vector s

[GitHub] [solr] HoustonPutman closed pull request #1764: SOLR-16877: Update BackupManager.java to prevent NPE on empty zk node

2023-07-10 Thread via GitHub
HoustonPutman closed pull request #1764: SOLR-16877: Update BackupManager.java to prevent NPE on empty zk node URL: https://github.com/apache/solr/pull/1764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-16877) solr backup via collections api fails with NPE when config contains an empty zookeeper node

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741644#comment-17741644 ] ASF subversion and git services commented on SOLR-16877: Commit 6

[GitHub] [solr] HoustonPutman commented on pull request #1764: SOLR-16877: Update BackupManager.java to prevent NPE on empty zk node

2023-07-10 Thread via GitHub
HoustonPutman commented on PR #1764: URL: https://github.com/apache/solr/pull/1764#issuecomment-1629128587 I couldn't push to this branch, because it's an organization fork, not an individual's. But that's ok. I added a changelog entry and pushed to main. Wish this showed as "merged" though

[jira] [Commented] (SOLR-16877) solr backup via collections api fails with NPE when config contains an empty zookeeper node

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741646#comment-17741646 ] ASF subversion and git services commented on SOLR-16877: Commit f

[jira] [Commented] (SOLR-16877) solr backup via collections api fails with NPE when config contains an empty zookeeper node

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741649#comment-17741649 ] ASF subversion and git services commented on SOLR-16877: Commit a

[GitHub] [solr] bruno-roustant commented on a diff in pull request #1761: SOLR-16879: add queue for expensive admin operations

2023-07-10 Thread via GitHub
bruno-roustant commented on code in PR #1761: URL: https://github.com/apache/solr/pull/1761#discussion_r1258392079 ## solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java: ## @@ -403,60 +411,109 @@ public interface CoreAdminOp { public static class CoreAdm

[jira] [Resolved] (SOLR-16877) solr backup via collections api fails with NPE when config contains an empty zookeeper node

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16877. --- Assignee: Houston Putman Resolution: Fixed > solr backup via collections api fails with

[jira] [Created] (SOLR-16884) Enable search in javadocs

2023-07-10 Thread Houston Putman (Jira)
Houston Putman created SOLR-16884: - Summary: Enable search in javadocs Key: SOLR-16884 URL: https://issues.apache.org/jira/browse/SOLR-16884 Project: Solr Issue Type: Task Security Leve

[jira] [Updated] (SOLR-16884) Enable search in javadocs

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16884: -- Fix Version/s: 9.3 > Enable search in javadocs > - > >

[GitHub] [solr] HoustonPutman opened a new pull request, #1772: SOLR-16884: Enable javadocs search for the site build

2023-07-10 Thread via GitHub
HoustonPutman opened a new pull request, #1772: URL: https://github.com/apache/solr/pull/1772 https://issues.apache.org/jira/browse/SOLR-16884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (SOLR-16824) Adopt Linux Command line tool pattern of -- for multi charater commands.

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741664#comment-17741664 ] Houston Putman commented on SOLR-16824: --- I love this. I hate the single '-' options

[jira] [Comment Edited] (SOLR-16824) Adopt Linux Command line tool pattern of -- for multi charater commands.

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741664#comment-17741664 ] Houston Putman edited comment on SOLR-16824 at 7/10/23 3:33 PM: ---

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1772: SOLR-16884: Enable javadocs search for the site build

2023-07-10 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1772: URL: https://github.com/apache/solr/pull/1772#discussion_r1258576196 ## dev-tools/scripts/checkJavadocLinks.py: ## @@ -41,7 +41,7 @@ def __init__(self, baseURL): def handle_starttag(self, tag, attrs): # NOTE: I don't thin

[jira] [Commented] (SOLR-16863) Class not found SQLHandler

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741687#comment-17741687 ] Houston Putman commented on SOLR-16863: --- So the SQL language page has a warning tha

[jira] [Commented] (SOLR-16733) Solr fails to start on macOS with OpenJDK 20

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741691#comment-17741691 ] Houston Putman commented on SOLR-16733: --- I've added a warning about MacOS and Java

[jira] [Comment Edited] (SOLR-16812) Support CBOR format for update/query

2023-07-10 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741694#comment-17741694 ] Jason Gerlowski edited comment on SOLR-16812 at 7/10/23 4:50 PM: --

[jira] [Commented] (SOLR-16812) Support CBOR format for update/query

2023-07-10 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741694#comment-17741694 ] Jason Gerlowski commented on SOLR-16812: Was looking through some code this morni

[jira] [Commented] (SOLR-16863) Class not found SQLHandler

2023-07-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741710#comment-17741710 ] Ishan Chattopadhyaya commented on SOLR-16863: - bq. I think the best solution

[jira] [Commented] (SOLR-16863) Class not found SQLHandler

2023-07-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741711#comment-17741711 ] Ishan Chattopadhyaya commented on SOLR-16863: - bq. capture a 404 error and gi

[jira] [Updated] (SOLR-16777) Schema Designer blindly "trusts" potentially malicious configset

2023-07-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-16777: Fix Version/s: 9.3 (was: 9.2.2) > Schema Designer blindly "t

[jira] [Commented] (SOLR-16777) Schema Designer blindly "trusts" potentially malicious configset

2023-07-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741713#comment-17741713 ] Ishan Chattopadhyaya commented on SOLR-16777: - I'll take a look at this, late

[GitHub] [solr] HoustonPutman merged pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
HoustonPutman merged PR #1765: URL: https://github.com/apache/solr/pull/1765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-16878) Include Lucene JUL logs with Solr logging

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741716#comment-17741716 ] ASF subversion and git services commented on SOLR-16878: Commit 8

[jira] [Commented] (SOLR-16878) Include Lucene JUL logs with Solr logging

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741717#comment-17741717 ] ASF subversion and git services commented on SOLR-16878: Commit 0

[jira] [Commented] (SOLR-16878) Include Lucene JUL logs with Solr logging

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741719#comment-17741719 ] ASF subversion and git services commented on SOLR-16878: Commit e

[jira] [Resolved] (SOLR-16878) Include Lucene JUL logs with Solr logging

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16878. --- Assignee: Houston Putman Resolution: Done > Include Lucene JUL logs with Solr logging >

[jira] [Commented] (SOLR-16863) Class not found SQLHandler

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741721#comment-17741721 ] Houston Putman commented on SOLR-16863: --- Yeah, something like your point #1. I gues

[jira] [Updated] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-07-10 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16858: -- Labels: hybrid-search (was: ) > Allow KnnQParser to selectively apply filters > --

[jira] [Updated] (SOLR-16857) Efficiently rerank collapsed queries with vector queries

2023-07-10 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16857: -- Labels: hybrid-search (was: ) > Efficiently rerank collapsed queries with vector queries > ---

[GitHub] [solr] uschindler commented on a diff in pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
uschindler commented on code in PR #1765: URL: https://github.com/apache/solr/pull/1765#discussion_r1258682017 ## solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java: ## @@ -226,6 +229,21 @@ public void init(ServletContext servletContext) { StartupLogg

[GitHub] [solr] uschindler commented on pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
uschindler commented on PR #1765: URL: https://github.com/apache/solr/pull/1765#issuecomment-1629497333 It also shows the log levels here: ![image](https://github.com/apache/solr/assets/1005388/24796ec7-1473-40d7-81b8-2493a1cb3b9d) -- This is an automated message from the Apache G

[jira] [Created] (SOLR-16885) Highlighter IndexOutOfBoundsException using termVectors

2023-07-10 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-16885: - Summary: Highlighter IndexOutOfBoundsException using termVectors Key: SOLR-16885 URL: https://issues.apache.org/jira/browse/SOLR-16885 Project: Solr

[jira] [Commented] (SOLR-16885) Highlighter IndexOutOfBoundsException using termVectors

2023-07-10 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741739#comment-17741739 ] Chris M. Hostetter commented on SOLR-16885: --- Root cause is [Lucene issue # 124

[jira] [Updated] (SOLR-16885) Highlighter IndexOutOfBoundsException using termVectors

2023-07-10 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-16885: -- Description: Beginning with Solr 9.0, schemas + data + queries that could be indexed &

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
HoustonPutman commented on code in PR #1765: URL: https://github.com/apache/solr/pull/1765#discussion_r1258715694 ## solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java: ## @@ -226,6 +229,21 @@ public void init(ServletContext servletContext) { StartupL

[GitHub] [solr] noblepaul commented on pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-10 Thread via GitHub
noblepaul commented on PR #1762: URL: https://github.com/apache/solr/pull/1762#issuecomment-1629558259 @patsonluk I've made the changes to avoid race condition in core creation as well -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (SOLR-16878) Include Lucene JUL logs with Solr logging

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741741#comment-17741741 ] ASF subversion and git services commented on SOLR-16878: Commit e

[jira] [Commented] (SOLR-16878) Include Lucene JUL logs with Solr logging

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741742#comment-17741742 ] ASF subversion and git services commented on SOLR-16878: Commit 6

[jira] [Commented] (SOLR-16878) Include Lucene JUL logs with Solr logging

2023-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741743#comment-17741743 ] ASF subversion and git services commented on SOLR-16878: Commit a

[jira] [Updated] (SOLR-16777) Schema Designer blindly "trusts" potentially malicious configset

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16777: -- Attachment: SOLR-16777-1.patch Status: Reopened (was: Reopened) > Schema Designer blin

[jira] [Commented] (SOLR-16777) Schema Designer blindly "trusts" potentially malicious configset

2023-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741756#comment-17741756 ] Houston Putman commented on SOLR-16777: --- I added a patch that should use the built-

[jira] [Commented] (SOLR-16863) Class not found SQLHandler

2023-07-10 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741760#comment-17741760 ] Alex Deparvu commented on SOLR-16863: - I had already opened a Jira for this but didn'

[jira] [Commented] (SOLR-16852) Let backups have custom key/values

2023-07-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741762#comment-17741762 ] David Smiley commented on SOLR-16852: - Wouldn't commit metadata be a more general way

[GitHub] [solr] uschindler commented on pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
uschindler commented on PR #1765: URL: https://github.com/apache/solr/pull/1765#issuecomment-1629765785 Looks fine on main branch! I just noticed: we still have "-XX:CompileCommand=exclude,com.github.benmanes.caffeine.cache.BoundedLocalCache::put" in the command line options. Wasn't

[GitHub] [solr] uschindler commented on pull request #1090: SOLR-16463: Workaround for serious crash on JDK17+

2023-07-10 Thread via GitHub
uschindler commented on PR #1090: URL: https://github.com/apache/solr/pull/1090#issuecomment-1629768930 Does this fix still applies? We have updated caffeine already or is this still needed for other reasons? I just noticed the command line option when starting Solr 9.3 testing with Java 20

[GitHub] [solr] uschindler commented on pull request #1765: SOLR-16878: Add JUL Log4J manager for lucene logs

2023-07-10 Thread via GitHub
uschindler commented on PR #1765: URL: https://github.com/apache/solr/pull/1765#issuecomment-1629769482 Ignore this, I asked question on #1090. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] patsonluk commented on a diff in pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-10 Thread via GitHub
patsonluk commented on code in PR #1762: URL: https://github.com/apache/solr/pull/1762#discussion_r1258962825 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String collectionName) {

[GitHub] [solr] patsonluk commented on a diff in pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-10 Thread via GitHub
patsonluk commented on code in PR #1762: URL: https://github.com/apache/solr/pull/1762#discussion_r1258962825 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String collectionName) {

[jira] [Resolved] (SOLR-16863) Class not found SQLHandler

2023-07-10 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-16863. - Resolution: Duplicate > Class not found SQLHandler > -- > >

[jira] [Created] (SOLR-16886) S3OutputStream attempts to complete multi-part uploads even after they are aborted

2023-07-10 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-16886: Summary: S3OutputStream attempts to complete multi-part uploads even after they are aborted Key: SOLR-16886 URL: https://issues.apache.org/jira/bro

[GitHub] [solr] tflobbe opened a new pull request, #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-10 Thread via GitHub
tflobbe opened a new pull request, #1773: URL: https://github.com/apache/solr/pull/1773 The `complete()` method is currently being called from the `close()`, which is called from try-with-resources -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [solr] mkhludnev commented on pull request #1773: SOLR-16886: Don't commit multi-part uploads that have been aborted

2023-07-10 Thread via GitHub
mkhludnev commented on PR #1773: URL: https://github.com/apache/solr/pull/1773#issuecomment-1630223134 Nice catch. Is there a chance to cover it with some sort of unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and