[
https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741694#comment-17741694
]
Jason Gerlowski edited comment on SOLR-16812 at 7/10/23 4:50 PM:
-----------------------------------------------------------------
Was looking through some code this morning and noticed an internal class in
{{SolrExampleCborTest}} that allows the test to [create a
RequestWriter|https://github.com/apache/solr/blob/6350eb53955639da1d1da60cf77d0ef440d9094d/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleCborTest.java#L242]
for sending CBOR requests.
The code itself is fine, but it made me curious: why is it living in a test and
not in SolrJ proper? We've got this nice new format that serde's lightning
fast and compresses reasonably well, and we have code that lets SolrJ use it to
send requests...but it's only available in a test class?
Can you clarify [~noble.paul]? Feel like I'm missing something...
was (Author: gerlowskija):
Was looking through some code this morning and noticed an internal class in
{{SolrExampleCborTest}} that allows the test to [create a
RequestWriter|https://github.com/apache/solr/blob/6350eb53955639da1d1da60cf77d0ef440d9094d/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleCborTest.java#L242]
for sending CBOR requests.
The code itself is fine, but it made me curious: why is it living in a test and
not in SolrJ proper? We've got this nice new format that serde's lightning
fast and compresses reasonably well, and we have code that lets SolrJ use it to
send requests...but it's only available in a test class?
Can you clarify [~noble.paul]?
> Support CBOR format for update/query
> ------------------------------------
>
> Key: SOLR-16812
> URL: https://issues.apache.org/jira/browse/SOLR-16812
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Major
> Fix For: 9.3
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Javabin is quite efficient and fast . But non-java users have to use JSON
> exclusively
>
> [CBOR |http://example.com/] is a widely used format that is supported by most
> languages.
>
> Here is a benchmark of updating using CBOR vs. JSON our films.json
> {code:java}
> Payload Size (bytes)
> ============
>
> json : 633600
> cbor : 210439
> javabin: 234520
> time taken to index
> ====================
> JSON: 330ms
> JAVABIN: 216ms
> CBOR: 200ms
> time takes to query *:* 1100 docs
> ==================================
> json: 85 ms
> javabin : 64ms
> cbor : 53ms{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
