sonatype-lift[bot] commented on code in PR #1772:
URL: https://github.com/apache/solr/pull/1772#discussion_r1258576196
##########
dev-tools/scripts/checkJavadocLinks.py:
##########
@@ -41,7 +41,7 @@ def __init__(self, baseURL):
def handle_starttag(self, tag, attrs):
# NOTE: I don't think 'a' should be in here. But try debugging
# NumericRangeQuery.html. (Could be javadocs bug, it's a generic type...)
- if tag not in ('link', 'meta', 'frame', 'br', 'wbr', 'hr', 'p', 'li',
'img', 'col', 'a', 'dt', 'dd'):
+ if tag not in ('link', 'meta', 'frame', 'br', 'wbr', 'hr', 'p', 'li',
'img', 'col', 'a', 'dt', 'dd', 'input'):
Review Comment:
<picture><img alt="6% of developers fix this issue"
src="https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg";></picture>
<b>*E501:</b>* line too long (114 > 79 characters)
---
<details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b>
commands</summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
##########
dev-tools/scripts/checkJavadocLinks.py:
##########
@@ -79,7 +79,7 @@ def handle_starttag(self, tag, attrs):
raise RuntimeError('couldn\'t find an href nor name in link in %s:
only got these attrs: %s' % (self.baseURL, attrs))
def handle_endtag(self, tag):
- if tag in ('link', 'meta', 'frame', 'br', 'hr', 'p', 'li', 'img', 'col',
'a', 'dt', 'dd'):
+ if tag in ('link', 'meta', 'frame', 'br', 'hr', 'p', 'li', 'img', 'col',
'a', 'dt', 'dd', 'input'):
Review Comment:
<picture><img alt="6% of developers fix this issue"
src="https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg";></picture>
<b>*E501:</b>* line too long (103 > 79 characters)
---
<details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b>
commands</summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
![https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg"](https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg"){kind=link}