[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-26 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1148546267 ## solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java: ## @@ -563,25 +541,29 @@ protected void assertDocsExistInAllReplicas( } } - protected SolrClie

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-26 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1148546799 ## solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java: ## @@ -307,16 +340,24 @@ public void testDeleteByIdCompositeRouterWithRouterField() throws Ex

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-26 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1148551005 ## solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java: ## @@ -258,25 +278,38 @@ public void testDeleteByIdImplicitRouter() throws Exception { }

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-26 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1148550914 ## solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java: ## @@ -307,16 +340,24 @@ public void testDeleteByIdCompositeRouterWithRouterField() throws Ex

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-26 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1148552968 ## solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java: ## @@ -182,17 +184,32 @@ public void testReplicasInLowerTerms() throws Exception { assertEquals(

[jira] [Commented] (SOLR-16668) Use default Java SslContextFactory for HTTP2 when no system properties are given

2023-03-26 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705107#comment-17705107 ] Shawn Heisey commented on SOLR-16668: - So ... the problem I have with SolrJ 9.2.0 is

[jira] [Commented] (SOLR-16240) org.apache.solr.common.SolrException: Error loading class 'solr.KerberosPlugin'

2023-03-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705131#comment-17705131 ] Jan Høydahl commented on SOLR-16240: A pity there is no test that could detect this.

[jira] [Commented] (SOLR-16714) ReleaseWizard to add dependency upgrades to CHANGES

2023-03-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705136#comment-17705136 ] Jan Høydahl commented on SOLR-16714: See the attached PR, it seems to work pretty wel

[jira] [Commented] (SOLR-16668) Use default Java SslContextFactory for HTTP2 when no system properties are given

2023-03-26 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705137#comment-17705137 ] Eric Pugh commented on SOLR-16668: -- Huh, I thought one of our drivers for upgrading was

[jira] [Assigned] (SOLR-7632) Change the ExtractingRequestHandler to use Tika-Server

2023-03-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-7632: - Assignee: Jan Høydahl > Change the ExtractingRequestHandler to use Tika-Server >

[jira] [Commented] (SOLR-7632) Change the ExtractingRequestHandler to use Tika-Server

2023-03-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705138#comment-17705138 ] Jan Høydahl commented on SOLR-7632: --- Following a [DISCUSS thread|https://lists.apache.o

[jira] [Commented] (SOLR-1526) Client Side Tika integration

2023-03-26 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705140#comment-17705140 ] Jan Høydahl commented on SOLR-1526: --- Not convinced anymore that a tight integration with