epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1148546267
##########
solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java:
##########
@@ -563,25 +541,29 @@ protected void assertDocsExistInAllReplicas(
}
}
- protected SolrClient getHttpSolrClient(Replica replica, String coll) {
+ protected SolrClient getHttpSolrClient(Replica replica, String collection) {
Review Comment:
if it was `coll` everywhere in the code base, then I'd be a fan of `coll`.
Since I see `collection`, i made that change.... One thing I thought about
was going through and at least in the tests, we use `collection`,
`testCollectionName` and `collectionName` and getting that to one value..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
