epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1148550914
##########
solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java:
##########
@@ -307,16 +340,24 @@ public void
testDeleteByIdCompositeRouterWithRouterField() throws Exception {
// including cloudClient helps us test view from other nodes
that aren't the
// leaders...
for (SolrClient c : Arrays.asList(cloudClient, shard1, shard2)) {
+ String queryWithCollectionName =
Review Comment:
Reworked it, passing in conditionally the `collection` param as part of the
`params` object... I think this is cleaner, less indirection ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
