[jira] [Comment Edited] (SOLR-16465) Start the migration of the Admin UI to Angular

2023-03-21 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703079#comment-17703079 ] Marcus Eagan edited comment on SOLR-16465 at 3/21/23 7:59 AM: -

[jira] [Commented] (SOLR-16465) Start the migration of the Admin UI to Angular

2023-03-21 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703079#comment-17703079 ] Marcus Eagan commented on SOLR-16465: - Hi everyone, long time no Jira rant. I am look

[GitHub] [solr] bszabo97 commented on pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-21 Thread via GitHub
bszabo97 commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1477557782 Do you recon I should revert the changes already made to the `DistribPackageStore` class? Initially I changed the client to jetty because the test was failing with json type `writeRaw` func

[jira] [Updated] (SOLR-16465) Start the migration of the Admin UI to React

2023-03-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16465: --- Summary: Start the migration of the Admin UI to React (was: Start the migration of the Admin UI to A

[jira] [Commented] (SOLR-16465) Start the migration of the Admin UI to React

2023-03-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703180#comment-17703180 ] Jan Høydahl commented on SOLR-16465: Hi. I'd appreciate any effort to get us off of

[jira] [Commented] (SOLR-16465) Start the migration of the Admin UI to React

2023-03-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703188#comment-17703188 ] Eric Pugh commented on SOLR-16465: -- Thanks [~marcussorealheis]! For me to get behind a

[jira] [Commented] (SOLR-16465) Start the migration of the Admin UI to React

2023-03-21 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703197#comment-17703197 ] Ishan Chattopadhyaya commented on SOLR-16465: - Thanks [~marcussorealheis]. An

[jira] [Resolved] (SOLR-9459) Upgrade dependencies

2023-03-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-9459. Resolution: Fixed This has been fixed over time. Solr 9.2 has upgraded dependencies. Solr 9.0 had a

[jira] [Created] (SOLR-16713) Replace Guava usages with pure Java

2023-03-21 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16713: --- Summary: Replace Guava usages with pure Java Key: SOLR-16713 URL: https://issues.apache.org/jira/browse/SOLR-16713 Project: Solr Issue Type: Task Securi

[jira] [Updated] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16638: Fix Version/s: 9.3 (was: 9.2) > Fix Http2SolrClient's exception message when

[jira] [Commented] (SOLR-16713) Replace Guava usages with pure Java

2023-03-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703205#comment-17703205 ] Kevin Risden commented on SOLR-16713: - PR https://github.com/apache/solr/pull/1466 >

[jira] [Updated] (SOLR-16713) Replace Guava usages with pure Java

2023-03-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16713: Status: Patch Available (was: Open) > Replace Guava usages with pure Java > -

[jira] [Updated] (SOLR-16713) Replace Guava usages with pure Java

2023-03-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16713: Description: Guava is used in a variety of places that can be simplified especially with Java stre

[jira] [Commented] (SOLR-16707) TestFiltering.testRandomFiltering Caffeine cache async=false IllegalStateException: Recursive update

2023-03-21 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703209#comment-17703209 ] Michael Gibney commented on SOLR-16707: --- {quote} I could imagine timeAllowed suppor

[jira] [Commented] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703210#comment-17703210 ] ASF subversion and git services commented on SOLR-16638: Commit 4

[jira] [Commented] (SOLR-16638) Fix Http2SolrClient's exception message when serverBaseUrl is null

2023-03-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703214#comment-17703214 ] ASF subversion and git services commented on SOLR-16638: Commit 3

[GitHub] [solr] justinrsweeney commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
justinrsweeney commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1143411837 ## solr/core/src/java/org/apache/solr/api/Api.java: ## @@ -44,9 +43,7 @@ public Map getCommandSchema() { if (commandSchema == null) { Validating

[GitHub] [solr] risdenk commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1143435765 ## solr/core/src/java/org/apache/solr/api/Api.java: ## @@ -44,9 +43,7 @@ public Map getCommandSchema() { if (commandSchema == null) { ValidatingJsonMap

[jira] [Created] (SOLR-16714) ReleaseWizard to add dependency upgrades to CHANGES

2023-03-21 Thread Jira
Jan Høydahl created SOLR-16714: -- Summary: ReleaseWizard to add dependency upgrades to CHANGES Key: SOLR-16714 URL: https://issues.apache.org/jira/browse/SOLR-16714 Project: Solr Issue Type: Impr

[GitHub] [solr] risdenk commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1143437955 ## solr/core/src/java/org/apache/solr/api/Api.java: ## @@ -44,9 +43,7 @@ public Map getCommandSchema() { if (commandSchema == null) { ValidatingJsonMap

[GitHub] [solr] risdenk merged pull request #1473: Update org.apache.calcite to v1.34.0

2023-03-21 Thread via GitHub
risdenk merged PR #1473: URL: https://github.com/apache/solr/pull/1473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16714) ReleaseWizard to add dependency upgrades to CHANGES

2023-03-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703223#comment-17703223 ] Kevin Risden commented on SOLR-16714: - How about just compare versions.props across b

[GitHub] [solr] risdenk merged pull request #1472: Update Jetty to 10.0.14, slf4j to 2.0.7, io.dropwizard.metrics to v4.2.18

2023-03-21 Thread via GitHub
risdenk merged PR #1472: URL: https://github.com/apache/solr/pull/1472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] risdenk merged pull request #1474: Update io.netty:* to v4.1.90.Final

2023-03-21 Thread via GitHub
risdenk merged PR #1474: URL: https://github.com/apache/solr/pull/1474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] justinrsweeney commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
justinrsweeney commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1143485079 ## solr/core/src/java/org/apache/solr/api/Api.java: ## @@ -44,9 +43,7 @@ public Map getCommandSchema() { if (commandSchema == null) { Validating

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-21 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1143539842 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/JsonMapResponseParser.java: ## @@ -0,0 +1,53 @@ +package org.apache.solr.client.solrj.impl; + +import j

[jira] [Resolved] (SOLR-16183) XML Loader: support indexing single nested child document

2023-03-21 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved SOLR-16183. - Resolution: Fixed > XML Loader: support indexing single nested child document > -

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1435: SOLR-16674: Introduce dense vector byte encoding

2023-03-21 Thread via GitHub
alessandrobenedetti commented on code in PR #1435: URL: https://github.com/apache/solr/pull/1435#discussion_r1140498109 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -165,38 +178,69 @@ public void checkSchemaField(final SchemaField field) throws Solr

[jira] [Commented] (SOLR-16240) org.apache.solr.common.SolrException: Error loading class 'solr.KerberosPlugin'

2023-03-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703270#comment-17703270 ] Jesús Ricardo Ballesteros Molina commented on SOLR-16240: - Hello

[GitHub] [solr] epugh commented on pull request #1476: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes

2023-03-21 Thread via GitHub
epugh commented on PR #1476: URL: https://github.com/apache/solr/pull/1476#issuecomment-1478331032 Getting to done on this... A question, should I move SolrCLI.java into the `.utils.cli` package and update the scripts etc?Any other changes that folks think need doing to call this "don

[GitHub] [solr] epugh commented on pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-21 Thread via GitHub
epugh commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1478337934 Let me know when you are ready for some testing ;-) I think this probably warrants some manual testing. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [solr] epugh merged pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-03-21 Thread via GitHub
epugh merged PR #1273: URL: https://github.com/apache/solr/pull/1273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16610) Support Copy n Paste of Command Line commands in Ref Guide

2023-03-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703317#comment-17703317 ] ASF subversion and git services commented on SOLR-16610: Commit 6

[jira] [Commented] (SOLR-16610) Support Copy n Paste of Command Line commands in Ref Guide

2023-03-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703316#comment-17703316 ] ASF subversion and git services commented on SOLR-16610: Commit 3

[jira] [Commented] (SOLR-16610) Support Copy n Paste of Command Line commands in Ref Guide

2023-03-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703318#comment-17703318 ] Eric Pugh commented on SOLR-16610: -- This has been completed for the various Solr tutoria

[GitHub] [solr] HoustonPutman commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-03-21 Thread via GitHub
HoustonPutman commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1478356598 After you check this out on the staging site, feel free to merge to branch_9_2! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [solr] epugh commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-03-21 Thread via GitHub
epugh commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1478367472 umm.. I was a bit bummed I missed the cut off... not sure I'm quite up for trying out merging to staging, so was just oign t to suffer in silence till 9.3 came out ;-) I've never touched

[jira] [Commented] (SOLR-16507) Remove NodeStateProvider & Snitch

2023-03-21 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703331#comment-17703331 ] Andrzej Bialecki commented on SOLR-16507: - Thanks [~dsmiley] for bringing this to

[jira] [Commented] (SOLR-16707) TestFiltering.testRandomFiltering Caffeine cache async=false IllegalStateException: Recursive update

2023-03-21 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1770#comment-1770 ] Mikhail Khludnev commented on SOLR-16707: - Let's start from fixing the flipping t

[jira] [Commented] (SOLR-16507) Remove NodeStateProvider & Snitch

2023-03-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703343#comment-17703343 ] David Smiley commented on SOLR-16507: - Thanks AB! Do you think there's a point to Sp

[GitHub] [solr] HoustonPutman commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-03-21 Thread via GitHub
HoustonPutman commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1478501614 Luckily since its just a doc change, whatever is on branch_9_2 is the official 9.2 docs, so backporting after the release is no issue at all. This is the nightly build that you c

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-21 Thread via GitHub
HoustonPutman commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1143933928 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -332,6 +335,11 @@ public Builder withRetryExpiryTime(long expiryTime, Time

[jira] [Commented] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-03-21 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703368#comment-17703368 ] Jason Gerlowski commented on SOLR-16393: I've started working on it, thanks for c

[GitHub] [solr] dsmiley commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
dsmiley commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1143669893 ## solr/core/src/java/org/apache/solr/core/backup/BackupManager.java: ## @@ -254,7 +254,10 @@ public void uploadConfigDir( String sourceConfigName, String targetCon

[GitHub] [solr] dsmiley commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-21 Thread via GitHub
dsmiley commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1143994795 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -332,6 +335,11 @@ public Builder withRetryExpiryTime(long expiryTime, TimeUnit u

[GitHub] [solr] risdenk commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1144010766 ## solr/core/src/java/org/apache/solr/core/backup/BackupManager.java: ## @@ -254,7 +254,10 @@ public void uploadConfigDir( String sourceConfigName, String targetCon

[GitHub] [solr] risdenk commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1144014874 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2192,6 +2191,9 @@ public SolrCore getCore(String name) { * @see SolrCore#close() */ public

[GitHub] [solr] risdenk commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1144018575 ## solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java: ## @@ -1558,7 +1556,7 @@ Solution is q(k) = 1/2 (k^2+k+2) public Builder addSu

[GitHub] [solr] risdenk commented on pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
risdenk commented on PR #1466: URL: https://github.com/apache/solr/pull/1466#issuecomment-1478627949 @dsmiley thanks for the thorough review. I addressed most of them or left comments. The only one that is outstanding I think is - https://github.com/apache/solr/pull/1466#discussion_r1144008

[GitHub] [solr] risdenk opened a new pull request, #1478: WIP Commons io to jdk isms

2023-03-21 Thread via GitHub
risdenk opened a new pull request, #1478: URL: https://github.com/apache/solr/pull/1478 https://issues.apache.org/jira/browse/SOLR-X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [solr] dsmiley commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
dsmiley commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1144038630 ## solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java: ## @@ -885,7 +884,7 @@ private static SolrInputDocument toSolrInputDocument(SolrDocumen

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1478: WIP Commons io to jdk isms

2023-03-21 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1478: URL: https://github.com/apache/solr/pull/1478#discussion_r1144054955 ## solr/test-framework/src/java/org/apache/solr/handler/BackupRestoreUtils.java: ## @@ -110,13 +109,9 @@ public static void runReplicationHandlerCommand( }

[GitHub] [solr] risdenk commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1144122612 ## solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java: ## @@ -885,7 +884,7 @@ private static SolrInputDocument toSolrInputDocument(SolrDocumen

[GitHub] [solr] dsmiley commented on a diff in pull request #1466: SOLR-16713: Replace Guava usages with pure Java

2023-03-21 Thread via GitHub
dsmiley commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1144145801 ## solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java: ## @@ -885,7 +884,7 @@ private static SolrInputDocument toSolrInputDocument(SolrDocumen