dsmiley commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1143994795
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ########## @@ -332,6 +335,11 @@ public Builder withRetryExpiryTime(long expiryTime, TimeUnit unit) { return this; } + /** Sets the default collection for request. */ + public Builder withDefaultCollection(String collection) { Review Comment: Right; but nearby, easy to **not** specify a collection in a command and **not** communicate with the intended collection. For example imagine some code that looks like: ``` addSomeDocs(collectionName) .... commit() ``` My real wish/preference isn't reflected in this PR at all actually, which is for there to be a collection scoped thing that you can interact with, instead of many overloads that are optional. Maybe let's keep defaultCollection as that and then some future day work towards that (if I can convince anyone). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org