[jira] [Commented] (SOLR-16507) Remove NodeStateProvider & Snitch

2023-03-20 Thread Vinayak Hegde (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702633#comment-17702633 ] Vinayak Hegde commented on SOLR-16507: -- Okay, will pause the work until we get some

[jira] [Commented] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)

2023-03-20 Thread Vinayak Hegde (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702642#comment-17702642 ] Vinayak Hegde commented on SOLR-16391: -- I will work on _Is Collection Healthcheck En

[jira] [Commented] (SOLR-16707) TestFiltering.testRandomFiltering Caffeine cache async=false IllegalStateException: Recursive update

2023-03-20 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702648#comment-17702648 ] Mikhail Khludnev commented on SOLR-16707: - I think it's what explained in [https

[GitHub] [solr] risdenk commented on pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on PR #1466: URL: https://github.com/apache/solr/pull/1466#issuecomment-1476261941 ugh - [890a6cc](https://github.com/apache/solr/pull/1466/commits/890a6cca9ff0a48022338e1c2448797801a482d1) broke some tests. I need to figure out which change did it. -- This is an automa

[GitHub] [solr] risdenk commented on a diff in pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1142197268 ## solr/modules/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java: ## @@ -422,6 +423,7 @@ private Collection deleteObjects(Collection paths) throws S3Exce

[GitHub] [solr] bszabo97 commented on pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-20 Thread via GitHub
bszabo97 commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1476344039 I have extracted an existing ResponseParser which parsed JSON responses and using that I was able to work around the hack which we talked about in Http2SolrClient, but this raised another c

[jira] [Commented] (SOLR-16707) TestFiltering.testRandomFiltering Caffeine cache async=false IllegalStateException: Recursive update

2023-03-20 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702769#comment-17702769 ] Michael Gibney commented on SOLR-16707: --- The only possible benefit of {{async=false

[jira] [Created] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-16710: - Summary: Suppress certain parameters in the logs Key: SOLR-16710 URL: https://issues.apache.org/jira/browse/SOLR-16710 Project: Solr Issue Type: Improvemen

[jira] [Updated] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16710: -- Description: With KNN vector queries the log records can be large because the vectors themselv

[jira] [Assigned] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein reassigned SOLR-16710: - Assignee: Joel Bernstein > Suppress certain parameters in the logs > ---

[jira] [Updated] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16710: -- Description: With KNN vector queries the log records can be large because the vectors themselv

[GitHub] [solr] risdenk commented on a diff in pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1142246317 ## solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java: ## @@ -1221,7 +1217,7 @@ public Elevation(Set elevatedIds, Set excludedIds, String q

[jira] [Commented] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702785#comment-17702785 ] Kevin Risden commented on SOLR-16710: - SOLR-16582 is semi related about using markers

[GitHub] [solr] risdenk commented on a diff in pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1142287314 ## solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java: ## @@ -1221,7 +1217,7 @@ public Elevation(Set elevatedIds, Set excludedIds, String q

[GitHub] [solr] risdenk commented on a diff in pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1142197268 ## solr/modules/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java: ## @@ -422,6 +423,7 @@ private Collection deleteObjects(Collection paths) throws S3Exce

[GitHub] [solr] risdenk commented on a diff in pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1142293958 ## solr/core/src/java/org/apache/solr/handler/designer/ManagedSchemaDiff.java: ## @@ -215,7 +216,7 @@ protected static Map diff( * @param simpleOrderedMap2 Map to trea

[GitHub] [solr-operator] hmontesdeoca opened a new issue, #534: zk provided pvc

2023-03-20 Thread via GitHub
hmontesdeoca opened a new issue, #534: URL: https://github.com/apache/solr-operator/issues/534 Hello, I am currently using Azure to set up aks clusters utilizing solr-cloud helm charts and the provided zookeeper ensemble. I want to mount zookeeper logs onto a Azure File Share but I c

[GitHub] [solr-operator] Frankkkkk commented on issue #534: zk provided pvc

2023-03-20 Thread via GitHub
Frank commented on issue #534: URL: https://github.com/apache/solr-operator/issues/534#issuecomment-1476486297 You must specify a storage class name. You can list them with `kubectl get sc`. On azure, you could use `azurefile-csi-premium` for example -- This is an automated message fr

[GitHub] [solr-operator] hmontesdeoca commented on issue #534: zk provided pvc

2023-03-20 Thread via GitHub
hmontesdeoca commented on issue #534: URL: https://github.com/apache/solr-operator/issues/534#issuecomment-1476504523 I have specified a storage class name but I would like to mount this pvc to an azure file share. For example, once I create this release via helm I notice it automatically c

[jira] [Commented] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702839#comment-17702839 ] Alex Deparvu commented on SOLR-16710: - not sure if this can provide the param filteri

[jira] [Commented] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702840#comment-17702840 ] Joel Bernstein commented on SOLR-16710: --- [~stillalex] that looks to be exactly what

[GitHub] [solr] HoustonPutman merged pull request #1470: Fix smoke test jar checks & release wizard

2023-03-20 Thread via GitHub
HoustonPutman merged PR #1470: URL: https://github.com/apache/solr/pull/1470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr] HoustonPutman commented on pull request #1436: Add solrbot dependency upgrades to CHANGES for 9.2

2023-03-20 Thread via GitHub
HoustonPutman commented on PR #1436: URL: https://github.com/apache/solr/pull/1436#issuecomment-1476581693 Sorry I missed this somehow, I will merge it before starting the RC! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [solr] risdenk commented on pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on PR #1466: URL: https://github.com/apache/solr/pull/1466#issuecomment-1476588836 Things are looking better but have this reproducing failure: ``` ./gradlew :solr:core:test --tests "org.apache.solr.cloud.NestedShardedAtomicUpdateTest.doNestedInplaceUpdateTest" -

[GitHub] [solr] epugh commented on pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-20 Thread via GitHub
epugh commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1476645596 I wonder if the DistribPackageStore should wait for another time/PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (SOLR-10888) almost self-generating python script(s) to access V2 APIs

2023-03-20 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702860#comment-17702860 ] Eric Pugh commented on SOLR-10888: -- I think this ticket has been obsoleted by the new V2

[jira] [Commented] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702862#comment-17702862 ] Joel Bernstein commented on SOLR-16710: --- https://solr.apache.org/guide/solr/latest/

[jira] [Resolved] (SOLR-16710) Suppress certain parameters in the logs

2023-03-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein resolved SOLR-16710. --- Resolution: Not A Problem > Suppress certain parameters in the logs > ---

[GitHub] [solr] dsmiley commented on pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-20 Thread via GitHub
dsmiley commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1476674958 > I wonder if the DistribPackageStore should wait for another time/PR? +1 Those scope of this issue is just CLI tools so definitely keep this already big PR focused on that please.

[jira] [Created] (SOLR-16711) Seperate tools out of SolrCLI.java into their own files.

2023-03-20 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16711: Summary: Seperate tools out of SolrCLI.java into their own files. Key: SOLR-16711 URL: https://issues.apache.org/jira/browse/SOLR-16711 Project: Solr Issue Type: Imp

[GitHub] [solr] epugh opened a new pull request, #1476: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes

2023-03-20 Thread via GitHub
epugh opened a new pull request, #1476: URL: https://github.com/apache/solr/pull/1476 https://issues.apache.org/jira/browse/SOLR-16711 # Description SolrCLI.java is overwhelming to work with. # Solution Extract tools into their own package. # Tests Please

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-20 Thread via GitHub
dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1142492764 ## solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java: ## @@ -181,14 +189,17 @@ private boolean fetchFileFromNodeAndPersist(String fromNode) {

[GitHub] [solr] epugh merged pull request #1475: Use TimeUnit parameter on builder methods.

2023-03-20 Thread via GitHub
epugh merged PR #1475: URL: https://github.com/apache/solr/pull/1475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] epugh commented on pull request #1353: SOLR-16563 DefaultCollectionSolrClient

2023-03-20 Thread via GitHub
epugh commented on PR #1353: URL: https://github.com/apache/solr/pull/1353#issuecomment-1476728883 I don't think right now I am going to push forward with this approach While it may have value in general, it didn't make it easier for me to migrate the tests away from changing the coll

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-20 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1142529353 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -716,6 +718,12 @@ public void shutdown() throws Exception { try { IOUtil

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-20 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1142529060 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -156,11 +157,12 @@ public class MiniSolrCloudCluster { private final boolean extern

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-20 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1142529996 ## solr/solr-ref-guide/modules/indexing-guide/examples/IndexingNestedDocuments.java: ## @@ -66,89 +69,94 @@ public static SolrClient getSolrClient() { */ public void

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-20 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1142530226 ## solr/core/src/test/org/apache/solr/cloud/TestCloudSearcherWarming.java: ## @@ -311,14 +307,11 @@ public boolean onStateChanged(Set liveNodes, DocCollection collectionSta

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-20 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1142530690 ## solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java: ## @@ -305,8 +306,17 @@ private void doForceLeader(String collectionName, String shard) throws IOEx

[GitHub] [solr] epugh commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-20 Thread via GitHub
epugh commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1142531595 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -332,6 +335,11 @@ public Builder withRetryExpiryTime(long expiryTime, TimeUnit uni

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1476: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes

2023-03-20 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1476: URL: https://github.com/apache/solr/pull/1476#discussion_r1142548264 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -267,7 +155,7 @@ protected abstract void runCloudTool(CloudLegacySolrClient cloudSolrClient, Com

[GitHub] [solr] risdenk commented on pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on PR #1466: URL: https://github.com/apache/solr/pull/1466#issuecomment-1476782916 `NestedShadedAtomicUpdateTest` fixed with 184449a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-10285) Skip LEADER messages when there are leader only shards

2023-03-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702900#comment-17702900 ] David Smiley commented on SOLR-10285: - FYI my colleague [~pierre.salagnac] observed t

[GitHub] [solr] HoustonPutman merged pull request #1436: Add solrbot dependency upgrades to CHANGES for 9.2

2023-03-20 Thread via GitHub
HoustonPutman merged PR #1436: URL: https://github.com/apache/solr/pull/1436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr] risdenk commented on a diff in pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1142606285 ## solr/modules/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java: ## @@ -422,6 +423,7 @@ private Collection deleteObjects(Collection paths) throws S3Exce

[GitHub] [solr] risdenk commented on a diff in pull request #1466: WIP Remove Guava usages

2023-03-20 Thread via GitHub
risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1142606711 ## solr/core/src/java/org/apache/solr/handler/designer/ManagedSchemaDiff.java: ## @@ -215,7 +216,7 @@ protected static Map diff( * @param simpleOrderedMap2 Map to trea

[jira] [Commented] (SOLR-16707) TestFiltering.testRandomFiltering Caffeine cache async=false IllegalStateException: Recursive update

2023-03-20 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702919#comment-17702919 ] Mikhail Khludnev commented on SOLR-16707: - {quote}However, the async cache will n

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1476: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes

2023-03-20 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1476: URL: https://github.com/apache/solr/pull/1476#discussion_r1142689261 ## solr/core/src/java/org/apache/solr/util/cli/ToolBase.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Created] (SOLR-16712) Simplify PerReplicaStates (PRS) logic in DocCollection

2023-03-20 Thread Patson Luk (Jira)
Patson Luk created SOLR-16712: - Summary: Simplify PerReplicaStates (PRS) logic in DocCollection Key: SOLR-16712 URL: https://issues.apache.org/jira/browse/SOLR-16712 Project: Solr Issue Type: Imp

[jira] [Updated] (SOLR-16712) Simplify PerReplicaStates (PRS) logic in DocCollection, replace PrsSupplier with actual PerReplicaStates param

2023-03-20 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk updated SOLR-16712: -- Summary: Simplify PerReplicaStates (PRS) logic in DocCollection, replace PrsSupplier with actual PerRep

[jira] [Updated] (SOLR-16712) Simplify PerReplicaStates (PRS) logic in DocCollection, replace PrsSupplier with actual PerReplicaStates param

2023-03-20 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk updated SOLR-16712: -- Description: The current implementation of PRS requires an extra param to the DocCollection, the `PrsS

[jira] [Updated] (SOLR-16712) Simplify PerReplicaStates (PRS) logic in DocCollection, replace PrsSupplier with actual PerReplicaStates param

2023-03-20 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk updated SOLR-16712: -- Description: The current implementation of PRS requires an extra param to the DocCollection, the `PrsS

[jira] [Resolved] (SOLR-16709) Use TimeUnit methods in conjunction with SolrClient builders

2023-03-20 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16709. -- Fix Version/s: main (10.0) 9.3 Resolution: Fixed > Use TimeUnit methods in co

[GitHub] [solr] patsonluk opened a new pull request, #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

2023-03-20 Thread via GitHub
patsonluk opened a new pull request, #1477: URL: https://github.com/apache/solr/pull/1477 https://issues.apache.org/jira/browse/SOLR-16712 # Description The current implementation of PRS requires an extra param to the DocCollection, the `PrsSupplier`, when `get` is called, woul

[jira] [Commented] (SOLR-16707) TestFiltering.testRandomFiltering Caffeine cache async=false IllegalStateException: Recursive update

2023-03-20 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702995#comment-17702995 ] Michael Gibney commented on SOLR-16707: --- I think that happens externally, [in Solr

[jira] [Commented] (SOLR-16707) TestFiltering.testRandomFiltering Caffeine cache async=false IllegalStateException: Recursive update

2023-03-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702997#comment-17702997 ] David Smiley commented on SOLR-16707: - I could imagine timeAllowed support being adde

[GitHub] [solr] dsmiley commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-03-20 Thread via GitHub
dsmiley commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1142859716 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -332,6 +335,11 @@ public Builder withRetryExpiryTime(long expiryTime, TimeUnit u