sonatype-lift[bot] commented on code in PR #1476: URL: https://github.com/apache/solr/pull/1476#discussion_r1142689261
########## solr/core/src/java/org/apache/solr/util/cli/ToolBase.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.util.cli; + +import java.io.PrintStream; +import org.apache.commons.cli.CommandLine; +import org.apache.solr.util.CLIO; +import org.apache.solr.util.SolrCLI; + +public abstract class ToolBase implements Tool { + protected PrintStream stdout; + protected boolean verbose = false; + + protected ToolBase() { + this(CLIO.getOutStream()); + } + + protected ToolBase(PrintStream stdout) { + this.stdout = stdout; + } + + protected void echoIfVerbose(final String msg, CommandLine cli) { + if (cli.hasOption(SolrCLI.OPTION_VERBOSE.getOpt())) { + echo(msg); + } + } + + protected void echo(final String msg) { + stdout.println(msg); + } + + @Override + public int runTool(CommandLine cli) throws Exception { + verbose = cli.hasOption(SolrCLI.OPTION_VERBOSE.getOpt()); + + int toolExitStatus = 0; + try { + runImpl(cli); + } catch (Exception exc) { + // since this is a CLI, spare the user the stacktrace + String excMsg = exc.getMessage(); + if (excMsg != null) { + CLIO.err("\nERROR: " + excMsg + "\n"); + if (verbose) { + exc.printStackTrace(CLIO.getErrStream()); Review Comment: <picture><img alt="0% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/0/display.svg";></picture> <b>*[INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE](https://find-sec-bugs.github.io/bugs.htm#INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE):</b>* Possible information exposure through an error message --- <details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b> commands</summary> You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings. | **Command** | **Usage** | | ------------- | ------------- | | `@sonatype-lift ignore` | Leave out the above finding from this PR | | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR | | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file | **Note:** When talking to LiftBot, you need to **refresh** the page to see its response. <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details> --- <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b> Was this a good recommendation for you? <sub><small>Answering this survey will not impact your Lift settings.</small></sub> [â[đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=444404662&lift_comment_rating=1) â] - [â[đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=444404662&lift_comment_rating=2) â] - [â[đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=444404662&lift_comment_rating=3) â] - [â[đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=444404662&lift_comment_rating=4) â] - [â[đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=444404662&lift_comment_rating=5) â] ########## solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java: ########## @@ -0,0 +1,1055 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.util.cli; + +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.io.PrintStream; +import java.net.Socket; +import java.net.URL; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.Locale; +import java.util.Map; +import java.util.Optional; +import java.util.Scanner; +import java.util.Set; +import java.util.concurrent.TimeUnit; +import org.apache.commons.cli.CommandLine; +import org.apache.commons.cli.Option; +import org.apache.commons.exec.DefaultExecuteResultHandler; +import org.apache.commons.exec.DefaultExecutor; +import org.apache.commons.exec.ExecuteException; +import org.apache.commons.exec.Executor; +import org.apache.commons.exec.OS; +import org.apache.commons.exec.environment.EnvironmentUtils; +import org.apache.commons.io.FileUtils; +import org.apache.solr.client.solrj.SolrClient; +import org.apache.solr.client.solrj.impl.CloudSolrClient; +import org.apache.solr.client.solrj.impl.HttpSolrClient; +import org.apache.solr.common.SolrException; +import org.apache.solr.util.CLIO; +import org.apache.solr.util.SimplePostTool; +import org.apache.solr.util.SolrCLI; +import org.noggit.CharArr; +import org.noggit.JSONWriter; + +/** Supports an interactive session with the user to launch (or relaunch the -e cloud example) */ +public class RunExampleTool extends ToolBase { + + private static final String PROMPT_FOR_NUMBER = "Please enter %s [%d]: "; + private static final String PROMPT_FOR_NUMBER_IN_RANGE = + "Please enter %s between %d and %d [%d]: "; + private static final String PROMPT_NUMBER_TOO_SMALL = + "%d is too small! " + PROMPT_FOR_NUMBER_IN_RANGE; + private static final String PROMPT_NUMBER_TOO_LARGE = + "%d is too large! " + PROMPT_FOR_NUMBER_IN_RANGE; + + protected InputStream userInput; + protected Executor executor; + protected String script; + protected File serverDir; + protected File exampleDir; + protected String urlScheme; + + /** Default constructor used by the framework when running as a command-line application. */ + public RunExampleTool() { + this(null, System.in, CLIO.getOutStream()); + } + + public RunExampleTool(Executor executor, InputStream userInput, PrintStream stdout) { + super(stdout); + this.executor = (executor != null) ? executor : new DefaultExecutor(); + this.userInput = userInput; + } + + @Override + public String getName() { + return "run_example"; + } + + @Override + public Option[] getOptions() { + return new Option[] { + Option.builder("noprompt") + .required(false) + .desc( + "Don't prompt for input; accept all defaults when running examples that accept user input.") + .build(), + Option.builder("e") + .argName("NAME") + .hasArg() + .required(true) + .desc("Name of the example to launch, one of: cloud, techproducts, schemaless, films.") + .longOpt("example") + .build(), + Option.builder("script") + .argName("PATH") + .hasArg() + .required(false) + .desc("Path to the bin/solr script.") + .build(), + Option.builder("d") + .argName("DIR") + .hasArg() + .required(true) + .desc("Path to the Solr server directory.") + .longOpt("serverDir") + .build(), + Option.builder("force") + .argName("FORCE") + .desc("Force option in case Solr is run as root.") + .build(), + Option.builder("exampleDir") + .argName("DIR") + .hasArg() + .required(false) + .desc( + "Path to the Solr example directory; if not provided, ${serverDir}/../example is expected to exist.") + .build(), + Option.builder("urlScheme") + .argName("SCHEME") + .hasArg() + .required(false) + .desc("Solr URL scheme: http or https, defaults to http if not specified.") + .build(), + Option.builder("p") + .argName("PORT") + .hasArg() + .required(false) + .desc("Specify the port to start the Solr HTTP listener on; default is 8983.") + .longOpt("port") + .build(), + Option.builder("h") + .argName("HOSTNAME") + .hasArg() + .required(false) + .desc("Specify the hostname for this Solr instance.") + .longOpt("host") + .build(), + Option.builder("z") + .argName("ZKHOST") + .hasArg() + .required(false) + .desc("ZooKeeper connection string; only used when running in SolrCloud mode using -c.") + .longOpt("zkhost") + .build(), + Option.builder("c") + .required(false) + .desc( + "Start Solr in SolrCloud mode; if -z not supplied, an embedded ZooKeeper instance is started on Solr port+1000, such as 9983 if Solr is bound to 8983.") + .longOpt("cloud") + .build(), + Option.builder("m") + .argName("MEM") + .hasArg() + .required(false) + .desc( + "Sets the min (-Xms) and max (-Xmx) heap size for the JVM, such as: -m 4g results in: -Xms4g -Xmx4g; by default, this script sets the heap size to 512m.") + .longOpt("memory") + .build(), + Option.builder("a") + .argName("OPTS") + .hasArg() + .required(false) + .desc("Additional options to be passed to the JVM when starting example Solr server(s).") + .longOpt("addlopts") + .build() + }; + } + + @Override + public void runImpl(CommandLine cli) throws Exception { + this.urlScheme = cli.getOptionValue("urlScheme", "http"); + + serverDir = new File(cli.getOptionValue("serverDir")); + if (!serverDir.isDirectory()) + throw new IllegalArgumentException( + "Value of -serverDir option is invalid! " + + serverDir.getAbsolutePath() + + " is not a directory!"); + + script = cli.getOptionValue("script"); + if (script != null) { + if (!(new File(script)).isFile()) + throw new IllegalArgumentException( + "Value of -script option is invalid! " + script + " not found"); + } else { + File scriptFile = new File(serverDir.getParentFile(), "bin/solr"); + if (scriptFile.isFile()) { + script = scriptFile.getAbsolutePath(); + } else { + scriptFile = new File(serverDir.getParentFile(), "bin/solr.cmd"); + if (scriptFile.isFile()) { + script = scriptFile.getAbsolutePath(); + } else { + throw new IllegalArgumentException( + "Cannot locate the bin/solr script! Please pass -script to this application."); + } + } + } + + exampleDir = + (cli.hasOption("exampleDir")) + ? new File(cli.getOptionValue("exampleDir")) + : new File(serverDir.getParent(), "example"); + if (!exampleDir.isDirectory()) + throw new IllegalArgumentException( + "Value of -exampleDir option is invalid! " + + exampleDir.getAbsolutePath() + + " is not a directory!"); + + echoIfVerbose( + "Running with\nserverDir=" + + serverDir.getAbsolutePath() + + ",\nexampleDir=" + + exampleDir.getAbsolutePath() + + "\nscript=" + + script, + cli); + + String exampleType = cli.getOptionValue("example"); + if ("cloud".equals(exampleType)) { + runCloudExample(cli); + } else if ("techproducts".equals(exampleType) + || "schemaless".equals(exampleType) + || "films".equals(exampleType)) { + runExample(cli, exampleType); + } else { + throw new IllegalArgumentException( + "Unsupported example " + + exampleType + + "! Please choose one of: cloud, schemaless, techproducts, or films"); + } + } + + protected void runExample(CommandLine cli, String exampleName) throws Exception { + File exDir = setupExampleDir(serverDir, exampleDir, exampleName); + String collectionName = "schemaless".equals(exampleName) ? "gettingstarted" : exampleName; + String configSet = + "techproducts".equals(exampleName) ? "sample_techproducts_configs" : "_default"; + + boolean isCloudMode = cli.hasOption('c'); + String zkHost = cli.getOptionValue('z'); + int port = Integer.parseInt(cli.getOptionValue('p', "8983")); + Map<String, Object> nodeStatus = + startSolr(new File(exDir, "solr"), isCloudMode, cli, port, zkHost, 30); + + // invoke the CreateTool + File configsetsDir = new File(serverDir, "solr/configsets"); + + String solrUrl = (String) nodeStatus.get("baseUrl"); + + // safe check if core / collection already exists + boolean alreadyExists = false; + if (nodeStatus.get("cloud") != null) { + String collectionListUrl = solrUrl + "/admin/collections?action=list"; + if (SolrCLI.safeCheckCollectionExists(collectionListUrl, collectionName)) { + alreadyExists = true; + echo( + "\nWARNING: Collection '" + + collectionName + + "' already exists!\nChecked collection existence using Collections API command:\n" + + collectionListUrl + + "\n"); + } + } else { + String coreName = collectionName; + String coreStatusUrl = solrUrl + "/admin/cores?action=STATUS&core=" + coreName; + if (SolrCLI.safeCheckCoreExists(coreStatusUrl, coreName)) { + alreadyExists = true; + echo( + "\nWARNING: Core '" + + coreName + + "' already exists!\nChecked core existence using Core API command:\n" + + coreStatusUrl + + "\n"); + } + } + + if (!alreadyExists) { + String[] createArgs = + new String[] { + "-name", collectionName, + "-shards", "1", + "-replicationFactor", "1", + "-confname", collectionName, + "-confdir", configSet, + "-configsetsDir", configsetsDir.getAbsolutePath(), + "-solrUrl", solrUrl + }; + CreateTool createTool = new CreateTool(stdout); + int createCode = + createTool.runTool( + SolrCLI.processCommandLineArgs( + createTool.getName(), + SolrCLI.joinCommonAndToolOptions(createTool.getOptions()), + createArgs)); + if (createCode != 0) + throw new Exception( + "Failed to create " + collectionName + " using command: " + Arrays.asList(createArgs)); + } + + if ("techproducts".equals(exampleName) && !alreadyExists) { + + File exampledocsDir = new File(exampleDir, "exampledocs"); + if (!exampledocsDir.isDirectory()) { + File readOnlyExampleDir = new File(serverDir.getParentFile(), "example"); + if (readOnlyExampleDir.isDirectory()) { + exampledocsDir = new File(readOnlyExampleDir, "exampledocs"); + } + } + + if (exampledocsDir.isDirectory()) { + String updateUrl = String.format(Locale.ROOT, "%s/%s/update", solrUrl, collectionName); + echo("Indexing tech product example docs from " + exampledocsDir.getAbsolutePath()); + + String currentPropVal = System.getProperty("url"); + System.setProperty("url", updateUrl); + SimplePostTool.main(new String[] {exampledocsDir.getAbsolutePath() + "/*.xml"}); + if (currentPropVal != null) { + System.setProperty("url", currentPropVal); // reset + } else { + System.clearProperty("url"); + } + } else { + echo( + "exampledocs directory not found, skipping indexing step for the techproducts example"); + } + } else if ("films".equals(exampleName) && !alreadyExists) { + SolrClient solrClient = new HttpSolrClient.Builder(solrUrl).build(); + + echo("Adding dense vector field type to films schema \"_default\""); + try { + SolrCLI.postJsonToSolr( + solrClient, + "/" + collectionName + "/schema", + "{\n" + + " \"add-field-type\" : {\n" + + " \"name\":\"knn_vector_10\",\n" + + " \"class\":\"solr.DenseVectorField\",\n" + + " \"vectorDimension\":10,\n" + + " \"similarityFunction\":cosine\n" + + " \"knnAlgorithm\":hnsw\n" + + " }\n" + + " }"); + } catch (Exception ex) { + throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, ex); + } + + echo( + "Adding name, initial_release_date, and film_vector fields to films schema \"_default\""); + try { + SolrCLI.postJsonToSolr( + solrClient, + "/" + collectionName + "/schema", + "{\n" + + " \"add-field\" : {\n" + + " \"name\":\"name\",\n" + + " \"type\":\"text_general\",\n" + + " \"multiValued\":false,\n" + + " \"stored\":true\n" + + " },\n" + + " \"add-field\" : {\n" + + " \"name\":\"initial_release_date\",\n" + + " \"type\":\"pdate\",\n" + + " \"stored\":true\n" + + " },\n" + + " \"add-field\" : {\n" + + " \"name\":\"film_vector\",\n" + + " \"type\":\"knn_vector_10\",\n" + + " \"indexed\":true\n" + + " \"stored\":true\n" + + " }\n" + + " }"); + } catch (Exception ex) { + throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, ex); + } + + echo("Adding paramsets \"algo\" and \"algo_b\" to films configuration for relevancy tuning"); + try { + SolrCLI.postJsonToSolr( + solrClient, + "/" + collectionName + "/config/params", + "{\n" + + " \"set\": {\n" + + " \"algo_a\":{\n" + + " \"defType\":\"dismax\",\n" + + " \"qf\":\"name\"\n" + + " }\n" + + " },\n" + + " \"set\": {\n" + + " \"algo_b\":{\n" + + " \"defType\":\"dismax\",\n" + + " \"qf\":\"name\",\n" + + " \"mm\":\"100%\"\n" + + " }\n" + + " }\n" + + " }\n"); + } catch (Exception ex) { + throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, ex); + } + + File filmsJsonFile = new File(exampleDir, "films/films.json"); + String updateUrl = String.format(Locale.ROOT, "%s/%s/update/json", solrUrl, collectionName); + echo("Indexing films example docs from " + filmsJsonFile.getAbsolutePath()); + String currentPropVal = System.getProperty("url"); + System.setProperty("url", updateUrl); + SimplePostTool.main(new String[] {filmsJsonFile.getAbsolutePath()}); + if (currentPropVal != null) { + System.setProperty("url", currentPropVal); // reset + } else { + System.clearProperty("url"); + } + } + + echo( + "\nSolr " + + exampleName + + " example launched successfully. Direct your Web browser to " + + solrUrl + + " to visit the Solr Admin UI"); + } + + protected void runCloudExample(CommandLine cli) throws Exception { + + boolean prompt = !cli.hasOption("noprompt"); + int numNodes = 2; + int[] cloudPorts = new int[] {8983, 7574, 8984, 7575}; + File cloudDir = new File(exampleDir, "cloud"); + if (!cloudDir.isDirectory()) { + cloudDir.mkdir(); + } + + echo("\nWelcome to the SolrCloud example!\n"); + + Scanner readInput = prompt ? new Scanner(userInput, StandardCharsets.UTF_8.name()) : null; + if (prompt) { + echo( + "This interactive session will help you launch a SolrCloud cluster on your local workstation."); + + // get the number of nodes to start + numNodes = + promptForInt( + readInput, + "To begin, how many Solr nodes would you like to run in your local cluster? (specify 1-4 nodes) [2]: ", + "a number", + numNodes, + 1, + 4); + + echo("Ok, let's start up " + numNodes + " Solr nodes for your example SolrCloud cluster."); + + // get the ports for each port + for (int n = 0; n < numNodes; n++) { + String promptMsg = + String.format( + Locale.ROOT, "Please enter the port for node%d [%d]: ", (n + 1), cloudPorts[n]); + int port = promptForPort(readInput, n + 1, promptMsg, cloudPorts[n]); + while (!isPortAvailable(port)) { + port = + promptForPort( + readInput, + n + 1, + "Oops! Looks like port " + + port + + " is already being used by another process. Please choose a different port.", + cloudPorts[n]); + } + + cloudPorts[n] = port; + echoIfVerbose("Using port " + port + " for node " + (n + 1), cli); + } + } else { + echo("Starting up " + numNodes + " Solr nodes for your example SolrCloud cluster.\n"); + } + + // setup a unique solr.solr.home directory for each node + File node1Dir = setupExampleDir(serverDir, cloudDir, "node1"); + for (int n = 2; n <= numNodes; n++) { + File nodeNDir = new File(cloudDir, "node" + n); + if (!nodeNDir.isDirectory()) { + echo("Cloning " + node1Dir.getAbsolutePath() + " into\n " + nodeNDir.getAbsolutePath()); + FileUtils.copyDirectory(node1Dir, nodeNDir); + } else { + echo(nodeNDir.getAbsolutePath() + " already exists."); + } + } + + // deal with extra args passed to the script to run the example + String zkHost = cli.getOptionValue('z'); + + // start the first node (most likely with embedded ZK) + Map<String, Object> nodeStatus = + startSolr(new File(node1Dir, "solr"), true, cli, cloudPorts[0], zkHost, 30); + + if (zkHost == null) { + @SuppressWarnings("unchecked") + Map<String, Object> cloudStatus = (Map<String, Object>) nodeStatus.get("cloud"); + if (cloudStatus != null) { + String zookeeper = (String) cloudStatus.get("ZooKeeper"); + if (zookeeper != null) zkHost = zookeeper; + } + if (zkHost == null) + throw new Exception("Could not get the ZooKeeper connection string for node1!"); + } + + if (numNodes > 1) { + // start the other nodes + for (int n = 1; n < numNodes; n++) + startSolr( + new File(cloudDir, "node" + (n + 1) + "/solr"), true, cli, cloudPorts[n], zkHost, 30); + } + + String solrUrl = (String) nodeStatus.get("baseUrl"); + if (solrUrl.endsWith("/")) solrUrl = solrUrl.substring(0, solrUrl.length() - 1); + + // wait until live nodes == numNodes + waitToSeeLiveNodes(10 /* max wait */, zkHost, numNodes); + + // create the collection + String collectionName = createCloudExampleCollection(numNodes, readInput, prompt, solrUrl); + + // update the config to enable soft auto-commit + echo("\nEnabling auto soft-commits with maxTime 3 secs using the Config API"); + setCollectionConfigProperty( + solrUrl, collectionName, "updateHandler.autoSoftCommit.maxTime", "3000"); + + echo("\n\nSolrCloud example running, please visit: " + solrUrl + " \n"); + } + + protected void setCollectionConfigProperty( + String solrUrl, String collectionName, String propName, String propValue) { + ConfigTool configTool = new ConfigTool(stdout); + String[] configArgs = + new String[] { + "-collection", + collectionName, + "-property", + propName, + "-value", + propValue, + "-solrUrl", + solrUrl + }; + + // let's not fail if we get this far ... just report error and finish up + try { + configTool.runTool( + SolrCLI.processCommandLineArgs( + configTool.getName(), + SolrCLI.joinCommonAndToolOptions(configTool.getOptions()), + configArgs)); + } catch (Exception exc) { + CLIO.err("Failed to update '" + propName + "' property due to: " + exc); + } + } + + protected void waitToSeeLiveNodes(int maxWaitSecs, String zkHost, int numNodes) { + try (CloudSolrClient cloudClient = + new CloudSolrClient.Builder(Collections.singletonList(zkHost), Optional.empty()).build()) { + + cloudClient.connect(); + Set<String> liveNodes = cloudClient.getClusterState().getLiveNodes(); + int numLiveNodes = (liveNodes != null) ? liveNodes.size() : 0; + long timeout = + System.nanoTime() + TimeUnit.NANOSECONDS.convert(maxWaitSecs, TimeUnit.SECONDS); + while (System.nanoTime() < timeout && numLiveNodes < numNodes) { + echo( + "\nWaiting up to " + + maxWaitSecs + + " seconds to see " + + (numNodes - numLiveNodes) + + " more nodes join the SolrCloud cluster ..."); + try { + Thread.sleep(2000); + } catch (InterruptedException ie) { + Thread.interrupted(); + } + liveNodes = cloudClient.getClusterState().getLiveNodes(); + numLiveNodes = (liveNodes != null) ? liveNodes.size() : 0; + } + if (numLiveNodes < numNodes) { + echo( + "\nWARNING: Only " + + numLiveNodes + + " of " + + numNodes + + " are active in the cluster after " + + maxWaitSecs + + " seconds! Please check the solr.log for each node to look for errors.\n"); + } + } catch (Exception exc) { + CLIO.err("Failed to see if " + numNodes + " joined the SolrCloud cluster due to: " + exc); + } + } + + protected Map<String, Object> startSolr( + File solrHomeDir, + boolean cloudMode, + CommandLine cli, + int port, + String zkHost, + int maxWaitSecs) + throws Exception { + + String extraArgs = readExtraArgs(cli.getArgs()); + + String host = cli.getOptionValue('h'); + String memory = cli.getOptionValue('m'); + + String hostArg = (host != null && !"localhost".equals(host)) ? " -h " + host : ""; + String zkHostArg = (zkHost != null) ? " -z " + zkHost : ""; + String memArg = (memory != null) ? " -m " + memory : ""; + String cloudModeArg = cloudMode ? "-cloud " : ""; + String forceArg = cli.hasOption("force") ? " -force" : ""; + + String addlOpts = cli.getOptionValue('a'); + String addlOptsArg = (addlOpts != null) ? " -a \"" + addlOpts + "\"" : ""; + + File cwd = new File(System.getProperty("user.dir")); + File binDir = (new File(script)).getParentFile(); + + boolean isWindows = (OS.isFamilyDOS() || OS.isFamilyWin9x() || OS.isFamilyWindows()); + String callScript = (!isWindows && cwd.equals(binDir.getParentFile())) ? "bin/solr" : script; + + String cwdPath = cwd.getAbsolutePath(); + String solrHome = solrHomeDir.getAbsolutePath(); + + // don't display a huge path for solr home if it is relative to the cwd + if (!isWindows && cwdPath.length() > 1 && solrHome.startsWith(cwdPath)) + solrHome = solrHome.substring(cwdPath.length() + 1); + + String startCmd = + String.format( + Locale.ROOT, + "\"%s\" start %s -p %d -s \"%s\" %s %s %s %s %s %s", + callScript, + cloudModeArg, + port, + solrHome, + hostArg, + zkHostArg, + memArg, + forceArg, + extraArgs, + addlOptsArg); + startCmd = startCmd.replaceAll("\\s+", " ").trim(); // for pretty printing + + echo("\nStarting up Solr on port " + port + " using command:"); + echo(startCmd + "\n"); + + String solrUrl = + String.format( + Locale.ROOT, "%s://%s:%d/solr", urlScheme, (host != null ? host : "localhost"), port); + + Map<String, Object> nodeStatus = checkPortConflict(solrUrl, solrHomeDir, port); + if (nodeStatus != null) + return nodeStatus; // the server they are trying to start is already running + + int code = 0; + if (isWindows) { + // On Windows, the execution doesn't return, so we have to execute async + // and when calling the script, it seems to be inheriting the environment that launched this + // app, so we have to prune out env vars that may cause issues + Map<String, String> startEnv = new HashMap<>(); + Map<String, String> procEnv = EnvironmentUtils.getProcEnvironment(); + if (procEnv != null) { + for (Map.Entry<String, String> entry : procEnv.entrySet()) { + String envVar = entry.getKey(); + String envVarVal = entry.getValue(); + if (envVarVal != null && !"EXAMPLE".equals(envVar) && !envVar.startsWith("SOLR_")) { + startEnv.put(envVar, envVarVal); + } + } + } + DefaultExecuteResultHandler handler = new DefaultExecuteResultHandler(); + executor.execute(org.apache.commons.exec.CommandLine.parse(startCmd), startEnv, handler); + + // wait for execution. + try { + handler.waitFor(3000); + } catch (InterruptedException ie) { + // safe to ignore ... + Thread.interrupted(); + } + if (handler.hasResult() && handler.getExitValue() != 0) { + throw new Exception( + "Failed to start Solr using command: " + + startCmd + + " Exception : " + + handler.getException()); + } + } else { + try { + code = executor.execute(org.apache.commons.exec.CommandLine.parse(startCmd)); + } catch (ExecuteException e) { + throw new Exception( + "Failed to start Solr using command: " + startCmd + " Exception : " + e); + } + } + if (code != 0) throw new Exception("Failed to start Solr using command: " + startCmd); + + return getNodeStatus(solrUrl, maxWaitSecs); + } + + protected Map<String, Object> checkPortConflict(String solrUrl, File solrHomeDir, int port) { + // quickly check if the port is in use + if (isPortAvailable(port)) return null; // not in use ... try to start + + Map<String, Object> nodeStatus = null; + try { + nodeStatus = (new StatusTool()).getStatus(solrUrl); + } catch (Exception ignore) { + /* just trying to determine if this example is already running. */ + } + + if (nodeStatus != null) { + String solr_home = (String) nodeStatus.get("solr_home"); + if (solr_home != null) { + String solrHomePath = solrHomeDir.getAbsolutePath(); + if (!solrHomePath.endsWith("/")) solrHomePath += "/"; + if (!solr_home.endsWith("/")) solr_home += "/"; + + if (solrHomePath.equals(solr_home)) { + CharArr arr = new CharArr(); + new JSONWriter(arr, 2).write(nodeStatus); + echo( + "Solr is already setup and running on port " + + port + + " with status:\n" + + arr.toString()); + echo( + "\nIf this is not the example node you are trying to start, please choose a different port."); + nodeStatus.put("baseUrl", solrUrl); + return nodeStatus; + } + } + } + + throw new IllegalStateException("Port " + port + " is already being used by another process."); + } + + protected String readExtraArgs(String[] extraArgsArr) { + String extraArgs = ""; + if (extraArgsArr != null && extraArgsArr.length > 0) { + StringBuilder sb = new StringBuilder(); + int app = 0; + for (int e = 0; e < extraArgsArr.length; e++) { + String arg = extraArgsArr[e]; + if ("e".equals(arg) || "example".equals(arg)) { + e++; // skip over the example arg + continue; + } + + if (app > 0) sb.append(" "); + sb.append(arg); + ++app; + } + extraArgs = sb.toString().trim(); + } + return extraArgs; + } + + protected String createCloudExampleCollection( + int numNodes, Scanner readInput, boolean prompt, String solrUrl) throws Exception { + // yay! numNodes SolrCloud nodes running + int numShards = 2; + int replicationFactor = 2; + String cloudConfig = "_default"; + String collectionName = "gettingstarted"; + + File configsetsDir = new File(serverDir, "solr/configsets"); + String collectionListUrl = solrUrl + "/admin/collections?action=list"; + + if (prompt) { + echo( + "\nNow let's create a new collection for indexing documents in your " + + numNodes + + "-node cluster."); + + while (true) { + collectionName = + prompt( + readInput, + "Please provide a name for your new collection: [" + collectionName + "] ", + collectionName); + + // Test for existence and then prompt to either create another collection or skip the + // creation step + if (SolrCLI.safeCheckCollectionExists(collectionListUrl, collectionName)) { + echo("\nCollection '" + collectionName + "' already exists!"); + int oneOrTwo = + promptForInt( + readInput, + "Do you want to re-use the existing collection or create a new one? Enter 1 to reuse, 2 to create new [1]: ", + "a 1 or 2", + 1, + 1, + 2); + if (oneOrTwo == 1) { + return collectionName; + } else { + continue; + } + } else { + break; // user selected a collection that doesn't exist ... proceed on + } + } + + numShards = + promptForInt( + readInput, + "How many shards would you like to split " + collectionName + " into? [2]", + "a shard count", + 2, + 1, + 4); + + replicationFactor = + promptForInt( + readInput, + "How many replicas per shard would you like to create? [2] ", + "a replication factor", + 2, + 1, + 4); + + echo( + "Please choose a configuration for the " + + collectionName + + " collection, available options are:"); + String validConfigs = "_default or sample_techproducts_configs [" + cloudConfig + "] "; + cloudConfig = prompt(readInput, validConfigs, cloudConfig); + + // validate the cloudConfig name + while (!isValidConfig(configsetsDir, cloudConfig)) { + echo( + cloudConfig + + " is not a valid configuration directory! Please choose a configuration for the " + + collectionName + + " collection, available options are:"); + cloudConfig = prompt(readInput, validConfigs, cloudConfig); + } + } else { + // must verify if default collection exists + if (SolrCLI.safeCheckCollectionExists(collectionListUrl, collectionName)) { + echo( + "\nCollection '" + + collectionName + + "' already exists! Skipping collection creation step."); + return collectionName; + } + } + + // invoke the CreateCollectionTool + String[] createArgs = + new String[] { + "-name", collectionName, + "-shards", String.valueOf(numShards), + "-replicationFactor", String.valueOf(replicationFactor), + "-confname", collectionName, + "-confdir", cloudConfig, + "-configsetsDir", configsetsDir.getAbsolutePath(), + "-solrUrl", solrUrl + }; + + CreateCollectionTool createCollectionTool = new CreateCollectionTool(stdout); + int createCode = + createCollectionTool.runTool( + SolrCLI.processCommandLineArgs( + createCollectionTool.getName(), + SolrCLI.joinCommonAndToolOptions(createCollectionTool.getOptions()), + createArgs)); + + if (createCode != 0) + throw new Exception( + "Failed to create collection using command: " + Arrays.asList(createArgs)); + + return collectionName; + } + + protected boolean isValidConfig(File configsetsDir, String config) { + File configDir = new File(configsetsDir, config); + if (configDir.isDirectory()) return true; + + // not a built-in configset ... maybe it's a custom directory? + configDir = new File(config); + return configDir.isDirectory(); + } + + protected Map<String, Object> getNodeStatus(String solrUrl, int maxWaitSecs) throws Exception { + StatusTool statusTool = new StatusTool(); + if (verbose) echo("\nChecking status of Solr at " + solrUrl + " ..."); + + URL solrURL = new URL(solrUrl); + Map<String, Object> nodeStatus = statusTool.waitToSeeSolrUp(solrUrl, maxWaitSecs); + nodeStatus.put("baseUrl", solrUrl); + CharArr arr = new CharArr(); + new JSONWriter(arr, 2).write(nodeStatus); + String mode = (nodeStatus.get("cloud") != null) ? "cloud" : "standalone"; + if (verbose) + echo( + "\nSolr is running on " + + solrURL.getPort() + + " in " + + mode + + " mode with status:\n" + + arr); + + return nodeStatus; + } + + protected File setupExampleDir(File serverDir, File exampleParentDir, String dirName) + throws IOException { + File solrXml = new File(serverDir, "solr/solr.xml"); + if (!solrXml.isFile()) + throw new IllegalArgumentException( + "Value of -serverDir option is invalid! " + solrXml.getAbsolutePath() + " not found!"); + + File zooCfg = new File(serverDir, "solr/zoo.cfg"); + if (!zooCfg.isFile()) + throw new IllegalArgumentException( + "Value of -serverDir option is invalid! " + zooCfg.getAbsolutePath() + " not found!"); + + File solrHomeDir = new File(exampleParentDir, dirName + "/solr"); + if (!solrHomeDir.isDirectory()) { + echo("Creating Solr home directory " + solrHomeDir); + solrHomeDir.mkdirs(); + } else { + echo("Solr home directory " + solrHomeDir.getAbsolutePath() + " already exists."); + } + + copyIfNeeded(solrXml, new File(solrHomeDir, "solr.xml")); + copyIfNeeded(zooCfg, new File(solrHomeDir, "zoo.cfg")); + + return solrHomeDir.getParentFile(); + } + + protected void copyIfNeeded(File src, File dest) throws IOException { + if (!dest.isFile()) FileUtils.copyFile(src, dest); + + if (!dest.isFile()) + throw new IllegalStateException("Required file " + dest.getAbsolutePath() + " not found!"); + } + + protected boolean isPortAvailable(int port) { + Socket s = null; + try { + s = new Socket("localhost", port); Review Comment: <b>*[UNENCRYPTED_SOCKET](https://find-sec-bugs.github.io/bugs.htm#UNENCRYPTED_SOCKET):</b>* Unencrypted socket to org.apache.solr.util.cli.RunExampleTool (instead of SSLSocket) --- <details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b> commands</summary> You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings. | **Command** | **Usage** | | ------------- | ------------- | | `@sonatype-lift ignore` | Leave out the above finding from this PR | | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR | | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file | **Note:** When talking to LiftBot, you need to **refresh** the page to see its response. <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details> --- <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b> Was this a good recommendation for you? <sub><small>Answering this survey will not impact your Lift settings.</small></sub> [â[đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=444404741&lift_comment_rating=1) â] - [â[đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=444404741&lift_comment_rating=2) â] - [â[đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=444404741&lift_comment_rating=3) â] - [â[đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=444404741&lift_comment_rating=4) â] - [â[đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=444404741&lift_comment_rating=5) â] ########## solr/core/src/java/org/apache/solr/util/cli/ConfigSetDownloadTool.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.util.cli; + +import java.io.PrintStream; +import java.lang.invoke.MethodHandles; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.concurrent.TimeUnit; +import org.apache.commons.cli.CommandLine; +import org.apache.commons.cli.Option; +import org.apache.solr.common.cloud.SolrZkClient; +import org.apache.solr.util.CLIO; +import org.apache.solr.util.SolrCLI; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class ConfigSetDownloadTool extends ToolBase { + + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + public ConfigSetDownloadTool() { + this(CLIO.getOutStream()); + } + + public ConfigSetDownloadTool(PrintStream stdout) { + super(stdout); + } + + @Override + public Option[] getOptions() { + return new Option[] { + Option.builder("confname") + .argName("confname") + .hasArg() + .required(true) + .desc("Configset name in ZooKeeper.") + .build(), + Option.builder("confdir") + .argName("confdir") + .hasArg() + .required(true) + .desc("Local directory with configs.") + .build(), + SolrCLI.OPTION_ZKHOST, + SolrCLI.OPTION_VERBOSE + }; + } + + @Override + public String getName() { + return "downconfig"; + } + + @Override + public void runImpl(CommandLine cli) throws Exception { + SolrCLI.raiseLogLevelUnlessVerbose(cli); + String zkHost = SolrCLI.getZkHost(cli); + if (zkHost == null) { + throw new IllegalStateException( + "Solr at " + + cli.getOptionValue("solrUrl") + + " is running in standalone server mode, downconfig can only be used when running in SolrCloud mode.\n"); + } + + try (SolrZkClient zkClient = + new SolrZkClient.Builder() + .withUrl(zkHost) + .withTimeout(30000, TimeUnit.MILLISECONDS) + .build()) { + echoIfVerbose("\nConnecting to ZooKeeper at " + zkHost + " ...", cli); + String confName = cli.getOptionValue("confname"); + String confDir = cli.getOptionValue("confdir"); + Path configSetPath = Paths.get(confDir); + // we try to be nice about having the "conf" in the directory, and we create it if it's not + // there. + if (!configSetPath.endsWith("/conf")) { + configSetPath = Paths.get(configSetPath.toString(), "conf"); Review Comment: <picture><img alt="5% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/5/display.svg";></picture> <b>*[PATH_TRAVERSAL_IN](https://find-sec-bugs.github.io/bugs.htm#PATH_TRAVERSAL_IN):</b>* This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input ââ <b>24 similar findings have been found in this PR</b> <details><summary>đ Expand here to view all instances of this finding</summary><br/> <div align=\"center\"> | **File Path** | **Line Number** | | ------------- | ------------- | | solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java | [212](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java#L212) | | solr/core/src/java/org/apache/solr/util/cli/CreateCoreTool.java | [94](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/CreateCoreTool.java#L94) | | solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java | [932](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java#L932) | | solr/core/src/java/org/apache/solr/util/cli/CreateCoreTool.java | [91](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/CreateCoreTool.java#L91) | | solr/core/src/java/org/apache/solr/util/cli/AuthTool.java | [441](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/AuthTool.java#L441) | | solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java | [628](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java#L628) | | solr/core/src/java/org/apache/solr/util/cli/ConfigSetDownloadTool.java | [89](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/ConfigSetDownloadTool.java#L89) | | solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java | [182](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java#L182) | | solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java | [890](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java#L890) | | solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java | [211](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/RunExampleTool.java#L211) | <p> Showing <b>10</b> of <b> 24 </b> findings. <a href="https://lift.sonatype.com/results/github.com/apache/solr/01GW0BKH5XQMSNX4PER7VH8BBD?t=FindSecBugs|PATH_TRAVERSAL_IN" target="_blank">Visit the Lift Web Console</a> to see all.</p></div></details> --- <details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b> commands</summary> You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings. | **Command** | **Usage** | | ------------- | ------------- | | `@sonatype-lift ignore` | Leave out the above finding from this PR | | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR | | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file | **Note:** When talking to LiftBot, you need to **refresh** the page to see its response. <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details> --- <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b> Was this a good recommendation for you? <sub><small>Answering this survey will not impact your Lift settings.</small></sub> [â[đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=444404507&lift_comment_rating=1) â] - [â[đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=444404507&lift_comment_rating=2) â] - [â[đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=444404507&lift_comment_rating=3) â] - [â[đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=444404507&lift_comment_rating=4) â] - [â[đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=444404507&lift_comment_rating=5) â] ########## solr/core/src/java/org/apache/solr/util/cli/StatusTool.java: ########## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.util.cli; + +import java.io.PrintStream; +import java.net.URL; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; +import javax.net.ssl.SSLPeerUnverifiedException; +import org.apache.commons.cli.CommandLine; +import org.apache.commons.cli.Option; +import org.apache.http.client.HttpClient; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.solr.util.CLIO; +import org.apache.solr.util.SolrCLI; +import org.noggit.CharArr; +import org.noggit.JSONWriter; + +/** Get the status of a Solr server. */ +public class StatusTool extends ToolBase { + + public StatusTool() { + this(CLIO.getOutStream()); + } + + public StatusTool(PrintStream stdout) { + super(stdout); + } + + @Override + public String getName() { + return "status"; + } + + @Override + public Option[] getOptions() { + return new Option[] { + Option.builder("solr") + .argName("URL") + .hasArg() + .required(false) + .desc( + "Address of the Solr Web application, defaults to: " + SolrCLI.DEFAULT_SOLR_URL + '.') + .build(), + Option.builder("maxWaitSecs") + .argName("SECS") + .hasArg() + .required(false) + .desc("Wait up to the specified number of seconds to see Solr running.") + .build() + }; + } + + @Override + public void runImpl(CommandLine cli) throws Exception { + int maxWaitSecs = Integer.parseInt(cli.getOptionValue("maxWaitSecs", "0")); + String solrUrl = cli.getOptionValue("solr", SolrCLI.DEFAULT_SOLR_URL); + if (maxWaitSecs > 0) { + int solrPort = (new URL(solrUrl)).getPort(); + echo("Waiting up to " + maxWaitSecs + " seconds to see Solr running on port " + solrPort); + try { + waitToSeeSolrUp(solrUrl, maxWaitSecs); + echo("Started Solr server on port " + solrPort + ". Happy searching!"); + } catch (TimeoutException timeout) { + throw new Exception( + "Solr at " + solrUrl + " did not come online within " + maxWaitSecs + " seconds!"); + } + } else { + try { + CharArr arr = new CharArr(); + new JSONWriter(arr, 2).write(getStatus(solrUrl)); + echo(arr.toString()); + } catch (Exception exc) { + if (SolrCLI.exceptionIsAuthRelated(exc)) { + throw exc; + } + if (SolrCLI.checkCommunicationError(exc)) { + // this is not actually an error from the tool as it's ok if Solr is not online. + CLIO.err("Solr at " + solrUrl + " not online."); + } else { + throw new Exception( + "Failed to get system information from " + solrUrl + " due to: " + exc); + } + } + } + } + + public Map<String, Object> waitToSeeSolrUp(String solrUrl, int maxWaitSecs) throws Exception { + long timeout = System.nanoTime() + TimeUnit.NANOSECONDS.convert(maxWaitSecs, TimeUnit.SECONDS); + while (System.nanoTime() < timeout) { + try { + return getStatus(solrUrl); + } catch (SSLPeerUnverifiedException exc) { + throw exc; + } catch (Exception exc) { + if (SolrCLI.exceptionIsAuthRelated(exc)) { + throw exc; + } + try { + Thread.sleep(2000L); + } catch (InterruptedException interrupted) { + timeout = 0; // stop looping + } + } + } + throw new TimeoutException( + "Did not see Solr at " + solrUrl + " come online within " + maxWaitSecs + " seconds!"); + } + + public Map<String, Object> getStatus(String solrUrl) throws Exception { + Map<String, Object> status; + + if (!solrUrl.endsWith("/")) solrUrl += "/"; + + String systemInfoUrl = solrUrl + "admin/info/system"; + CloseableHttpClient httpClient = SolrCLI.getHttpClient(); + try { + // hit Solr to get system info + Map<String, Object> systemInfo = SolrCLI.getJson(httpClient, systemInfoUrl, 2, true); + // convert raw JSON into user-friendly output + status = reportStatus(solrUrl, systemInfo, httpClient); + } finally { + SolrCLI.closeHttpClient(httpClient); + } + + return status; + } + + public Map<String, Object> reportStatus( + String solrUrl, Map<String, Object> info, HttpClient httpClient) throws Exception { + Map<String, Object> status = new LinkedHashMap<>(); + + String solrHome = (String) info.get("solr_home"); + status.put("solr_home", solrHome != null ? solrHome : "?"); + status.put("version", SolrCLI.asString("/lucene/solr-impl-version", info)); + status.put("startTime", SolrCLI.asString("/jvm/jmx/startTime", info)); + status.put("uptime", SolrCLI.uptime(SolrCLI.asLong("/jvm/jmx/upTimeMS", info))); Review Comment: <picture><img alt="15% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/15/display.svg";></picture> <b>*NULL_DEREFERENCE:</b>* object returned by `asLong("/jvm/jmx/upTimeMS",info)` could be null and is dereferenced at line 154. ââ <b>4 similar findings have been found in this PR</b> <details><summary>đ Expand here to view all instances of this finding</summary><br/> <div align=\"center\"> | **File Path** | **Line Number** | | ------------- | ------------- | | solr/core/src/java/org/apache/solr/util/cli/AssertTool.java | [318](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/AssertTool.java#L318) | | solr/core/src/java/org/apache/solr/util/cli/AssertTool.java | [294](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/AssertTool.java#L294) | | solr/core/src/java/org/apache/solr/util/cli/AssertTool.java | [325](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/AssertTool.java#L325) | | solr/core/src/java/org/apache/solr/util/cli/StatusTool.java | [182](https://github.com/apache/solr/blob/37a60aca3471fd76049f364f384b9b789e8820fb/solr/core/src/java/org/apache/solr/util/cli/StatusTool.java#L182) | <p><a href="https://lift.sonatype.com/results/github.com/apache/solr/01GW0BKH5XQMSNX4PER7VH8BBD?t=Infer|NULL_DEREFERENCE" target="_blank">Visit the Lift Web Console</a> to find more details in your report.</p></div></details> --- <details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b> commands</summary> You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings. | **Command** | **Usage** | | ------------- | ------------- | | `@sonatype-lift ignore` | Leave out the above finding from this PR | | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR | | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file | **Note:** When talking to LiftBot, you need to **refresh** the page to see its response. <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details> --- <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b> Was this a good recommendation for you? <sub><small>Answering this survey will not impact your Lift settings.</small></sub> [â[đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=444405192&lift_comment_rating=1) â] - [â[đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=444405192&lift_comment_rating=2) â] - [â[đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=444405192&lift_comment_rating=3) â] - [â[đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=444405192&lift_comment_rating=4) â] - [â[đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=444405192&lift_comment_rating=5) â] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
![https://lift.sonatype.com/api/commentimage/fixrate/0/display.svg"](https://lift.sonatype.com/api/commentimage/fixrate/0/display.svg"){kind=link}
![https://lift.sonatype.com/api/commentimage/fixrate/5/display.svg"](https://lift.sonatype.com/api/commentimage/fixrate/5/display.svg"){kind=link}
![https://lift.sonatype.com/api/commentimage/fixrate/15/display.svg"](https://lift.sonatype.com/api/commentimage/fixrate/15/display.svg"){kind=link}