risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1142293958
##########
solr/core/src/java/org/apache/solr/handler/designer/ManagedSchemaDiff.java:
##########
@@ -215,7 +216,7 @@ protected static Map<String, Object> diff(
* @param simpleOrderedMap2 Map to treat as "right" map
* @return List containing the left diff and right diff
*/
- @SuppressWarnings("unchecked")
Review Comment:
See if there is a java streams way to do this
##########
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##########
@@ -755,6 +756,7 @@ protected ZkStateReader zkStateReader() {
return cc.getZkController().getZkStateReader();
}
+ @SuppressForbidden(reason = "Sets.difference")
Review Comment:
See if there is a java streams way to do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
