vinayakphegde commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1122863133
##
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirConte
risdenk merged PR #1417:
URL: https://github.com/apache/solr/pull/1417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk merged PR #1421:
URL: https://github.com/apache/solr/pull/1421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk commented on PR #1416:
URL: https://github.com/apache/solr/pull/1416#issuecomment-1451881735
@janhoy you probably want to look closer at this one. jose4j has been a
rough upgrade from what I remember in the past from other projects. At least
make sure this doesn't subtly break jwt-a
risdenk commented on PR #1414:
URL: https://github.com/apache/solr/pull/1414#issuecomment-1451883310
> We could define a custom "group" in renovate.json to define these two to
be grouped in same PR in the future, like with httpcomponents.
@janhoy that would be awesome
--
This is an
samuelverstraete commented on issue #483:
URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1451884676
We have exactly the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
risdenk merged PR #1390:
URL: https://github.com/apache/solr/pull/1390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk closed pull request #1427: Update org.apache.curator:* to v5 (major)
URL: https://github.com/apache/solr/pull/1427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
risdenk commented on PR #1427:
URL: https://github.com/apache/solr/pull/1427#issuecomment-1451904870
I wouldn't upgrade this until Hadoop upgrades. We pull this in in
hadoop-auth currently:
```
# git grep -F curator **/build.gradle
solr/modules/hadoop-auth/build.gradle: impleme
risdenk commented on PR #1415:
URL: https://github.com/apache/solr/pull/1415#issuecomment-1451916349
It is used in
`solr/modules/hdfs/src/test/org/apache/hadoop/fs/FileUtil.java` which is part
of Hadoop code for testing. We copied it in to avoid security manager issues.
--
This is an aut
risdenk commented on code in PR #1419:
URL: https://github.com/apache/solr/pull/1419#discussion_r1123156164
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java:
##
@@ -58,7 +58,7 @@ public void solrExporterDurationMetric() th
risdenk commented on code in PR #1419:
URL: https://github.com/apache/solr/pull/1419#discussion_r1123160314
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java:
##
@@ -58,7 +58,7 @@ public void solrExporterDurationMetric() th
risdenk commented on code in PR #1419:
URL: https://github.com/apache/solr/pull/1419#discussion_r1123160738
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java:
##
@@ -58,7 +58,7 @@ public void solrExporterDurationMetric() th
risdenk opened a new pull request, #1429:
URL: https://github.com/apache/solr/pull/1429
* Group together Apache Calcite and Apache Calcite Avatica
* Use `matchPackagePrefixes` instead of regex
* Add google cloud to monthly checks like AWS SDK
--
This is an automated message from the
risdenk commented on PR #1414:
URL: https://github.com/apache/solr/pull/1414#issuecomment-1451943314
Opened https://github.com/apache/solr/pull/1429 to combine them into a group
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
risdenk commented on PR #1423:
URL: https://github.com/apache/solr/pull/1423#issuecomment-1451955702
Yea this is going to be a big change -
https://github.com/jakartaee/rest/releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
risdenk commented on PR #1423:
URL: https://github.com/apache/solr/pull/1423#issuecomment-1451956369
We should look at doing this with Jetty 11 I think -
https://issues.apache.org/jira/browse/SOLR-16441
--
This is an automated message from the Apache Git Service.
To respond to the message
risdenk closed pull request #1423: Update dependency
jakarta.ws.rs:jakarta.ws.rs-api to v3
URL: https://github.com/apache/solr/pull/1423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695737#comment-17695737
]
Kevin Risden commented on SOLR-16441:
-
https://github.com/apache/solr/pull/1423 is re
risdenk merged PR #1426:
URL: https://github.com/apache/solr/pull/1426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk merged PR #1415:
URL: https://github.com/apache/solr/pull/1415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk merged PR #1420:
URL: https://github.com/apache/solr/pull/1420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk commented on PR #1428:
URL: https://github.com/apache/solr/pull/1428#issuecomment-1451965938
This is a relatively big change but one we should probably do. The
dependency names changed so need to take that into account.
--
This is an automated message from the Apache Git Service.
risdenk merged PR #1425:
URL: https://github.com/apache/solr/pull/1425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk merged PR #1402:
URL: https://github.com/apache/solr/pull/1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
solrbot commented on PR #1423:
URL: https://github.com/apache/solr/pull/1423#issuecomment-1451975158
### Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and
you will not receive PRs for *any* future 3.x releases. However, if you upgr
solrbot commented on PR #1427:
URL: https://github.com/apache/solr/pull/1427#issuecomment-1451975454
### Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and
you will not receive PRs for *any* future 5.x releases. However, if you upgr
risdenk commented on PR #1402:
URL: https://github.com/apache/solr/pull/1402#issuecomment-1452020390
This caused these test failures so I reverted it:
```
ERROR: The following test(s) have failed:
-
org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testSubFacetStream
[
https://issues.apache.org/jira/browse/SOLR-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695767#comment-17695767
]
Jason Gerlowski commented on SOLR-14303:
I think it'd probably be worth a separat
janhoy merged PR #1416:
URL: https://github.com/apache/solr/pull/1416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on code in PR #1419:
URL: https://github.com/apache/solr/pull/1419#discussion_r1123315054
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java:
##
@@ -58,7 +58,7 @@ public void solrExporterDurationMetric() thr
janhoy merged PR #1419:
URL: https://github.com/apache/solr/pull/1419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on PR #1413:
URL: https://github.com/apache/solr/pull/1413#issuecomment-1452270624
> I haven't tried these changes, but its sad that the worker thread is just
unmanaged and can't be shutdown.
Yes, they should allow passing in an executor or otherwise control it. But
janhoy merged PR #1413:
URL: https://github.com/apache/solr/pull/1413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695844#comment-17695844
]
ASF subversion and git services commented on SOLR-16683:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695845#comment-17695845
]
ASF subversion and git services commented on SOLR-16683:
Commit 6
risdenk merged PR #1429:
URL: https://github.com/apache/solr/pull/1429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
janhoy commented on PR #1424:
URL: https://github.com/apache/solr/pull/1424#issuecomment-1452324786
Our `analysis-extras` module depends on `lucene-analysis-opennlp` which
depends on `opennlp-tools 1.9.1`. So Solr has to use the exact same version.
I'll try to remove this line from `version
janhoy commented on PR #1424:
URL: https://github.com/apache/solr/pull/1424#issuecomment-1452351278
Re-purposing this PR to remove version override of opennlp-tools in solr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
janhoy commented on code in PR #1399:
URL: https://github.com/apache/solr/pull/1399#discussion_r1123555073
##
versions.props:
##
@@ -8,7 +8,7 @@ com.fasterxml.woodstox:woodstox-core=6.5.0
com.github.ben-manes.caffeine:caffeine=3.1.4
com.github.spotbugs:*=4.7.3
com.github.step
risdenk commented on code in PR #1399:
URL: https://github.com/apache/solr/pull/1399#discussion_r1123559207
##
solr/licenses/auto-value-1.10.1.jar.sha1:
##
@@ -0,0 +1 @@
+e0184c26c3a20257c6fb46eaea16fdd3d7b6d357
Review Comment:
need NOTICE and LICENSE file for auto-value
[
https://issues.apache.org/jira/browse/SOLR-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16683:
---
Fix Version/s: 9.2
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Fre
risdenk commented on code in PR #1399:
URL: https://github.com/apache/solr/pull/1399#discussion_r1123569346
##
versions.props:
##
@@ -8,7 +8,7 @@ com.fasterxml.woodstox:woodstox-core=6.5.0
com.github.ben-manes.caffeine:caffeine=3.1.4
com.github.spotbugs:*=4.7.3
com.github.ste
solrbot commented on PR #1424:
URL: https://github.com/apache/solr/pull/1424#issuecomment-1452385955
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not
recognize the last commit author and assumes somebody else may have edited the
PR.
janhoy commented on PR #1424:
URL: https://github.com/apache/solr/pull/1424#issuecomment-1452404846
Crave.io is not happy when applying its patches
```
error: versions.props: patch does not apply
```
I manually ran both the analysis-extras and langid tests, which pass, and
`v
[
https://issues.apache.org/jira/browse/SOLR-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-16681:
Summary: Replacing uniqueKey field via fl doesn't work in distributed since
9.0 (was: Repl
[
https://issues.apache.org/jira/browse/SOLR-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-16681:
Fix Version/s: 9.2
> Replacing uniqueKey field via fl doesn't work in distributed since 9.0
Jan Høydahl created SOLR-16684:
--
Summary: Keep solr's opennlp-tools version in sync with Lucene
Key: SOLR-16684
URL: https://issues.apache.org/jira/browse/SOLR-16684
Project: Solr
Issue Type: Im
janhoy commented on PR #1424:
URL: https://github.com/apache/solr/pull/1424#issuecomment-1452411168
https://issues.apache.org/jira/browse/SOLR-16684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
janhoy commented on PR #1424:
URL: https://github.com/apache/solr/pull/1424#issuecomment-1452420513
Merged by hand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
janhoy closed pull request #1424: SOLR-16684 Stop overriding
org.apache.opennlp:opennlp-tools in solr
URL: https://github.com/apache/solr/pull/1424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/SOLR-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16684.
Fix Version/s: 9.2
Resolution: Fixed
> Keep solr's opennlp-tools version in sync with Lucene
[
https://issues.apache.org/jira/browse/SOLR-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695871#comment-17695871
]
Mikhail Khludnev commented on SOLR-16681:
-
I think like [https://github.com/apach
[
https://issues.apache.org/jira/browse/SOLR-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695870#comment-17695870
]
ASF subversion and git services commented on SOLR-16684:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695872#comment-17695872
]
ASF subversion and git services commented on SOLR-16684:
Commit 7
risdenk merged PR #1399:
URL: https://github.com/apache/solr/pull/1399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk merged PR #1397:
URL: https://github.com/apache/solr/pull/1397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695871#comment-17695871
]
Mikhail Khludnev edited comment on SOLR-16681 at 3/2/23 8:05 PM:
--
stillalex commented on PR #1410:
URL: https://github.com/apache/solr/pull/1410#issuecomment-1452676506
@dsmiley good news and bad news :) I finally managed to add tests (and cover
failure scenarios too) thanks for the pointers, I was tempted to not go the
extra mile.
now the not so great
[
https://issues.apache.org/jira/browse/SOLR-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695924#comment-17695924
]
Erick Erickson commented on SOLR-8238:
--
OK, you're asking me to get in the way-back m
stillalex commented on PR #1410:
URL: https://github.com/apache/solr/pull/1410#issuecomment-1452711234
trying the `ShardHandlerFactory#sizeOfQueue` setting on a Solr 9 definitely
shows some weirdness, I'm unable to create a collection:
```
2023-03-02 15:15:40.028 INFO (qtp2048013503-2
[
https://issues.apache.org/jira/browse/SOLR-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696011#comment-17696011
]
David Smiley commented on SOLR-8238:
I think what you describe is a case *for* what th
62 matches
Mail list logo
