risdenk commented on code in PR #1419:
URL: https://github.com/apache/solr/pull/1419#discussion_r1123160314
##########
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java:
##########
@@ -58,7 +58,7 @@ public void solrExporterDurationMetric() throws Exception {
assertTrue(durationHistogram.get("solr_exporter_duration_seconds_sum") >
0);
// 17 = (15 buckets in the histogram) + (count metric) + (sum metric)
- assertEquals(17, durationHistogram.size());
+ assertEquals(18, durationHistogram.size());
Review Comment:
Ah bingo:
* https://github.com/prometheus/client_java/pull/615
which came in as part of
https://github.com/prometheus/client_java/releases/tag/parent-0.10.0
There is
https://github.com/prometheus/client_java/releases/tag/parent-0.16.0 which has
https://github.com/prometheus/client_java/pull/791
*
https://github.com/prometheus/client_java/tree/main#disabling-_created-metrics
I don't think this is an issue and just updating the count makes sense. The
comment should be updated though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
