stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1452676506
@dsmiley good news and bad news :) I finally managed to add tests (and cover failure scenarios too) thanks for the pointers, I was tempted to not go the extra mile. now the not so great news. I believe there might be a deadlock on the Http2SolrClient when configured with an ArrayBlockingQueue. I was not able to find tests for this config, but it's definitely possible to have this enabled via the HttpShardHandlerFactory configs. please take a look at https://github.com/apache/solr/pull/1410/commits/a9f9af819ed094a504c60b17da8607e66afc6a67 and possibly tell me what I did wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
