joshgog commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1058265485
##
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##
@@ -30,15 +35,19 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase
{
@BeforeCla
[
https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652477#comment-17652477
]
Eric Pugh commented on SOLR-10452:
--
Hi allI'd love some guidence on this ticket,
[
https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652477#comment-17652477
]
Eric Pugh edited comment on SOLR-10452 at 12/28/22 11:47 AM:
-
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1058297053
##
solr/test-framework/src/java/org/apache/solr/util/EmbeddedSolrServerTestRule.java:
##
@@ -53,7 +55,7 @@ public class Builder {
private Path solrHome;
private St
epugh commented on PR #1177:
URL: https://github.com/apache/solr/pull/1177#issuecomment-1366607559
Some great fixes @justinrsweeney here.. Feel free to ping me and @janhoy
when you are ready for more review!
--
This is an automated message from the Apache Git Service.
To respond to the
epugh opened a new pull request, #1253:
URL: https://github.com/apache/solr/pull/1253
https://issues.apache.org/jira/browse/SOLR-10452
# Description
setQueryParams should be deprecated in favor of SolrClientBuilder methods.
# Solution
I moved the the setQueryPa
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366649214
Hey @stillalex would love a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-10452:
Assignee: Eric Pugh
> setQueryParams should be deprecated in favor of SolrClientBuilder methods
>
[
https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652499#comment-17652499
]
Eric Pugh commented on SOLR-10452:
--
I did push up a PR that moves it. The method addQu
Eric Pugh created SOLR-16599:
Summary: Use ventilated prose in our ascii docs
Key: SOLR-16599
URL: https://issues.apache.org/jira/browse/SOLR-16599
Project: Solr
Issue Type: Improvement
Sec
epugh commented on PR #1254:
URL: https://github.com/apache/solr/pull/1254#issuecomment-1366682617
I'm trying to get a good pattern for using __ventilated prose__ i.e one
sentence per line. Right now my regex is failing. I'm finding violations in
`zookeeper-utilities.adoc`, but visual ins
epugh opened a new pull request, #1254:
URL: https://github.com/apache/solr/pull/1254
https://issues.apache.org/jira/browse/SOLR-16599
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Plea
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1058397971
##
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##
@@ -30,15 +35,19 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase
{
@BeforeCla
epugh commented on PR #1254:
URL: https://github.com/apache/solr/pull/1254#issuecomment-1366752459
okay, hacked something together. This is very much a heuristic of "what is
not a complete sentence on a line". It has flagged **287** places where we
have NOT followed the best practice of v
stillalex commented on code in PR #1248:
URL: https://github.com/apache/solr/pull/1248#discussion_r1058444341
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -147,6 +148,7 @@ public static class Builder {
private ResponseParser resp
stillalex commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1366757868
I agree eliminating the property is more work. I don't have a preference
here. I would add the system property support (left a comment at the relevant
line) and not remove builder support
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366778424
tests all pass!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
[
https://issues.apache.org/jira/browse/SOLR-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652536#comment-17652536
]
Eric Pugh commented on SOLR-16599:
--
I'd love to hear from folks on if we think rolling t
[
https://issues.apache.org/jira/browse/SOLR-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652537#comment-17652537
]
Eric Pugh commented on SOLR-16599:
--
We could apply this to our .md files as well...
> U
stillalex commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058496493
##
solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java:
##
@@ -138,19 +138,19 @@ public UpdateShardHandler(UpdateShardHandlerConfig cfg) {
HttpCli
stillalex commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058496938
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -991,6 +992,7 @@ public static class Builder {
private ExecutorService executor
stillalex commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058496938
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -991,6 +992,7 @@ public static class Builder {
private ExecutorService executor
stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366816568
I find LBHttp2SolrClient's use of queryParams a bit confusing (it seems to
be on LBSolrClient level), apologies if this is just my incorrect
understanding. Why does the LBSolrClient need t
stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366828996
proposal for DelegationTokenHttpSolrClient:
* move constructor 'setQueryParams(' call to Builder itself. the call comes
from the builder already, so no added complexity
https://github.
stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058540783
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -99,37 +85,34 @@ protected void close() {
waitForLoadingCoresToFinish(30 * 1000);
Collection c
stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058541193
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -99,37 +85,34 @@ protected void close() {
waitForLoadingCoresToFinish(30 * 1000);
Collection c
stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058541893
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -99,37 +85,34 @@ protected void close() {
waitForLoadingCoresToFinish(30 * 1000);
Collection c
stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058547533
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -423,6 +424,20 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
dsmiley commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058555293
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java:
##
@@ -661,12 +661,13 @@ private void verifyServletState(Http2SolrClient client,
SolrRe
epugh commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058561116
##
solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java:
##
@@ -138,19 +138,19 @@ public UpdateShardHandler(UpdateShardHandlerConfig cfg) {
HttpClientU
epugh commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058561752
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -991,6 +992,7 @@ public static class Builder {
private ExecutorService executor;
epugh commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058565251
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##
@@ -325,9 +338,24 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int
aliveChe
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366894780
> LBHttp2SolrClient
Would you be interested in pushing up a commit to make this change to remove
the method? I'd lvoe to see it!
--
This is an automated message from the Apache Git S
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366896499
> * setQueryParams
Likewise @stillalex I think I get what you are suggesting, you want to push
up a change for this?
--
This is an automated message from the Apache Git Service.
To
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366899956
Okay, I think I've dealt with the small changes. @stillalex I'd love you
to push up changes for the two suggestions you had, they sound great.
@dsmiley maybe you can weigh in on the name o
dsmiley commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058586092
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##
@@ -325,9 +338,24 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int
aliveC
epugh commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058586645
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##
@@ -325,9 +338,24 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int
aliveChe
dsmiley commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058589620
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##
@@ -325,9 +338,24 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int
aliveC
dsmiley commented on code in PR #1247:
URL: https://github.com/apache/solr/pull/1247#discussion_r1058591414
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -257,6 +258,17 @@ public Builder setRetryExpiryTime(int secs) {
return thi
[
https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652604#comment-17652604
]
David Smiley commented on SOLR-10452:
-
All looks good to me Eric.
6 years ago now, [
dsmiley commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1366923901
I don't think we need to document expert/advanced things in the reference
guide _like this_. I'm not saying there shouldn't be any such there, only that
we should not be compelled to.
--
stillalex commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058609508
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient {
private static
epugh commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058612968
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient {
private static fin
dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058608729
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -99,37 +85,34 @@ protected void close() {
waitForLoadingCoresToFinish(30 * 1000);
Collection cor
stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366932660
> > * setQueryParams
>
> Likewise @stillalex I think I get what you are suggesting, you want to
push up a change for this?
sure. how should we do this? push a proposed change
stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058637844
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -99,37 +85,34 @@ protected void close() {
waitForLoadingCoresToFinish(30 * 1000);
Collection c
stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058639863
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -99,37 +85,34 @@ protected void close() {
waitForLoadingCoresToFinish(30 * 1000);
Collection c
dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058640843
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -99,37 +85,34 @@ protected void close() {
waitForLoadingCoresToFinish(30 * 1000);
Collection cor
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366972806
> > > * setQueryParams
> >
> >
> > Likewise @stillalex I think I get what you are suggesting, you want to
push up a change for this?
>
> sure. how should we do this? push a pr
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366973016
> > > > * setQueryParams
> > >
> > >
> > > Likewise @stillalex I think I get what you are suggesting, you want to
push up a change for this?
> >
> >
> > sure. how should w
stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366974464
ok. I was not able to push to your git, not sure why, I don't think I have
the rights. I pushed to my repo based on your branch. could you take a look and
let me know if it looks ok?
http
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366975670
odd, cause I think you have permissiosn to apache/solr repo? Can you check
out the PR from apache/solr instead of my branch from epugh/solr, and then push
up changes
--
This is an
stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058645457
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -99,37 +85,34 @@ protected void close() {
waitForLoadingCoresToFinish(30 * 1000);
Collection c
stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366978519
> odd, cause I think you have permissiosn to apache/solr repo? Can you check
out the PR from apache/solr instead of my branch from epugh/solr, and then push
up changes
I don't,
stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366979347
suggested fix for the DelegationTokenHttpSolrClient
https://github.com/stillalex/solr/commit/5086e0fe099d5c2fa5942c6b3f18b7d803370136
.
The constructor code looks a bit iffy to me.
epugh commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1367017948
@stillalex I learned somethign new! added you as another repo, and was able
to cherry-pick your commit!
--
This is an automated message from the Apache Git Service.
To respond to the messag
stillalex commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058699692
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient {
private static
stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1367037337
I've seen you only partially took changes from
https://github.com/stillalex/solr/commit/0490ab420ff1d90536f3572fc7b17b194f0724c1
was there anything failing? or was the change too drastic?
58 matches
Mail list logo
