dsmiley commented on code in PR #1247:
URL: https://github.com/apache/solr/pull/1247#discussion_r1058591414
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -257,6 +258,17 @@ public Builder setRetryExpiryTime(int secs) {
return this;
}
+ /**
+ * Sets the cache ttl for DocCollection Objects cached.
+ *
+ * @param timeToLiveSeconds ttl value in seconds
+ */
+ public Builder setCollectionCacheTtl(int timeToLiveSeconds) {
Review Comment:
`with`
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##########
@@ -87,6 +87,7 @@ protected CloudLegacySolrClient(Builder builder) {
this.stateProvider = builder.stateProvider;
}
this.retryExpiryTime = builder.retryExpiryTime;
+ this.collectionStateCache.timeToLiveMs = builder.timeToLive * 1000L;
Review Comment:
if the builder's timeToLive field were timeToLiveSec then it would be
clearer its seconds
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##########
@@ -270,6 +271,17 @@ public Builder withLBHttpSolrClient(LBHttpSolrClient
loadBalancedSolrClient) {
return this;
}
+ /**
+ * Sets the cache ttl for DocCollection Objects cached.
+ *
+ * @param seconds ttl value in seconds
+ */
+ public Builder setCollectionCacheTtl(int seconds) {
Review Comment:
`with`
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##########
@@ -270,6 +271,17 @@ public Builder withLBHttpSolrClient(LBHttpSolrClient
loadBalancedSolrClient) {
return this;
}
+ /**
+ * Sets the cache ttl for DocCollection Objects cached.
+ *
+ * @param seconds ttl value in seconds
+ */
+ public Builder setCollectionCacheTTL(int seconds) {
Review Comment:
Changing them again later leads to more changes. You could raise this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
