epugh commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058561752
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ########## @@ -991,6 +992,7 @@ public static class Builder { private ExecutorService executor; protected RequestWriter requestWriter; protected ResponseParser responseParser; + private volatile Set<String> queryParams = Collections.emptySet(); Review Comment: we should make this set.of everywehre ;-) And prevent the Collections.emptySet via forbidden apis... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org