bszabo97 commented on PR #1196:
URL: https://github.com/apache/solr/pull/1196#issuecomment-1361092894
Hello @gerlowskija
Thanks for the heads up and for the great description of what should be
changed in the tests. I have added a commit which changes the test and
implementation acco
alessandrobenedetti commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1361107904
> I'm looking closer at KnnQParser; ...
David, your help has been invaluable!
You are absolutely right and this is an oversight of mine when I did the
original review of
bruno-roustant commented on code in PR #1215:
URL: https://github.com/apache/solr/pull/1215#discussion_r1054213209
##
solr/core/src/java/org/apache/solr/cloud/api/collections/MigrateCmd.java:
##
@@ -253,7 +252,7 @@ private void migrateKey(
SHARD_ID_PROP,
bruno-roustant commented on PR #1215:
URL: https://github.com/apache/solr/pull/1215#issuecomment-1361142463
@noblepaul I don't fully understand your point RE _"Introducing a new type
of Router needs more reviews"_.
To me this PR does not add a new type of DocRouter, as it is centered arou
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650816#comment-17650816
]
Maulin commented on SOLR-16556:
---
Hi [~jbernste] ,
Thanks for reviewing this and providing
tiimbz commented on issue #483:
URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1361368911
We are having the same issue. The `prometheus.io/port` annotation is set to
port `80`, which doesn't correspond with the port of the pod. This causes
Prometheus to fail to scrape
[
https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650895#comment-17650895
]
Rudi Seitz commented on SOLR-16594:
---
Steps to reproduce inconsistent {{mm}} behavior ca
[
https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650895#comment-17650895
]
Rudi Seitz edited comment on SOLR-16594 at 12/21/22 2:32 PM:
-
tiimbz commented on issue #483:
URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1361389034
Looking at the code, it looks like the `prometheus.io/port` value is set
from `ExtSolrMetricsPort`, not `SolrMetricsPort` which would have fixed the
problem.
Any attempts t
[
https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650895#comment-17650895
]
Rudi Seitz edited comment on SOLR-16594 at 12/21/22 2:34 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650895#comment-17650895
]
Rudi Seitz edited comment on SOLR-16594 at 12/21/22 2:37 PM:
-
magibney merged PR #1236:
URL: https://github.com/apache/solr/pull/1236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
[
https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650903#comment-17650903
]
ASF subversion and git services commented on SOLR-16585:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650905#comment-17650905
]
ASF subversion and git services commented on SOLR-16585:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650906#comment-17650906
]
ASF subversion and git services commented on SOLR-16585:
Commit 8
magibney commented on PR #1236:
URL: https://github.com/apache/solr/pull/1236#issuecomment-1361455049
Thanks everyone; committed and backported to `branch_9x` and `branch_9_1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney updated SOLR-16585:
--
Fix Version/s: 9.1.1
> All docs query with any nonzero positive start value throws NPE with
>
[
https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney resolved SOLR-16585.
---
Fix Version/s: main (10.0)
9.2
Resolution: Fixed
> All docs query w
[
https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rudi Seitz updated SOLR-16594:
--
Description:
When parsing a multi-term query that spans multiple fields, edismax sometimes
switches fr
[
https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rudi Seitz updated SOLR-16594:
--
Description:
When parsing a multi-term query that spans multiple fields, edismax sometimes
switches fr
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650929#comment-17650929
]
ASF subversion and git services commented on SOLR-16567:
Commit e
alessandrobenedetti commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1361661204
Ok, I updated the PR, this is what I have done:
1) workaround to fix the bug and renames suggested by @dsmiley
2) opened a pull request in Lucene to implement getters in the
patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054654494
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
* only a r
patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054663494
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -261,9 +259,10 @@ private static DocCollection collectionFromObjects(
if (log.isDebug
patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054663494
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -261,9 +259,10 @@ private static DocCollection collectionFromObjects(
if (log.isDebug
patsonluk commented on PR #1242:
URL: https://github.com/apache/solr/pull/1242#issuecomment-1361754709
> @justinrsweeney @patsonluk this is still WIP , reviews are welcome
Thanks for the work @noblepaul ! Just want to confirm that there are mainly
2 goals here:
1. Avoid making copi
patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054663494
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -261,9 +259,10 @@ private static DocCollection collectionFromObjects(
if (log.isDebug
patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054663494
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -261,9 +259,10 @@ private static DocCollection collectionFromObjects(
if (log.isDebug
dsmiley commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1361766495
Thanks for your complements.
Can't you simply use SolrIndexSearcher#getProcessedFilter now?
As to your proposal, I am confused as to exactly where you propose inserting
the logi
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650961#comment-17650961
]
David Smiley commented on SOLR-16567:
-
The above comment by ASF's git integration sho
alessandrobenedetti closed pull request #129: SOLR-15407 untokenized field type
with sow=false fix + tests
URL: https://github.com/apache/solr/pull/129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650967#comment-17650967
]
Rudi Seitz commented on SOLR-16594:
---
This is a rough outline of the code changes that m
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650966#comment-17650966
]
Alessandro Benedetti commented on SOLR-16567:
-
Just a mistake from intellj! R
alessandrobenedetti commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1361847032
Hi @dsmiley ,
once we have the Lucene changes, the idea is to change this method:
org.apache.solr.search.QueryUtils#combineQueryAndFilter
with an additional if clause:
alessandrobenedetti commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1361848344
And yes, in the workaround I can use the getProcessedFilters and I will, but
once we have the Lucene side it will go away.
--
This is an automated message from the Apache Git S
dsmiley commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1361863063
A special case nearly anywhere (except directly in KNN oriented code of
course) is a design/maintenance issue. Some special cases like MatchAllDocs
are understandable but a check for KNN in
alessandrobenedetti commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1361889301
Ok, I'll produce another branch with the example code assuming Lucene
changes are there.
So what I am trying to accomplish:
1) Knn Query has a Query filter as a construc
alessandrobenedetti opened a new pull request, #1246:
URL: https://github.com/apache/solr/pull/1246
just for @dsmiley to have the idea of what I meant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alessandrobenedetti commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1362008815
here a rough pull request just to give you the idea @dsmiley :
https://github.com/apache/solr/pull/1246/files
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650984#comment-17650984
]
Shawn Heisey commented on SOLR-15859:
-
[~ben.manes] Thank you for all the patience yo
[
https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650990#comment-17650990
]
Michael Gibney commented on SOLR-15859:
---
I think it might be possible (and preferab
[
https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650996#comment-17650996
]
Shawn Heisey commented on SOLR-15859:
-
[~magibney] I'm not going to rule anything out
HoustonPutman opened a new pull request, #509:
URL: https://github.com/apache/solr-operator/pull/509
https://github.com/apache/solr-operator/pull/455 introduced a bug for
non-recurring backups that was unearthed while working on
https://github.com/apache/solr-operator/pull/507
Basica
noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054984613
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
* only a r
noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054985346
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -261,9 +259,10 @@ private static DocCollection collectionFromObjects(
if (log.isDebug
noblepaul commented on code in PR #1215:
URL: https://github.com/apache/solr/pull/1215#discussion_r1054986541
##
solr/core/src/java/org/apache/solr/update/SolrIndexSplitter.java:
##
@@ -765,18 +766,11 @@ static FixedBitSet[] split(
return docSets;
}
- public static St
noblepaul commented on PR #1215:
URL: https://github.com/apache/solr/pull/1215#issuecomment-1362270740
```To me this PR does not add a new type of DocRouter, as it is centered
around CompositeIdRouter```
I was confused by the original description. thought this was trying to
introduc
patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054994623
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
* only a r
patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054994623
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
* only a r
noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1055057270
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
* only a r
noblepaul commented on PR #1242:
URL: https://github.com/apache/solr/pull/1242#issuecomment-1362371622
>Avoid making copies of DocCollections when copyWith is called (related to
PRS updates)
Yes
> Avoid fetching PRS states until the state is actually queried (the Lazy
PRS prov
dsmiley commented on code in PR #1215:
URL: https://github.com/apache/solr/pull/1215#discussion_r105508
##
solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java:
##
@@ -263,8 +263,9 @@ private void handleGetRanges(CoreAdminHandler.CallInfo it,
String coreName) thro
[
https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651088#comment-17651088
]
Shawn Heisey commented on SOLR-15859:
-
{quote}I think it might be possible (and prefe
53 matches
Mail list logo
