noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054985346
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##########
@@ -261,9 +259,10 @@ private static DocCollection collectionFromObjects(
if (log.isDebugEnabled()) {
log.debug("a collection {} has per-replica state", name);
}
- // this collection has replica states stored outside
- ReplicaStatesProvider rsp = REPLICASTATES_PROVIDER.get();
- if (rsp instanceof StatesProvider) ((StatesProvider)
rsp).isPerReplicaState = true;
+ } else {
+ // prior to this call, PRS provider is set. We should unset it before
+ // deserializing the replicas and slices
+ DocCollection.clearReplicaStateProvider();
Review Comment:
I'm aware of this problem . The ideal solution would be to pass on the
`PrsSupplier` with the constructor. I'm trying to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
