Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-29 Thread via GitHub
epugh merged PR #2657: URL: https://github.com/apache/solr/pull/2657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-28 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1734948359 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/OutliersEvaluator.java: ## @@ -97,13 +97,13 @@ public Object doWork(Object... values) throws IOExceptio

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-28 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1734564695 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/OutliersEvaluator.java: ## @@ -97,13 +97,13 @@ public Object doWork(Object... values) throws IOExceptio

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-27 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1732527482 ## solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/StreamingTest.java: ## @@ -1348,7 +1348,7 @@ private void checkReturnValsForEmpty(String[] fields) t

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729257930 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/OutliersEvaluator.java: ## @@ -97,13 +97,13 @@ public Object doWork(Object... values) throws IOExceptio

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729256408 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/HashJoinStream.java: ## @@ -55,7 +55,7 @@ public class HashJoinStream extends TupleStream implements

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729255006 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/MergeStream.java: ## @@ -224,7 +224,7 @@ public Tuple read() throws IOException { // If all EO

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729254232 ## solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/StreamingTest.java: ## @@ -1348,7 +1348,7 @@ private void checkReturnValsForEmpty(String[] fields) t

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
cpoerschke commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729208565 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/NotNullEvaluator.java: ## @@ -45,7 +45,7 @@ public Object doWork(Object... values) throws IOExcept

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on PR #2657: URL: https://github.com/apache/solr/pull/2657#issuecomment-2307002076 This is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1728897327 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/Matrix.java: ## @@ -61,8 +61,8 @@ public List getRowLabels() { return rowLabels; } - public