Re: [PR] SOLR-17692: Abort ongoing fetches on core close [solr]

2025-04-02 Thread via GitHub
gerlowskija merged PR #3292: URL: https://github.com/apache/solr/pull/3292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-17692: Abort ongoing fetches on core close [solr]

2025-03-27 Thread via GitHub
gerlowskija commented on code in PR #3292: URL: https://github.com/apache/solr/pull/3292#discussion_r2017514015 ## solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java: ## @@ -188,6 +189,9 @@ public final void close() { close = true; cancelPrepRecoveryCmd();

Re: [PR] SOLR-17692: Abort ongoing fetches on core close [solr]

2025-03-27 Thread via GitHub
gerlowskija commented on PR #3292: URL: https://github.com/apache/solr/pull/3292#issuecomment-2759344996 Thanks! I'd still really like to find a way to get this covered by automated tests, but I can't come up with a good way to cover it. A unit test should be possible but the mockin

Re: [PR] SOLR-17692: Abort ongoing fetches on core close [solr]

2025-03-27 Thread via GitHub
gerlowskija commented on code in PR #3292: URL: https://github.com/apache/solr/pull/3292#discussion_r2017514015 ## solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java: ## @@ -188,6 +189,9 @@ public final void close() { close = true; cancelPrepRecoveryCmd();

Re: [PR] SOLR-17692: Abort ongoing fetches on core close [solr]

2025-03-27 Thread via GitHub
gerlowskija commented on code in PR #3292: URL: https://github.com/apache/solr/pull/3292#discussion_r2017514015 ## solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java: ## @@ -188,6 +189,9 @@ public final void close() { close = true; cancelPrepRecoveryCmd();

[PR] SOLR-17692: Abort ongoing fetches on core close [solr]

2025-03-27 Thread via GitHub
gerlowskija opened a new pull request, #3292: URL: https://github.com/apache/solr/pull/3292 https://issues.apache.org/jira/browse/SOLR-17692 # Description I recently deleted a NRT replica that was in the middle of a full-recovery and was a bit surprised to see that the "delete"