gerlowskija commented on code in PR #3292:
URL: https://github.com/apache/solr/pull/3292#discussion_r2017514015
##########
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##########
@@ -188,6 +189,9 @@ public final void close() {
close = true;
cancelPrepRecoveryCmd();
log.warn("Stopping recovery for core=[{}] coreNodeName=[{}]", coreName,
coreZkNodeName);
+ if (replicationHandlerDoingFetch != null) {
Review Comment:
[Q] Technically, there's a possibility here that
'replicationHandlerDoingFetch' is unset after we've checked the conditional,
but before we call `abortFetch()1. If that happens, it's lead to a NPE on the
`abortFetch()` call. But it seems so remote that I'm not sure it's worth the
complexity of guarding against it....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
