gerlowskija opened a new pull request, #3292: URL: https://github.com/apache/solr/pull/3292
https://issues.apache.org/jira/browse/SOLR-17692 # Description I recently deleted a NRT replica that was in the middle of a full-recovery and was a bit surprised to see that the "delete" blocked waiting for the recovery to finish. This is a minor pain when the index is small, but becomes a huge waste of administrator time (and network bandwidth!) as index sizes grow. There's some plumbing in Solr that attempts to preempt recovery during a DELETE, but it appears that it mostly comes into play during peer-sync and "background replication" scenarios (i.e. PULL and TLOG replicas that do full-recovery during normal operation). Preemption doesn't seem to work once a recovering core is in the midst of a "full recovery". `RecoveryStrategy.close()` sets a boolean flag that is checked at various points in the recovery process, and can preempt recovery at those points. But the flag isn't visible to `IndexFetcher`, where the bulk of a full-recovery's time gets spent. # Solution This commit aims to fix this by having `RecoveryStrategy.close()` invoke an existing `ReplicationHandler.abortFetch`, which sets a flag that *is* noticed by IndexFetcher. This should ensure that long-running recovery operations don't block DELETEREPLICA or other core-shutdown paths. # Tests Manual testing. May need some help figuring out a way to exercise this in an automated test, given the timing-dependent nature of the bug and fix. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
