dsmiley merged PR #2927:
URL: https://github.com/apache/solr/pull/2927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1915917903
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -1170,6 +1171,21 @@ protected Object _getHandler() {
return handler;
}
+ /** Gets the cli
dsmiley commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1915918653
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -1170,6 +1171,21 @@ protected Object _getHandler() {
return handler;
}
+ /** Gets the cli
dsmiley commented on PR #2927:
URL: https://github.com/apache/solr/pull/2927#issuecomment-2591610680
Ready to merge; will do within a couple days if I hear nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dsmiley commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1914069901
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##
@@ -73,7 +74,7 @@ public class HttpJdkSolrClient extends HttpSolrClientBase {
privat
dsmiley commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1914062827
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -1170,6 +1171,21 @@ protected Object _getHandler() {
return handler;
}
+ /** Gets the cli
madrob commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1913952760
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##
@@ -73,7 +74,7 @@ public class HttpJdkSolrClient extends HttpSolrClientBase {
private
dsmiley commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1913233926
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -106,11 +106,15 @@
*
*/
public class Http2SolrClient extends HttpSolrClientBase
jdyer1 commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1909541445
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -106,11 +106,15 @@
*
*/
public class Http2SolrClient extends HttpSolrClientBase {
jdyer1 commented on PR #2927:
URL: https://github.com/apache/solr/pull/2927#issuecomment-2581363581
There are asserts in the unit tests for the user-agent, so changing it will
cause failures I think. See `HttpSolrClientTestBase#expectedUserAgent`. If we
put the specification version in a
dsmiley opened a new pull request, #2927:
URL: https://github.com/apache/solr/pull/2927
https://issues.apache.org/jira/browse/SOLR-17611 (read this for context)
No tests. I suppose the best test would be something in the smoke test
which is at release time where we definitely have th
11 matches
Mail list logo
