jdyer1 commented on PR #2927: URL: https://github.com/apache/solr/pull/2927#issuecomment-2581363581
There are asserts in the unit tests for the user-agent, so changing it will cause failures I think. See `HttpSolrClientTestBase#expectedUserAgent`. If we put the specification version in a `protected static` variable, the unit test can easily override it, which might be adequate enough of a unit testing strategy? I was looking around and maybe ByteBuddy's `PackageDefinitionStrategy` could be used to mock this? Even if possible (I have no idea) I guess that would be more effort than it is worth! I agree something in the smoke tester would be the best way to verify correctness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
