dsmiley commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1913233926
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -106,11 +106,15 @@
* </ul>
*/
public class Http2SolrClient extends HttpSolrClientBase {
+ private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
public static final String REQ_PRINCIPAL_KEY = "solr-req-principal";
+ private static final String USER_AGENT =
+ "Solr["
Review Comment:
I'd hate to create constants merely for the parts of this string that we
concatenate -- I hate that coding practice, to be blunt. I could see a utility
method that composes them. But any way it's tested so I'm not sure what the
risk/concern of _not_ doing what you suggest is. This is a one-liner BTW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
