mkhludnev commented on PR #2289:
URL: https://github.com/apache/solr/pull/2289#issuecomment-1966043239
I think it's test only change, thus it doesn't deserves CHANGES entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mkhludnev merged PR #2289:
URL: https://github.com/apache/solr/pull/2289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
dsmiley commented on PR #2289:
URL: https://github.com/apache/solr/pull/2289#issuecomment-1964559036
> if this bi-arg constructor works, should I use RuleChain or just @Rule
RuleChain is for more compactly listing many rules and/or if the ordering is
important and should be clear. He
mkhludnev commented on PR #2289:
URL: https://github.com/apache/solr/pull/2289#issuecomment-1962466520
> SystemPropertiesRestoreRule instead. See its constructor that takes the
key and value.
I'm ok with this proposal @dsmiley. But I can't find any usage of two args
constructor, so
mkhludnev commented on code in PR #2289:
URL: https://github.com/apache/solr/pull/2289#discussion_r1500999247
##
solr/test-framework/src/java/org/apache/solr/util/RandomNoReverseMergePolicyFactory.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mkhludnev commented on PR #2289:
URL: https://github.com/apache/solr/pull/2289#issuecomment-1961918903
@dsmiley thanks for the guidance. I'll check it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mkhludnev commented on code in PR #2289:
URL: https://github.com/apache/solr/pull/2289#discussion_r1500999247
##
solr/test-framework/src/java/org/apache/solr/util/RandomNoReverseMergePolicyFactory.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mkhludnev commented on code in PR #2289:
URL: https://github.com/apache/solr/pull/2289#discussion_r1500997886
##
solr/test-framework/src/java/org/apache/solr/util/RandomNoReverseMergePolicyFactory.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dsmiley commented on code in PR #2289:
URL: https://github.com/apache/solr/pull/2289#discussion_r1498402237
##
solr/test-framework/src/java/org/apache/solr/util/RandomNoReverseMergePolicyFactory.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
mkhludnev commented on PR #2289:
URL: https://github.com/apache/solr/pull/2289#issuecomment-1956045699
The scope has blown up. Are there other tests rely on block alignment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mkhludnev commented on PR #2289:
URL: https://github.com/apache/solr/pull/2289#issuecomment-1954738998
It needs to be spread across other block join tests as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
11 matches
Mail list logo
