dsmiley commented on PR #2289: URL: https://github.com/apache/solr/pull/2289#issuecomment-1964559036
> if this bi-arg constructor works, should I use RuleChain or just @Rule RuleChain is for more compactly listing many rules and/or if the ordering is important and should be clear. Here, I think simply @ClassRule for an entire test source file (aka test suite). > Then if I use this rule, I need to copy-paste prop name from systemSetPropertySolrTestsMergePolicyFactory that doesn't seem good for me. Could define the Map.of(...,...) constant in SolrTestCase. This rule accepts a Map constructor. I personally don't care; string literals don't bother me. Some people seem religious about avoiding them. 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
