mkhludnev commented on PR #2289: URL: https://github.com/apache/solr/pull/2289#issuecomment-1962466520
> SystemPropertiesRestoreRule instead. See its constructor that takes the key and value. I'm ok with this proposal @dsmiley. But I can't find any usage of two args constructor, so far all tests use `systemSetPropertySolrTestsMergePolicyFactory`. As far as I understand `SystemPropertiesRestoreRule` rule already applied and restores props thus, I don't need to bother about restoring in `@AfterClass` - ok. Then if I use this rule, I need to copy-paste prop name from `systemSetPropertySolrTestsMergePolicyFactory` that doesn't seem good for me. if this bi-arg constructor works, should I use `RuleChain` or just `@Rule`? Note: I changed `SolrTestCase` just to fix its' subclasses which don't inherit `SolrTestCase4J`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
