Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-12-08 Thread via GitHub
dsmiley commented on PR #2432: URL: https://github.com/apache/solr/pull/2432#issuecomment-2526289611 I don't think we should add additional methods to an important class like ClusterState unless we think it's "worthy". This PR introduces a method called by only ZkController; so let's inste

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-14 Thread via GitHub
HoustonPutman merged PR #2432: URL: https://github.com/apache/solr/pull/2432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-10 Thread via GitHub
markrmiller commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1596499979 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { *

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-06 Thread via GitHub
murblanc commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1591646646 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Be

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-03 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1589735301 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -181,29 +183,46 @@ public String getShardId(String nodeName, String coreName) { } pub

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588143175 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Bes

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588098873 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588090685 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Bes

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588090034 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588078459 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Bes

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588050937 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588046237 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r158684 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Bes

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1586807196 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -181,29 +183,46 @@ public String getShardId(String nodeName, String coreName) { } pub

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-01 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1586783103 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -181,29 +183,46 @@ public String getShardId(String nodeName, String coreName) { }

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1586719024 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -181,29 +183,46 @@ public String getShardId(String nodeName, String coreName) { } pub