dsmiley commented on PR #2432: URL: https://github.com/apache/solr/pull/2432#issuecomment-2526289611
I don't think we should add additional methods to an important class like ClusterState unless we think it's "worthy". This PR introduces a method called by only ZkController; so let's instead have ZkController have this logic so we can keep ClusterState smaller with fewer obscure methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
